diff mbox series

Fix warnings seen by clang in gcc/symbol-summary.h.

Message ID 39338d02-01bc-d4a2-01ec-3ca4f3c1c01a@suse.cz
State New
Headers show
Series Fix warnings seen by clang in gcc/symbol-summary.h. | expand

Commit Message

Martin Liška June 26, 2019, 6:46 a.m. UTC 
Hi.

The patch is about missing argument to function call and
unused arguments in symbol-summary.h.

Patch can bootstrap on x86_64-linux-gnu and survives regression tests.

Ready to be installed?
Thanks,
Martin

gcc/ChangeLog:

2019-06-25  Martin Liska  <mliska@suse.cz>

	* symbol-summary.h (traverse): Pass
	argument a to the call of callback.
	(gt_ggc_mx): Mark arguments as unused.
	(gt_pch_nx): Likewise.
---
 gcc/symbol-summary.h | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

Comments

Jeff Law June 26, 2019, 10:06 p.m. UTC | #1 
On 6/26/19 12:46 AM, Martin Liška wrote:
> Hi.
> 
> The patch is about missing argument to function call and
> unused arguments in symbol-summary.h.
> 
> Patch can bootstrap on x86_64-linux-gnu and survives regression tests.
> 
> Ready to be installed?
> Thanks,
> Martin
> 
> gcc/ChangeLog:
> 
> 2019-06-25  Martin Liska  <mliska@suse.cz>
> 
> 	* symbol-summary.h (traverse): Pass
> 	argument a to the call of callback.
> 	(gt_ggc_mx): Mark arguments as unused.
> 	(gt_pch_nx): Likewise.
OK
jeff
diff mbox series

Patch

diff --git a/gcc/symbol-summary.h b/gcc/symbol-summary.h
index 0219f3a81ea..e90d4481a10 100644
--- a/gcc/symbol-summary.h
+++ b/gcc/symbol-summary.h
@@ -362,7 +362,7 @@  public:
   {
     for (unsigned i = 0; i < m_vector->length (); i++)
       if ((*m_vector[i]) != NULL)
-	f ((*m_vector)[i]);
+	f ((*m_vector)[i], a);
   }
 
   /* Getter for summary callgraph node pointer.  If a summary for a node
@@ -846,7 +846,7 @@  public:
   {
     for (unsigned i = 0; i < m_vector->length (); i++)
       if ((*m_vector[i]) != NULL)
-	f ((*m_vector)[i]);
+	f ((*m_vector)[i], a);
   }
 
   /* Getter for summary callgraph edge pointer.
@@ -966,21 +966,21 @@  fast_call_summary<T *, V>::is_ggc ()
 
 template <typename T>
 void
-gt_ggc_mx (fast_call_summary<T *, va_heap>* const &summary)
+gt_ggc_mx (fast_call_summary<T *, va_heap>* const &summary ATTRIBUTE_UNUSED)
 {
 }
 
 template <typename T>
 void
-gt_pch_nx (fast_call_summary<T *, va_heap>* const &summary)
+gt_pch_nx (fast_call_summary<T *, va_heap>* const &summary ATTRIBUTE_UNUSED)
 {
 }
 
 template <typename T>
 void
-gt_pch_nx (fast_call_summary<T *, va_heap>* const& summary,
-	   gt_pointer_operator op,
-	   void *cookie)
+gt_pch_nx (fast_call_summary<T *, va_heap>* const& summary ATTRIBUTE_UNUSED,
+	   gt_pointer_operator op ATTRIBUTE_UNUSED,
+	   void *cookie ATTRIBUTE_UNUSED)
 {
 }