| Message ID | 20190625145724.3058-2-ktraynor@redhat.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | vhost tx retry updates | expand |
On Tue, Jun 25, 2019 at 03:57:21PM +0100, Kevin Traynor wrote: > Fix minor issue of one possible additional retry. > > Fixes: c6ec9d176dbf ("netdev-dpdk: Fix vHost stats.") > Signed-off-by: Kevin Traynor <ktraynor@redhat.com> > Acked-by: Eelco Chaudron <echaudro@redhat.com> > --- Acked-by: Flavio Leitner <fbl@sysclose.org>
On 6/25/2019 3:57 PM, Kevin Traynor wrote: > Fix minor issue of one possible additional retry. > > Fixes: c6ec9d176dbf ("netdev-dpdk: Fix vHost stats.") > Signed-off-by: Kevin Traynor <ktraynor@redhat.com> > Acked-by: Eelco Chaudron <echaudro@redhat.com> > --- > lib/netdev-dpdk.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c > index 4856c56aa..0f3b9c6f4 100644 > --- a/lib/netdev-dpdk.c > +++ b/lib/netdev-dpdk.c > @@ -2353,5 +2353,5 @@ __netdev_dpdk_vhost_send(struct netdev *netdev, int qid, > break; > } > - } while (cnt && (retries++ <= VHOST_ENQ_RETRY_NUM)); > + } while (cnt && (retries++ < VHOST_ENQ_RETRY_NUM)); > > rte_spinlock_unlock(&dev->tx_q[qid].tx_lock); Looks OK to me, can be backported to 2.7 as far as I can see as well. Applied an pushed. Thanks Ian
On 6/28/2019 10:22 AM, Ian Stokes wrote: > On 6/25/2019 3:57 PM, Kevin Traynor wrote: >> Fix minor issue of one possible additional retry. >> >> Fixes: c6ec9d176dbf ("netdev-dpdk: Fix vHost stats.") >> Signed-off-by: Kevin Traynor <ktraynor@redhat.com> >> Acked-by: Eelco Chaudron <echaudro@redhat.com> >> --- >> lib/netdev-dpdk.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c >> index 4856c56aa..0f3b9c6f4 100644 >> --- a/lib/netdev-dpdk.c >> +++ b/lib/netdev-dpdk.c >> @@ -2353,5 +2353,5 @@ __netdev_dpdk_vhost_send(struct netdev *netdev, >> int qid, >> break; >> } >> - } while (cnt && (retries++ <= VHOST_ENQ_RETRY_NUM)); >> + } while (cnt && (retries++ < VHOST_ENQ_RETRY_NUM)); >> rte_spinlock_unlock(&dev->tx_q[qid].tx_lock); > > Looks OK to me, can be backported to 2.7 as far as I can see as well. > Applied an pushed. > Apologies, just spotted I've replied on the v2 thread, should be the v3. Ian
diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c index 4856c56aa..0f3b9c6f4 100644 --- a/lib/netdev-dpdk.c +++ b/lib/netdev-dpdk.c @@ -2353,5 +2353,5 @@ __netdev_dpdk_vhost_send(struct netdev *netdev, int qid, break; } - } while (cnt && (retries++ <= VHOST_ENQ_RETRY_NUM)); + } while (cnt && (retries++ < VHOST_ENQ_RETRY_NUM)); rte_spinlock_unlock(&dev->tx_q[qid].tx_lock);
Fix minor issue of one possible additional retry. Fixes: c6ec9d176dbf ("netdev-dpdk: Fix vHost stats.") Signed-off-by: Kevin Traynor <ktraynor@redhat.com> Acked-by: Eelco Chaudron <echaudro@redhat.com> --- lib/netdev-dpdk.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)