diff mbox series

package/proj: fix build failure due to gcc bug 68485

Message ID 20190625064436.23113-1-giulio.benetti@micronovasrl.com
State Accepted
Commit c99665cde7e47e6eee0aa6ced2d5fed92f716a51
Headers show
Series package/proj: fix build failure due to gcc bug 68485 | expand

Commit Message

Giulio Benetti June 25, 2019, 6:44 a.m. UTC
The proj package exhibits gcc bug 68485 when built for the Microblaze
architecture with optimization enabled, which causes a build failure.

As done for other packages in Buildroot work around this gcc bug by
setting optimization to -O0 if BR2_TOOLCHAIN_HAS_GCC_BUG_68485=y.

Fixes:

http://autobuild.buildroot.net/results/e61/e61bd55067071415223e523a81de3c2e9cafea6f/

Signed-off-by: Giulio Benetti <giulio.benetti@micronovasrl.com>
---
 package/proj/proj.mk | 8 ++++++++
 1 file changed, 8 insertions(+)

Comments

Zoltan Gyarmati June 29, 2019, 3:28 p.m. UTC | #1
On Dienstag, 25. Juni 2019 08:44:36 CEST Giulio Benetti wrote:
> The proj package exhibits gcc bug 68485 when built for the Microblaze
> architecture with optimization enabled, which causes a build failure.
> 
> As done for other packages in Buildroot work around this gcc bug by
> setting optimization to -O0 if BR2_TOOLCHAIN_HAS_GCC_BUG_68485=y.
> 
> Fixes:
> 
> http://autobuild.buildroot.net/results/e61/e61bd55067071415223e523a81de3c2e9
> cafea6f/
> 
> Signed-off-by: Giulio Benetti <giulio.benetti@micronovasrl.com>
Tested-by: Zoltan Gyarmati <zgyarmati@zgyarmati.de>
Acked-by: Zoltan Gyarmati <zgyarmati@zgyarmati.de>
> ---
>  package/proj/proj.mk | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/package/proj/proj.mk b/package/proj/proj.mk
> index 0b239b2bbe..2969eb57ac 100644
> --- a/package/proj/proj.mk
> +++ b/package/proj/proj.mk
> @@ -10,4 +10,12 @@ PROJ_LICENSE = MIT
>  PROJ_LICENSE_FILES = COPYING
>  PROJ_INSTALL_STAGING = YES
> 
> +PROJ_CFLAGS = $(TARGET_CFLAGS)
> +
> +ifeq ($(BR2_TOOLCHAIN_HAS_GCC_BUG_68485),y)
> +PROJ_CFLAGS += -O0
> +endif
> +
> +PROJ_CONF_ENV = CFLAGS="$(PROJ_CFLAGS)"
> +
>  $(eval $(autotools-package))
Peter Korsgaard Aug. 1, 2019, 1:36 p.m. UTC | #2
>>>>> "Giulio" == Giulio Benetti <giulio.benetti@micronovasrl.com> writes:

 > The proj package exhibits gcc bug 68485 when built for the Microblaze
 > architecture with optimization enabled, which causes a build failure.

 > As done for other packages in Buildroot work around this gcc bug by
 > setting optimization to -O0 if BR2_TOOLCHAIN_HAS_GCC_BUG_68485=y.

 > Fixes:

 > http://autobuild.buildroot.net/results/e61/e61bd55067071415223e523a81de3c2e9cafea6f/

 > Signed-off-by: Giulio Benetti <giulio.benetti@micronovasrl.com>

Committed, thanks.
Peter Korsgaard Aug. 20, 2019, 7:21 p.m. UTC | #3
>>>>> "Giulio" == Giulio Benetti <giulio.benetti@micronovasrl.com> writes:

 > The proj package exhibits gcc bug 68485 when built for the Microblaze
 > architecture with optimization enabled, which causes a build failure.

 > As done for other packages in Buildroot work around this gcc bug by
 > setting optimization to -O0 if BR2_TOOLCHAIN_HAS_GCC_BUG_68485=y.

 > Fixes:

 > http://autobuild.buildroot.net/results/e61/e61bd55067071415223e523a81de3c2e9cafea6f/

 > Signed-off-by: Giulio Benetti <giulio.benetti@micronovasrl.com>

Committed to 2019.02.x and 2019.05.x, thanks.
diff mbox series

Patch

diff --git a/package/proj/proj.mk b/package/proj/proj.mk
index 0b239b2bbe..2969eb57ac 100644
--- a/package/proj/proj.mk
+++ b/package/proj/proj.mk
@@ -10,4 +10,12 @@  PROJ_LICENSE = MIT
 PROJ_LICENSE_FILES = COPYING
 PROJ_INSTALL_STAGING = YES
 
+PROJ_CFLAGS = $(TARGET_CFLAGS)
+
+ifeq ($(BR2_TOOLCHAIN_HAS_GCC_BUG_68485),y)
+PROJ_CFLAGS += -O0
+endif
+
+PROJ_CONF_ENV = CFLAGS="$(PROJ_CFLAGS)"
+
 $(eval $(autotools-package))