diff mbox series

[04/32] tests: Fix ap_track_sta_no_auth false negative by using common finalizer

Message ID 20190625015109.6705-4-masashi.honma@gmail.com
State Accepted
Headers show
Series [01/32] tests: Fix nfc_wps_handover_chan14 false negative by using common finalizer | expand

Commit Message

Masashi Honma June 25, 2019, 1:50 a.m. UTC 
ap_track_sta_no_auth fails with this message.

---------------
wlan0: Country code not reset back to 00: is US
wlan0: Country code cleared back to 00
---------------

This patch fixes the issue.

Signed-off-by: Masashi Honma <masashi.honma@gmail.com>
---
 tests/hwsim/test_ap_track.py | 39 ++++++++++++++++++------------------
 1 file changed, 19 insertions(+), 20 deletions(-)
diff mbox series

Patch

diff --git a/tests/hwsim/test_ap_track.py b/tests/hwsim/test_ap_track.py
index 3dde9cc7f..eede9b285 100644
--- a/tests/hwsim/test_ap_track.py
+++ b/tests/hwsim/test_ap_track.py
@@ -125,29 +125,28 @@  def _test_ap_track_sta_no_probe_resp(dev, bssid, bssid2):
 def test_ap_track_sta_no_auth(dev, apdev):
     """Dualband AP rejecting authentication from dualband STA on 2.4 GHz"""
     try:
-        _test_ap_track_sta_no_auth(dev, apdev)
-    finally:
-        subprocess.call(['iw', 'reg', 'set', '00'])
-        time.sleep(0.1)
+        params = {"ssid": "track",
+                  "country_code": "US",
+                  "hw_mode": "g",
+                  "channel": "6",
+                  "track_sta_max_num": "100",
+                  "no_auth_if_seen_on": apdev[1]['ifname']}
+        hapd = hostapd.add_ap(apdev[0], params)
 
-def _test_ap_track_sta_no_auth(dev, apdev):
-    params = {"ssid": "track",
-              "country_code": "US",
-              "hw_mode": "g",
-              "channel": "6",
-              "track_sta_max_num": "100",
-              "no_auth_if_seen_on": apdev[1]['ifname']}
-    hapd = hostapd.add_ap(apdev[0], params)
-    bssid = apdev[0]['bssid']
+        params = {"ssid": "track",
+                  "country_code": "US",
+                  "hw_mode": "a",
+                  "channel": "40",
+                  "track_sta_max_num": "100"}
+        hapd2 = hostapd.add_ap(apdev[1], params)
 
-    params = {"ssid": "track",
-              "country_code": "US",
-              "hw_mode": "a",
-              "channel": "40",
-              "track_sta_max_num": "100"}
-    hapd2 = hostapd.add_ap(apdev[1], params)
-    bssid2 = apdev[1]['bssid']
+        _test_ap_track_sta_no_auth(dev, apdev[0]['bssid'], apdev[1]['bssid'])
+    finally:
+        disable_hapd(hapd)
+        disable_hapd(hapd2)
+        clear_regdom_dev(dev, 2)
 
+def _test_ap_track_sta_no_auth(dev, bssid, bssid2):
     dev[0].scan_for_bss(bssid, freq=2437, force_scan=True)
     dev[0].scan_for_bss(bssid2, freq=5200, force_scan=True)
     dev[1].scan_for_bss(bssid, freq=2437, force_scan=True)