| Message ID | d2773db0709a09bfe6d43a28ba1323c5d3f9a76b.1314650069.git.joe@perches.com |
|---|---|
| State | Changes Requested, archived |
| Delegated to: | David Miller |
| Headers | show |
On 29.08.2011 23:17, Joe Perches wrote: > Removing unnecessary messages saves code and text. > > Site specific OOM messages are duplications of a generic MM > out of memory message and aren't really useful, so just > delete them. > > Signed-off-by: Joe Perches <joe@perches.com> Acked-by: Oliver Hartkopp <socketcan@hartkopp.net> Tnx Joe. > --- > net/can/af_can.c | 6 ++---- > 1 files changed, 2 insertions(+), 4 deletions(-) > > diff --git a/net/can/af_can.c b/net/can/af_can.c > index b9efa94..11300be 100644 > --- a/net/can/af_can.c > +++ b/net/can/af_can.c > @@ -770,11 +770,9 @@ static int can_notifier(struct notifier_block *nb, unsigned long msg, > > /* create new dev_rcv_lists for this device */ > d = kzalloc(sizeof(*d), GFP_KERNEL); > - if (!d) { > - printk(KERN_ERR > - "can: allocation of receive list failed\n"); > + if (!d) > return NOTIFY_DONE; > - } > + > BUG_ON(dev->ml_priv); > dev->ml_priv = d; > -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/net/can/af_can.c b/net/can/af_can.c index b9efa94..11300be 100644 --- a/net/can/af_can.c +++ b/net/can/af_can.c @@ -770,11 +770,9 @@ static int can_notifier(struct notifier_block *nb, unsigned long msg, /* create new dev_rcv_lists for this device */ d = kzalloc(sizeof(*d), GFP_KERNEL); - if (!d) { - printk(KERN_ERR - "can: allocation of receive list failed\n"); + if (!d) return NOTIFY_DONE; - } + BUG_ON(dev->ml_priv); dev->ml_priv = d;
Removing unnecessary messages saves code and text. Site specific OOM messages are duplications of a generic MM out of memory message and aren't really useful, so just delete them. Signed-off-by: Joe Perches <joe@perches.com> --- net/can/af_can.c | 6 ++---- 1 files changed, 2 insertions(+), 4 deletions(-)