From patchwork Mon Aug 29 16:14:50 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter O'Gorman X-Patchwork-Id: 112108 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id F046FB6F81 for ; Tue, 30 Aug 2011 02:15:16 +1000 (EST) Received: (qmail 13341 invoked by alias); 29 Aug 2011 16:15:11 -0000 Received: (qmail 13222 invoked by uid 22791); 29 Aug 2011 16:15:05 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL, BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU X-Spam-Check-By: sourceware.org Received: from pogma.xen.prgmr.com (HELO pogma.xen.prgmr.com) (68.68.97.8) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 29 Aug 2011 16:14:52 +0000 Received: from [10.0.0.9] (wnpgmb1316w-ds01-50-57.dynamic.mtsallstream.net [206.45.50.57]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by pogma.xen.prgmr.com (Postfix) with ESMTP id 99024BF5EF; Mon, 29 Aug 2011 16:14:50 +0000 (UTC) X-DKIM: Sendmail DKIM Filter v2.8.3 pogma.xen.prgmr.com 99024BF5EF Message-ID: <4E5BBAFA.5020600@pogma.com> Date: Mon, 29 Aug 2011 11:14:50 -0500 From: Peter O'Gorman User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.17) Gecko/20110428 Fedora/3.1.10-1.fc14 Thunderbird/3.1.10 MIME-Version: 1.0 To: John David Anglin CC: gcc-patches@gcc.gnu.org, libtool-patches@gnu.org Subject: Re: [PATCH] libtool -- don't print warnings with --silent References: <20110709230331.GA3338@hiauly1.hia.nrc.ca> In-Reply-To: X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org On 07/29/2011 07:55 PM, John David Anglin wrote: > Ping? Hi Dave, ltmain.sh is a generated file, so this patch is not correct. Perhaps something like (pasted in mail, so wrapped): This turns off warnings for --silent (and turns them on again for --verbose). But I am not sure that --silent was meant to imply "no warnings", rather it turns off the verbose compile/link messages. Would a new --no-warnings option be more appropriate? Peter > > On 9-Jul-11, at 7:03 PM, John David Anglin wrote: > >> The attached patch fixes the boehm-gc testsuite on hppa2.0w-hp-hpux11.11. >> Without it, libtool always generates an informational warning when >> linking >> causing the entire boehm-gc testsuite to fail. >> >> Ok? Ralf would you please install in libtool tree if ok. >> >> 2011-07-09 John David Anglin >> >> PR boehm-gc/48494 >> * ltmain.sh (func_warning): Don't print warnings if opt_silent is true. >> >> Index: ltmain.sh >> =================================================================== >> --- ltmain.sh (revision 176045) >> +++ ltmain.sh (working copy) >> @@ -437,7 +437,9 @@ >> # Echo program name prefixed warning message to standard error. >> func_warning () >> { >> - $opt_warning && $ECHO "$progname${mode+: }$mode: warning: "${1+"$@"} >> 1>&2 >> + ${opt_silent-false} || { >> + $opt_warning && $ECHO "$progname${mode+: }$mode: warning: "${1+"$@"} >> 1>&2 >> + } >> >> # bash bug again: >> : >> >> Dave >> -- >> J. David Anglin dave.anglin@nrc-cnrc.gc.ca >> National Research Council of Canada (613) 990-0752 (FAX: 952-6602) > > diff --git a/libltdl/config/ltmain.m4sh b/libltdl/config/ltmain.m4sh index 9358ec5..bd5736c 100644 --- a/libltdl/config/ltmain.m4sh +++ b/libltdl/config/ltmain.m4sh @@ -377,9 +377,11 @@ M4SH_GETOPTS( func_append preserve_args " $opt"], [], [--silent|--quiet], [], [ func_append preserve_args " $opt" + opt_warning=false opt_verbose=false], [v], [--verbose], [], [ func_append preserve_args " $opt" + opt_warning=: opt_silent=false], [!], [--tag], [], [ func_append preserve_args " $opt $optarg"