diff mbox series

[U-Boot,3/8] net: tsec: Reverse Christmas tree notation

Message ID 20190623174818.12773-4-olteanv@gmail.com
State Superseded
Delegated to: Joe Hershberger
Headers show
Series NXP LS1021A-TSN Board | expand

Commit Message

Vladimir Oltean June 23, 2019, 5:48 p.m. UTC 
This is a cosmetic patch that reorders variable definitions in the
inverse order of their line length, where possible.

Signed-off-by: Vladimir Oltean <olteanv@gmail.com>
---
 drivers/net/tsec.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

Comments

Joe Hershberger July 12, 2019, 7:04 p.m. UTC | #1 
On Sun, Jun 23, 2019 at 12:53 PM Vladimir Oltean <olteanv@gmail.com> wrote:
>
> This is a cosmetic patch that reorders variable definitions in the
> inverse order of their line length, where possible.
>
> Signed-off-by: Vladimir Oltean <olteanv@gmail.com>

I've never heard of anyone optimizing for this before, but sure.

Acked-by: Joe Hershberger <joe.hershberger@ni.com>
Bin Meng July 13, 2019, 4:55 a.m. UTC | #2 
On Mon, Jun 24, 2019 at 1:50 AM Vladimir Oltean <olteanv@gmail.com> wrote:
>
> This is a cosmetic patch that reorders variable definitions in the
> inverse order of their line length, where possible.
>
> Signed-off-by: Vladimir Oltean <olteanv@gmail.com>
> ---
>  drivers/net/tsec.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
>

Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
diff mbox series

Patch

diff --git a/drivers/net/tsec.c b/drivers/net/tsec.c
index 576398676af7..ce19ff9228fd 100644
--- a/drivers/net/tsec.c
+++ b/drivers/net/tsec.c
@@ -259,8 +259,8 @@  static int tsec_send(struct udevice *dev, void *packet, int length)
 {
 	struct tsec_private *priv = (struct tsec_private *)dev->priv;
 	struct tsec __iomem *regs = priv->regs;
-	u16 status;
 	int result = 0;
+	u16 status;
 	int i;
 
 	/* Find an empty buffer descriptor */
@@ -708,9 +708,9 @@  static int init_phy(struct tsec_private *priv)
  */
 static int tsec_initialize(bd_t *bis, struct tsec_info_struct *tsec_info)
 {
+	struct tsec_private *priv;
 	struct eth_device *dev;
 	int i;
-	struct tsec_private *priv;
 
 	dev = (struct eth_device *)malloc(sizeof(*dev));
 
@@ -794,14 +794,14 @@  int tsec_standard_init(bd_t *bis)
 #else /* CONFIG_DM_ETH */
 int tsec_probe(struct udevice *dev)
 {
-	struct tsec_private *priv = dev_get_priv(dev);
 	struct eth_pdata *pdata = dev_get_platdata(dev);
-	struct fsl_pq_mdio_info mdio_info;
+	struct tsec_private *priv = dev_get_priv(dev);
 	struct ofnode_phandle_args phandle_args;
 	u32 tbiaddr = CONFIG_SYS_TBIPA_VALUE;
-	ofnode parent;
+	struct fsl_pq_mdio_info mdio_info;
 	const char *phy_mode;
 	fdt_addr_t reg;
+	ofnode parent;
 	int ret;
 
 	pdata->iobase = (phys_addr_t)dev_read_addr(dev);