diff mbox

[U-Boot] MX25: tx25: Fix build by making use of GPIO framework

Message ID 1314628026-903-1-git-send-email-fabio.estevam@freescale.com
State Accepted
Commit c2205f4db06ce7a104bfe77f01e780e73fd721d3
Delegated to: Stefano Babic
Headers show

Commit Message

Fabio Estevam Aug. 29, 2011, 2:27 p.m. UTC
From: Fabio Estevam <festevam@gmail.com>

Make use of GPIO framework and avoid the following build error:

tx25.c: In function 'tx25_fec_init':
tx25.c:73: error: dereferencing pointer to incomplete type
tx25.c:74: error: dereferencing pointer to incomplete type
tx25.c:75: error: dereferencing pointer to incomplete type
tx25.c:76: error: dereferencing pointer to incomplete type
tx25.c:83: error: dereferencing pointer to incomplete type
tx25.c:84: error: dereferencing pointer to incomplete type
tx25.c:114: error: dereferencing pointer to incomplete type
tx25.c:115: error: dereferencing pointer to incomplete type
tx25.c:116: error: dereferencing pointer to incomplete type
tx25.c:117: error: dereferencing pointer to incomplete type
tx25.c:124: error: dereferencing pointer to incomplete type
tx25.c:125: error: dereferencing pointer to incomplete type
tx25.c:126: error: dereferencing pointer to incomplete type

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
 board/karo/tx25/tx25.c |    1 +
 include/configs/tx25.h |    2 ++
 2 files changed, 3 insertions(+), 0 deletions(-)

Comments

Stefano Babic Aug. 29, 2011, 2:39 p.m. UTC | #1
On 08/29/2011 04:27 PM, Fabio Estevam wrote:
> From: Fabio Estevam <festevam@gmail.com>
> 
> Make use of GPIO framework and avoid the following build error:


Hi Fabio,

> tx25.c:126: error: dereferencing pointer to incomplete type
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
>  board/karo/tx25/tx25.c |    1 +
>  include/configs/tx25.h |    2 ++
>  2 files changed, 3 insertions(+), 0 deletions(-)
> 
> diff --git a/board/karo/tx25/tx25.c b/board/karo/tx25/tx25.c
> index 25b99e8..ce75468 100644
> --- a/board/karo/tx25/tx25.c
> +++ b/board/karo/tx25/tx25.c
> @@ -28,6 +28,7 @@
>  #include <asm/io.h>
>  #include <asm/arch/imx-regs.h>
>  #include <asm/arch/imx25-pinmux.h>
> +#include <asm/gpio.h>
>  

Thanks, I missed this board !

Acked-by: Stefano Babic <sbabic@denx.de>

Best regards,
Stefano Babic
Stefano Babic Aug. 30, 2011, 9:26 a.m. UTC | #2
On 08/29/2011 04:27 PM, Fabio Estevam wrote:
> From: Fabio Estevam <festevam@gmail.com>
> 
> Make use of GPIO framework and avoid the following build error:
> 

Applied to u-boot-imx, thanks.

Best regards,
Stefano Babic
diff mbox

Patch

diff --git a/board/karo/tx25/tx25.c b/board/karo/tx25/tx25.c
index 25b99e8..ce75468 100644
--- a/board/karo/tx25/tx25.c
+++ b/board/karo/tx25/tx25.c
@@ -28,6 +28,7 @@ 
 #include <asm/io.h>
 #include <asm/arch/imx-regs.h>
 #include <asm/arch/imx25-pinmux.h>
+#include <asm/gpio.h>
 
 static void mdelay(int n)
 {
diff --git a/include/configs/tx25.h b/include/configs/tx25.h
index b284daa..cb604a5 100644
--- a/include/configs/tx25.h
+++ b/include/configs/tx25.h
@@ -91,6 +91,8 @@ 
 #define CONFIG_BAUDRATE		115200	/* Default baud rate */
 #define CONFIG_SYS_BAUDRATE_TABLE	{ 9600, 19200, 38400, 57600, 115200 }
 
+#define CONFIG_MXC_GPIO
+
 /*
  * Flash & Environment
  */