[v2,1/2] pinctrl: tegra: Set specific GPIO compatible string
diff mbox series

Message ID 20190621151932.20662-1-thierry.reding@gmail.com
State New
Headers show
Series
  • [v2,1/2] pinctrl: tegra: Set specific GPIO compatible string
Related show

Commit Message

Thierry Reding June 21, 2019, 3:19 p.m. UTC
From: Thierry Reding <treding@nvidia.com>

Rather than reuse the nvidia,tegra30-gpio compatible string to find the
GPIO controller on Tegra30, Tegra114, Tegra124 and Tegra210, use the
most specific compatible string for each SoC generation for consistency.

Signed-off-by: Thierry Reding <treding@nvidia.com>
---
 drivers/pinctrl/tegra/pinctrl-tegra114.c | 2 +-
 drivers/pinctrl/tegra/pinctrl-tegra124.c | 2 +-
 drivers/pinctrl/tegra/pinctrl-tegra210.c | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

Comments

Dmitry Osipenko June 24, 2019, 1:20 a.m. UTC | #1
21.06.2019 18:19, Thierry Reding пишет:
> From: Thierry Reding <treding@nvidia.com>
> 
> Rather than reuse the nvidia,tegra30-gpio compatible string to find the
> GPIO controller on Tegra30, Tegra114, Tegra124 and Tegra210, use the
> most specific compatible string for each SoC generation for consistency.
> 
> Signed-off-by: Thierry Reding <treding@nvidia.com>
> ---
>  drivers/pinctrl/tegra/pinctrl-tegra114.c | 2 +-
>  drivers/pinctrl/tegra/pinctrl-tegra124.c | 2 +-
>  drivers/pinctrl/tegra/pinctrl-tegra210.c | 2 +-
>  3 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/pinctrl/tegra/pinctrl-tegra114.c b/drivers/pinctrl/tegra/pinctrl-tegra114.c
> index 762151f17a88..29821c03b471 100644
> --- a/drivers/pinctrl/tegra/pinctrl-tegra114.c
> +++ b/drivers/pinctrl/tegra/pinctrl-tegra114.c
> @@ -1831,7 +1831,7 @@ static const struct tegra_pingroup tegra114_groups[] = {
>  
>  static const struct tegra_pinctrl_soc_data tegra114_pinctrl = {
>  	.ngpios = NUM_GPIOS,
> -	.gpio_compatible = "nvidia,tegra30-gpio",
> +	.gpio_compatible = "nvidia,tegra114-gpio",
>  	.pins = tegra114_pins,
>  	.npins = ARRAY_SIZE(tegra114_pins),
>  	.functions = tegra114_functions,
> diff --git a/drivers/pinctrl/tegra/pinctrl-tegra124.c b/drivers/pinctrl/tegra/pinctrl-tegra124.c
> index 930c43758c92..3616d8b97c32 100644
> --- a/drivers/pinctrl/tegra/pinctrl-tegra124.c
> +++ b/drivers/pinctrl/tegra/pinctrl-tegra124.c
> @@ -2043,7 +2043,7 @@ static const struct tegra_pingroup tegra124_groups[] = {
>  
>  static const struct tegra_pinctrl_soc_data tegra124_pinctrl = {
>  	.ngpios = NUM_GPIOS,
> -	.gpio_compatible = "nvidia,tegra30-gpio",
> +	.gpio_compatible = "nvidia,tegra124-gpio",
>  	.pins = tegra124_pins,
>  	.npins = ARRAY_SIZE(tegra124_pins),
>  	.functions = tegra124_functions,
> diff --git a/drivers/pinctrl/tegra/pinctrl-tegra210.c b/drivers/pinctrl/tegra/pinctrl-tegra210.c
> index 0b56ad5c9c1c..1462023bba35 100644
> --- a/drivers/pinctrl/tegra/pinctrl-tegra210.c
> +++ b/drivers/pinctrl/tegra/pinctrl-tegra210.c
> @@ -1545,7 +1545,7 @@ static const struct tegra_pingroup tegra210_groups[] = {
>  
>  static const struct tegra_pinctrl_soc_data tegra210_pinctrl = {
>  	.ngpios = NUM_GPIOS,
> -	.gpio_compatible = "nvidia,tegra30-gpio",
> +	.gpio_compatible = "nvidia,tegra210-gpio",
>  	.pins = tegra210_pins,
>  	.npins = ARRAY_SIZE(tegra210_pins),
>  	.functions = tegra210_functions,
> 

Reviewed-by: Dmitry Osipenko <digetx@gmail.com>
Linus Walleij June 25, 2019, 1:35 p.m. UTC | #2
On Fri, Jun 21, 2019 at 5:19 PM Thierry Reding <thierry.reding@gmail.com> wrote:

> From: Thierry Reding <treding@nvidia.com>
>
> Rather than reuse the nvidia,tegra30-gpio compatible string to find the
> GPIO controller on Tegra30, Tegra114, Tegra124 and Tegra210, use the
> most specific compatible string for each SoC generation for consistency.
>
> Signed-off-by: Thierry Reding <treding@nvidia.com>

Patch applied with Dmitry's ACK.

Yours,
Linus Walleij

Patch
diff mbox series

diff --git a/drivers/pinctrl/tegra/pinctrl-tegra114.c b/drivers/pinctrl/tegra/pinctrl-tegra114.c
index 762151f17a88..29821c03b471 100644
--- a/drivers/pinctrl/tegra/pinctrl-tegra114.c
+++ b/drivers/pinctrl/tegra/pinctrl-tegra114.c
@@ -1831,7 +1831,7 @@  static const struct tegra_pingroup tegra114_groups[] = {
 
 static const struct tegra_pinctrl_soc_data tegra114_pinctrl = {
 	.ngpios = NUM_GPIOS,
-	.gpio_compatible = "nvidia,tegra30-gpio",
+	.gpio_compatible = "nvidia,tegra114-gpio",
 	.pins = tegra114_pins,
 	.npins = ARRAY_SIZE(tegra114_pins),
 	.functions = tegra114_functions,
diff --git a/drivers/pinctrl/tegra/pinctrl-tegra124.c b/drivers/pinctrl/tegra/pinctrl-tegra124.c
index 930c43758c92..3616d8b97c32 100644
--- a/drivers/pinctrl/tegra/pinctrl-tegra124.c
+++ b/drivers/pinctrl/tegra/pinctrl-tegra124.c
@@ -2043,7 +2043,7 @@  static const struct tegra_pingroup tegra124_groups[] = {
 
 static const struct tegra_pinctrl_soc_data tegra124_pinctrl = {
 	.ngpios = NUM_GPIOS,
-	.gpio_compatible = "nvidia,tegra30-gpio",
+	.gpio_compatible = "nvidia,tegra124-gpio",
 	.pins = tegra124_pins,
 	.npins = ARRAY_SIZE(tegra124_pins),
 	.functions = tegra124_functions,
diff --git a/drivers/pinctrl/tegra/pinctrl-tegra210.c b/drivers/pinctrl/tegra/pinctrl-tegra210.c
index 0b56ad5c9c1c..1462023bba35 100644
--- a/drivers/pinctrl/tegra/pinctrl-tegra210.c
+++ b/drivers/pinctrl/tegra/pinctrl-tegra210.c
@@ -1545,7 +1545,7 @@  static const struct tegra_pingroup tegra210_groups[] = {
 
 static const struct tegra_pinctrl_soc_data tegra210_pinctrl = {
 	.ngpios = NUM_GPIOS,
-	.gpio_compatible = "nvidia,tegra30-gpio",
+	.gpio_compatible = "nvidia,tegra210-gpio",
 	.pins = tegra210_pins,
 	.npins = ARRAY_SIZE(tegra210_pins),
 	.functions = tegra210_functions,