[GIT,PULL] Renesas ARM Based SoC Updates for v5.3
mbox series

Message ID cover.1561105093.git.horms+renesas@verge.net.au
State New
Headers show
Series
  • [GIT,PULL] Renesas ARM Based SoC Updates for v5.3
Related show

Pull-request

https://git.kernel.org/pub/scm/linux/kernel/git/horms/renesas.git tags/renesas-arm-soc-for-v5.3

Message

Simon Horman June 21, 2019, 9:12 a.m. UTC
Hi Olof, Hi Kevin, Hi Arnd,

Please consider these Renesas ARM based SoC updates for v5.3.


The following changes since commit a188339ca5a396acc588e5851ed7e19f66b0ebd9:

  Linux 5.2-rc1 (2019-05-19 15:47:09 -0700)

are available in the git repository at:

  https://git.kernel.org/pub/scm/linux/kernel/git/horms/renesas.git tags/renesas-arm-soc-for-v5.3

for you to fetch changes up to 02af9f90941b6cce5fb672ee058c142adcc11a2f:

  soc: renesas: Enable RZ/A1 IRQC on RZ/A1H and RZ/A2M (2019-06-06 10:37:06 +0200)

----------------------------------------------------------------
Renesas ARM Based SoC Updates for v5.3

* Auto-enable RZ/A1 IRQC on RZ/A1H and RZ/A2M
* Don't init CNTVOFF/counter if PSCI is available

----------------------------------------------------------------
Geert Uytterhoeven (1):
      soc: renesas: Enable RZ/A1 IRQC on RZ/A1H and RZ/A2M

Oleksandr Tyshchenko (1):
      ARM: mach-shmobile: Don't init CNTVOFF/counter if PSCI is available

 arch/arm/mach-shmobile/setup-rcar-gen2.c | 17 +++++++++++++++++
 drivers/soc/renesas/Kconfig              |  4 +++-
 2 files changed, 20 insertions(+), 1 deletion(-)

Comments

Olof Johansson June 25, 2019, 12:49 p.m. UTC | #1
On Fri, Jun 21, 2019 at 11:12:04AM +0200, Simon Horman wrote:
> Hi Olof, Hi Kevin, Hi Arnd,
> 
> Please consider these Renesas ARM based SoC updates for v5.3.
> 
> 
> The following changes since commit a188339ca5a396acc588e5851ed7e19f66b0ebd9:
> 
>   Linux 5.2-rc1 (2019-05-19 15:47:09 -0700)
> 
> are available in the git repository at:
> 
>   https://git.kernel.org/pub/scm/linux/kernel/git/horms/renesas.git tags/renesas-arm-soc-for-v5.3
> 
> for you to fetch changes up to 02af9f90941b6cce5fb672ee058c142adcc11a2f:
> 
>   soc: renesas: Enable RZ/A1 IRQC on RZ/A1H and RZ/A2M (2019-06-06 10:37:06 +0200)
> 
> ----------------------------------------------------------------
> Renesas ARM Based SoC Updates for v5.3
> 
> * Auto-enable RZ/A1 IRQC on RZ/A1H and RZ/A2M
> * Don't init CNTVOFF/counter if PSCI is available
> 
> ----------------------------------------------------------------
> Geert Uytterhoeven (1):
>       soc: renesas: Enable RZ/A1 IRQC on RZ/A1H and RZ/A2M
> 
> Oleksandr Tyshchenko (1):
>       ARM: mach-shmobile: Don't init CNTVOFF/counter if PSCI is available

Merged, thanks.

Note that in this patch, code like this:

+#ifdef CONFIG_ARM_PSCI_FW
+       if (psci_ops.cpu_on)
+               need_update = false;
+#endif
+
+       if (need_update == false)
+               goto skip_update;


Can either be replaced with a goto under the ifdef, or at the very least, no
need to do a 'need_update == false' -- 'if (need_update)' is sufficient.


-Olof
Geert Uytterhoeven June 25, 2019, 1:23 p.m. UTC | #2
Hi Olof,

On Tue, Jun 25, 2019 at 3:10 PM Olof Johansson <olof@lixom.net> wrote:
> On Fri, Jun 21, 2019 at 11:12:04AM +0200, Simon Horman wrote:
> > Oleksandr Tyshchenko (1):
> >       ARM: mach-shmobile: Don't init CNTVOFF/counter if PSCI is available
>
> Merged, thanks.

Thanks!

> Note that in this patch, code like this:
>
> +#ifdef CONFIG_ARM_PSCI_FW
> +       if (psci_ops.cpu_on)
> +               need_update = false;
> +#endif
> +
> +       if (need_update == false)
> +               goto skip_update;
>
>
> Can either be replaced with a goto under the ifdef, or at the very least, no

I believe a goto under the ifdef may cause a "label defined but not used"
warning if CONFIG_ARM_PSCI_FW is not defined.

> need to do a 'need_update == false' -- 'if (need_update)' is sufficient.

Yeah, "if (!need_update)" would work too.

Gr{oetje,eeting}s,

                        Geert
Olof Johansson June 27, 2019, 1:35 a.m. UTC | #3
On Tue, Jun 25, 2019 at 9:23 PM Geert Uytterhoeven <geert@linux-m68k.org> wrote:
>
> Hi Olof,
>
> On Tue, Jun 25, 2019 at 3:10 PM Olof Johansson <olof@lixom.net> wrote:
> > On Fri, Jun 21, 2019 at 11:12:04AM +0200, Simon Horman wrote:
> > > Oleksandr Tyshchenko (1):
> > >       ARM: mach-shmobile: Don't init CNTVOFF/counter if PSCI is available
> >
> > Merged, thanks.
>
> Thanks!
>
> > Note that in this patch, code like this:
> >
> > +#ifdef CONFIG_ARM_PSCI_FW
> > +       if (psci_ops.cpu_on)
> > +               need_update = false;
> > +#endif
> > +
> > +       if (need_update == false)
> > +               goto skip_update;
> >
> >
> > Can either be replaced with a goto under the ifdef, or at the very least, no
>
> I believe a goto under the ifdef may cause a "label defined but not used"
> warning if CONFIG_ARM_PSCI_FW is not defined.

Ah yeah, good point.


-Olof