jbd2: drop declaration of journal_sync_buffer()
diff mbox series

Message ID 20190620213228.8191-1-tytso@mit.edu
State Awaiting Upstream
Headers show
Series
  • jbd2: drop declaration of journal_sync_buffer()
Related show

Commit Message

Theodore Y. Ts'o June 20, 2019, 9:32 p.m. UTC
The journal_sync_buffer() function was never carried over from jbd to
jbd2.  So get rid of the vestigal declaration of this (non-existent)
function.

Signed-off-by: Theodore Ts'o <tytso@mit.edu>
---
 fs/jbd2/journal.c    | 3 ---
 include/linux/jbd2.h | 1 -
 2 files changed, 4 deletions(-)

Comments

Darrick J. Wong June 20, 2019, 9:34 p.m. UTC | #1
On Thu, Jun 20, 2019 at 05:32:28PM -0400, Theodore Ts'o wrote:
> The journal_sync_buffer() function was never carried over from jbd to
> jbd2.  So get rid of the vestigal declaration of this (non-existent)
> function.
> 
> Signed-off-by: Theodore Ts'o <tytso@mit.edu>

Looks ok,
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>

--D

> ---
>  fs/jbd2/journal.c    | 3 ---
>  include/linux/jbd2.h | 1 -
>  2 files changed, 4 deletions(-)
> 
> diff --git a/fs/jbd2/journal.c b/fs/jbd2/journal.c
> index 17f679aeba7c..953990eb70a9 100644
> --- a/fs/jbd2/journal.c
> +++ b/fs/jbd2/journal.c
> @@ -66,9 +66,6 @@ EXPORT_SYMBOL(jbd2_journal_get_undo_access);
>  EXPORT_SYMBOL(jbd2_journal_set_triggers);
>  EXPORT_SYMBOL(jbd2_journal_dirty_metadata);
>  EXPORT_SYMBOL(jbd2_journal_forget);
> -#if 0
> -EXPORT_SYMBOL(journal_sync_buffer);
> -#endif
>  EXPORT_SYMBOL(jbd2_journal_flush);
>  EXPORT_SYMBOL(jbd2_journal_revoke);
>  
> diff --git a/include/linux/jbd2.h b/include/linux/jbd2.h
> index 0e0393e7f41a..df03825ad1a1 100644
> --- a/include/linux/jbd2.h
> +++ b/include/linux/jbd2.h
> @@ -1373,7 +1373,6 @@ void		 jbd2_journal_set_triggers(struct buffer_head *,
>  					   struct jbd2_buffer_trigger_type *type);
>  extern int	 jbd2_journal_dirty_metadata (handle_t *, struct buffer_head *);
>  extern int	 jbd2_journal_forget (handle_t *, struct buffer_head *);
> -extern void	 journal_sync_buffer (struct buffer_head *);
>  extern int	 jbd2_journal_invalidatepage(journal_t *,
>  				struct page *, unsigned int, unsigned int);
>  extern int	 jbd2_journal_try_to_free_buffers(journal_t *, struct page *, gfp_t);
> -- 
> 2.22.0
>

Patch
diff mbox series

diff --git a/fs/jbd2/journal.c b/fs/jbd2/journal.c
index 17f679aeba7c..953990eb70a9 100644
--- a/fs/jbd2/journal.c
+++ b/fs/jbd2/journal.c
@@ -66,9 +66,6 @@  EXPORT_SYMBOL(jbd2_journal_get_undo_access);
 EXPORT_SYMBOL(jbd2_journal_set_triggers);
 EXPORT_SYMBOL(jbd2_journal_dirty_metadata);
 EXPORT_SYMBOL(jbd2_journal_forget);
-#if 0
-EXPORT_SYMBOL(journal_sync_buffer);
-#endif
 EXPORT_SYMBOL(jbd2_journal_flush);
 EXPORT_SYMBOL(jbd2_journal_revoke);
 
diff --git a/include/linux/jbd2.h b/include/linux/jbd2.h
index 0e0393e7f41a..df03825ad1a1 100644
--- a/include/linux/jbd2.h
+++ b/include/linux/jbd2.h
@@ -1373,7 +1373,6 @@  void		 jbd2_journal_set_triggers(struct buffer_head *,
 					   struct jbd2_buffer_trigger_type *type);
 extern int	 jbd2_journal_dirty_metadata (handle_t *, struct buffer_head *);
 extern int	 jbd2_journal_forget (handle_t *, struct buffer_head *);
-extern void	 journal_sync_buffer (struct buffer_head *);
 extern int	 jbd2_journal_invalidatepage(journal_t *,
 				struct page *, unsigned int, unsigned int);
 extern int	 jbd2_journal_try_to_free_buffers(journal_t *, struct page *, gfp_t);