| Message ID | 1561037428-13855-2-git-send-email-robert.chiras@nxp.com |
|---|---|
| State | Superseded, archived |
| Headers | show |
| Series | Add DSI panel driver for Raydium RM67191 | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success |
Hi Robert, On Thu, Jun 20, 2019 at 10:32 AM Robert Chiras <robert.chiras@nxp.com> wrote: > > Add dt-bindings documentation for Raydium RM67191 DSI panel. > > Signed-off-by: Robert Chiras <robert.chiras@nxp.com> > Reviewed-by: Sam Ravnborg <sam@ravnborg.org> > --- > .../bindings/display/panel/raydium,rm67191.txt | 39 ++++++++++++++++++++++ > 1 file changed, 39 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/panel/raydium,rm67191.txt > > diff --git a/Documentation/devicetree/bindings/display/panel/raydium,rm67191.txt b/Documentation/devicetree/bindings/display/panel/raydium,rm67191.txt > new file mode 100644 > index 0000000..52af272 > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/panel/raydium,rm67191.txt > @@ -0,0 +1,39 @@ > +Raydium RM67171 OLED LCD panel with MIPI-DSI protocol > + > +Required properties: > +- compatible: "raydium,rm67191" > +- reg: virtual channel for MIPI-DSI protocol > + must be <0> > +- dsi-lanes: number of DSI lanes to be used > + must be <3> or <4> > +- port: input port node with endpoint definition as > + defined in Documentation/devicetree/bindings/graph.txt; > + the input port should be connected to a MIPI-DSI device > + driver > + > +Optional properties: > +- reset-gpios: a GPIO spec for the RST_B GPIO pin > +- width-mm: see panel-common.txt > +- height-mm: see panel-common.txt > +- video-mode: 0 - burst-mode > + 1 - non-burst with sync event > + 2 - non-burst with sync po ulse No power-supply property?
Hi Fabio, On Vi, 2019-06-21 at 11:00 -0300, Fabio Estevam wrote: > Hi Robert, > > On Thu, Jun 20, 2019 at 10:32 AM Robert Chiras <robert.chiras@nxp.com > > wrote: > > > > > > Add dt-bindings documentation for Raydium RM67191 DSI panel. > > > > Signed-off-by: Robert Chiras <robert.chiras@nxp.com> > > Reviewed-by: Sam Ravnborg <sam@ravnborg.org> > > --- > > .../bindings/display/panel/raydium,rm67191.txt | 39 > > ++++++++++++++++++++++ > > 1 file changed, 39 insertions(+) > > create mode 100644 > > Documentation/devicetree/bindings/display/panel/raydium,rm67191.txt > > > > diff --git > > a/Documentation/devicetree/bindings/display/panel/raydium,rm67191.t > > xt > > b/Documentation/devicetree/bindings/display/panel/raydium,rm67191.t > > xt > > new file mode 100644 > > index 0000000..52af272 > > --- /dev/null > > +++ > > b/Documentation/devicetree/bindings/display/panel/raydium,rm67191.t > > xt > > @@ -0,0 +1,39 @@ > > +Raydium RM67171 OLED LCD panel with MIPI-DSI protocol > > + > > +Required properties: > > +- compatible: "raydium,rm67191" > > +- reg: virtual channel for MIPI-DSI protocol > > + must be <0> > > +- dsi-lanes: number of DSI lanes to be used > > + must be <3> or <4> > > +- port: input port node with endpoint definition as > > + defined in > > Documentation/devicetree/bindings/graph.txt; > > + the input port should be connected to a > > MIPI-DSI device > > + driver > > + > > +Optional properties: > > +- reset-gpios: a GPIO spec for the RST_B GPIO pin > > +- width-mm: see panel-common.txt > > +- height-mm: see panel-common.txt > > +- video-mode: 0 - burst-mode > > + 1 - non-burst with sync event > > + 2 - non-burst with sync po ulse > No power-supply property? From what I've seen in the schematics, the power lines on the DSI port on all the i.MX8 cores are coming from a PMIC providing power for all the peripherals. Since I didn't find a way to cut the power on a single peripheral (like DSI, for example) it doesn't make sense for power- supply property. For now, at least.
Hi Robert, On Fri, Jun 21, 2019 at 11:16 AM Robert Chiras <robert.chiras@nxp.com> wrote: > From what I've seen in the schematics, the power lines on the DSI port > on all the i.MX8 cores are coming from a PMIC providing power for all > the peripherals. Since I didn't find a way to cut the power on a single > peripheral (like DSI, for example) it doesn't make sense for power- > supply property. For now, at least. This panel driver is not supposed to only work with i.MX8 NXP reference boards. The dt-bindings should be as accurate as possible from day one, so describing the power-supply is important. Please look at the panel datasheet and describe the required power supplies accordingly. Thanks
On Vi, 2019-06-21 at 12:46 -0300, Fabio Estevam wrote: > Caution: EXT Email > > Hi Robert, > > On Fri, Jun 21, 2019 at 11:16 AM Robert Chiras <robert.chiras@nxp.com > > wrote: > > > > > From what I've seen in the schematics, the power lines on the DSI > > port > > on all the i.MX8 cores are coming from a PMIC providing power for > > all > > the peripherals. Since I didn't find a way to cut the power on a > > single > > peripheral (like DSI, for example) it doesn't make sense for power- > > supply property. For now, at least. > This panel driver is not supposed to only work with i.MX8 NXP > reference boards. > > The dt-bindings should be as accurate as possible from day one, so > describing the power-supply is important. > > Please look at the panel datasheet and describe the required power > supplies accordingly. OK, I will add the power regulators as they are described in panel datasheet. I just won't be able to test them. > > Thanks
diff --git a/Documentation/devicetree/bindings/display/panel/raydium,rm67191.txt b/Documentation/devicetree/bindings/display/panel/raydium,rm67191.txt new file mode 100644 index 0000000..52af272 --- /dev/null +++ b/Documentation/devicetree/bindings/display/panel/raydium,rm67191.txt @@ -0,0 +1,39 @@ +Raydium RM67171 OLED LCD panel with MIPI-DSI protocol + +Required properties: +- compatible: "raydium,rm67191" +- reg: virtual channel for MIPI-DSI protocol + must be <0> +- dsi-lanes: number of DSI lanes to be used + must be <3> or <4> +- port: input port node with endpoint definition as + defined in Documentation/devicetree/bindings/graph.txt; + the input port should be connected to a MIPI-DSI device + driver + +Optional properties: +- reset-gpios: a GPIO spec for the RST_B GPIO pin +- width-mm: see panel-common.txt +- height-mm: see panel-common.txt +- video-mode: 0 - burst-mode + 1 - non-burst with sync event + 2 - non-burst with sync pulse + +Example: + + panel@0 { + compatible = "raydium,rm67191"; + reg = <0>; + pinctrl-0 = <&pinctrl_mipi_dsi_0_1_en>; + pinctrl-names = "default"; + reset-gpios = <&gpio1 7 GPIO_ACTIVE_LOW>; + dsi-lanes = <4>; + width-mm = <68>; + height-mm = <121>; + + port { + panel_in: endpoint { + remote-endpoint = <&mipi_out>; + }; + }; + };