csky_gx6605s_defconfig add "BR2_TOOLCHAIN_EXTERNAL=y"
diff mbox series

Message ID tencent_2664A2093675DB6268415CDB@qq.com
State Superseded
Headers show
Series
  • csky_gx6605s_defconfig add "BR2_TOOLCHAIN_EXTERNAL=y"
Related show

Commit Message

=?gb18030?B?hKK80rWT?= June 20, 2019, 9:56 a.m. UTC
hi:
           buildroot source: git clone git://git.buildroot.net/buildroot
          

all BR2_TOOLCHAIN_EXTERNAL_* items depend on BR2_TOOLCHAIN_EXTERNAL=y

Comments

Arnout Vandecappelle Aug. 2, 2019, 9:26 p.m. UTC | #1
Hi Liu,

 Thank you for this patch.

On 20/06/2019 11:56, 劉家祿 wrote:
> hi:
>            buildroot source: git clone git://git.buildroot.net/buildroot
>          
> all BR2_TOOLCHAIN_EXTERNAL_* items depend on BR2_TOOLCHAIN_EXTERNAL=y


> 
> diff --git a/configs/csky_gx6605s_defconfig b/configs/csky_gx6605s_defconfig
> index d0a2aad..22e9e0c 100644
> --- a/configs/csky_gx6605s_defconfig
> +++ b/configs/csky_gx6605s_defconfig
> @@ -1,5 +1,6 @@
>  BR2_csky=y
>  BR2_GLOBAL_PATCH_DIR="board/csky/gx6605s/patches"
> +BR2_TOOLCHAIN_EXTERNAL=y
>  BR2_TOOLCHAIN_EXTERNAL_DOWNLOAD=y
>  BR2_TOOLCHAIN_EXTERNAL_URL="https://github.com/c-sky/tools/raw/master/csky-linux-tools-x86_64-glibc-linux-4.9.56-20180128.tar.gz"
>  BR2_TOOLCHAIN_EXTERNAL_CUSTOM_PREFIX="csky-linux"
> 
> 
> 
> 
> _______________________________________________
> buildroot mailing list
> buildroot@busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
>
Arnout Vandecappelle Aug. 2, 2019, 9:37 p.m. UTC | #2
Sorry, I accidentally pressed send.

On 02/08/2019 23:26, Arnout Vandecappelle wrote:
>  Hi Liu,
> 
>  Thank you for this patch.
> 
> On 20/06/2019 11:56, 劉家祿 wrote:
>> hi:
>>            buildroot source: git clone git://git.buildroot.net/buildroot
>>          
>> all BR2_TOOLCHAIN_EXTERNAL_* items depend on BR2_TOOLCHAIN_EXTERNAL=y

 You need to add a Signed-off-by line for yourself.  This is a short way for you
to assert that you are entitled to contribute the patch under buildroot's
GPL license.  See  http://elinux.org/Developer_Certificate_Of_Origin
for more details.

>> diff --git a/configs/csky_gx6605s_defconfig b/configs/csky_gx6605s_defconfig
>> index d0a2aad..22e9e0c 100644
>> --- a/configs/csky_gx6605s_defconfig
>> +++ b/configs/csky_gx6605s_defconfig
>> @@ -1,5 +1,6 @@
>>  BR2_csky=y
>>  BR2_GLOBAL_PATCH_DIR="board/csky/gx6605s/patches"
>> +BR2_TOOLCHAIN_EXTERNAL=y

 This is unfortunately not enough to fix the issue, since the external toolchain
can no longer be selected due to the conditions. Thomas is sending a patch to
fix that.

 In addition, Guo has sent a patch that moves this defconfig to an internal
defconfig (like we do for all our other defconfigs) instead of an external one.

 Therefore, I've marked this patch as Superseded in patchwork.


 Regards,
 Arnout

>>  BR2_TOOLCHAIN_EXTERNAL_DOWNLOAD=y
>>  BR2_TOOLCHAIN_EXTERNAL_URL="https://github.com/c-sky/tools/raw/master/csky-linux-tools-x86_64-glibc-linux-4.9.56-20180128.tar.gz"
>>  BR2_TOOLCHAIN_EXTERNAL_CUSTOM_PREFIX="csky-linux"

Patch
diff mbox series

diff --git a/configs/csky_gx6605s_defconfig b/configs/csky_gx6605s_defconfig
index d0a2aad..22e9e0c 100644
--- a/configs/csky_gx6605s_defconfig
+++ b/configs/csky_gx6605s_defconfig
@@ -1,5 +1,6 @@ 
 BR2_csky=y
 BR2_GLOBAL_PATCH_DIR="board/csky/gx6605s/patches"
+BR2_TOOLCHAIN_EXTERNAL=y
 BR2_TOOLCHAIN_EXTERNAL_DOWNLOAD=y
 BR2_TOOLCHAIN_EXTERNAL_URL="https://github.com/c-sky/tools/raw/master/csky-linux-tools-x86_64-glibc-linux-4.9.56-20180128.tar.gz"
 BR2_TOOLCHAIN_EXTERNAL_CUSTOM_PREFIX="csky-linux"