| Message ID | 1314537977-20097-1-git-send-email-Gregory.Dietsche@cuw.edu |
|---|---|
| State | Not Applicable, archived |
| Delegated to: | David Miller |
| Headers | show |
On Sun, Aug 28, 2011 at 08:26:16AM -0500, Greg Dietsche wrote: > This message should be a debug message and not a warning. So > change it from IWL_WARN to IWL_DEBUG_HT. I'm currently doing massive iwlegacy driver cleanup. Would be easier for me to apply these patches on top of my changes instead of rebase my patches. I will queue these two patches and post them together with my pending patches. Thanks Stanislaw -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Stanislaw, On 08/29/2011 07:20 AM, Stanislaw Gruszka wrote: > On Sun, Aug 28, 2011 at 08:26:16AM -0500, Greg Dietsche wrote: > >> This message should be a debug message and not a warning. So >> change it from IWL_WARN to IWL_DEBUG_HT. >> > I'm currently doing massive iwlegacy driver cleanup. Would be easier > for me to apply these patches on top of my changes instead of rebase > my patches. I will queue these two patches and post them together with > my pending patches. > > That sounds good to me. I have the 4065 card in my laptop and want to learn how it works. If you want someone to test your changes, I'm willing. I have six other patches that are trivial in nature for the iwlegacy driver. One of those also applies to the iwlagn driver, so seven patches in total. They remove some null checks that aren't necessary and also cleanup a few unused variables. There are two patches in the set that I'm not 100% sure about. They remove null checks and I haven't been able to prove to myself that they are correct. However, if they aren't correct, then there are some null checks in other places that need to be added.... Anyway, I can hold off on these until you've done your cleanup and see what still applies, or if you have a tree someplace, I'd be happy to rebase them for you. I've been running them on my laptop for a few days now with no problems. Thanks, Greg -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Greg On Mon, Aug 29, 2011 at 08:33:39AM -0500, Greg Dietsche wrote: > On 08/29/2011 07:20 AM, Stanislaw Gruszka wrote: > >On Sun, Aug 28, 2011 at 08:26:16AM -0500, Greg Dietsche wrote: > >>This message should be a debug message and not a warning. So > >>change it from IWL_WARN to IWL_DEBUG_HT. > >I'm currently doing massive iwlegacy driver cleanup. Would be easier > >for me to apply these patches on top of my changes instead of rebase > >my patches. I will queue these two patches and post them together with > >my pending patches. > > > That sounds good to me. I have the 4065 card in my laptop and want > to learn how it works. If you want someone to test your changes, I'm > willing. > > I have six other patches that are trivial in nature for the iwlegacy > driver. One of those also applies to the iwlagn driver, so seven > patches in total. They remove some null checks that aren't necessary > and also cleanup a few unused variables. There are two patches in > the set that I'm not 100% sure about. They remove null checks and I > haven't been able to prove to myself that they are correct. However, > if they aren't correct, then there are some null checks in other > places that need to be added.... > > Anyway, I can hold off on these until you've done your cleanup and > see what still applies, That would be great. > or if you have a tree someplace, I'd be > happy to rebase them for you. I do not have publicly available tree. I'll probably try to get one on git.kernel.org. I will let you know. Thanks, Stanislaw -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hello On Mon, Aug 29, 2011 at 04:00:33PM +0200, Stanislaw Gruszka wrote: > On Mon, Aug 29, 2011 at 08:33:39AM -0500, Greg Dietsche wrote: > > On 08/29/2011 07:20 AM, Stanislaw Gruszka wrote: > > >On Sun, Aug 28, 2011 at 08:26:16AM -0500, Greg Dietsche wrote: > > >>This message should be a debug message and not a warning. So > > >>change it from IWL_WARN to IWL_DEBUG_HT. > > >I'm currently doing massive iwlegacy driver cleanup. Would be easier > > >for me to apply these patches on top of my changes instead of rebase > > >my patches. I will queue these two patches and post them together with > > >my pending patches. > > > > > That sounds good to me. I have the 4065 card in my laptop and want > > to learn how it works. If you want someone to test your changes, I'm > > willing. > > > > I have six other patches that are trivial in nature for the iwlegacy > > driver. One of those also applies to the iwlagn driver, so seven > > patches in total. They remove some null checks that aren't necessary > > and also cleanup a few unused variables. There are two patches in > > the set that I'm not 100% sure about. They remove null checks and I > > haven't been able to prove to myself that they are correct. However, > > if they aren't correct, then there are some null checks in other > > places that need to be added.... > > > > Anyway, I can hold off on these until you've done your cleanup and > > see what still applies, > > That would be great. > > > or if you have a tree someplace, I'd be > > happy to rebase them for you. > > I do not have publicly available tree. I'll probably try to get > one on git.kernel.org. I will let you know. I requested for kernel.org account but admins there have much more troubles currently than adding new account :-/ I put patches here: http://people.redhat.com/sgruszka/iwlegacy_cleanup.tar.bz2 They are on top of wireless-testing tree. You can apply them by something like that: cd wireless-testing for i in `ls -X ~/iwlegacy_cleanup/*.patch` ; do git am $i ; done Series include your 2 patches. You can test this cleanup and apply your new changes on top. I'll not do any further cleanup for some time now, perhaps continue when I got public git tree. Thanks Stanislaw -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Stanislaw, On 09/06/2011 10:01 AM, Stanislaw Gruszka wrote: > I put patches here: > http://people.redhat.com/sgruszka/iwlegacy_cleanup.tar.bz2 > > They are on top of wireless-testing tree. > <snip> > Series include your 2 patches. You can test this cleanup and > apply your new changes on top. I'll not do any further cleanup > for some time now, perhaps continue when I got public git tree. > > Thanks! I've re-worked my patches and you can find them here: http://www.gregd.org/stuff/linux/iwlegacy_cleanup_greg.tar.bz2 I also decided to play with github a little bit: git://github.com/dietsche/linux.git and pushed two branches: 1) wireless-next-iwlegacy-stanislaw - your patch set 2) wireless-next-iwlegacy-stanislaw-greg - a branch that has my additional patches. `git format-patch wireless-next-iwlegacy-stanislaw..wireless-next-iwlegacy-stanislaw-greg` will generate the patches that are in the link i posted above. The first two patches in my series are the ones that I think folks should take a closer look at. The rest are pretty safe. I'm running both patch sets right now on my laptop. So far it is running perfectly. Greg -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Greg On Wed, Sep 07, 2011 at 10:51:26PM -0500, Greg Dietsche wrote: > On 09/06/2011 10:01 AM, Stanislaw Gruszka wrote: > >I put patches here: > >http://people.redhat.com/sgruszka/iwlegacy_cleanup.tar.bz2 > > > >They are on top of wireless-testing tree. > <snip> > >Series include your 2 patches. You can test this cleanup and > >apply your new changes on top. I'll not do any further cleanup > >for some time now, perhaps continue when I got public git tree. > > > Thanks! I've re-worked my patches and you can find them here: > http://www.gregd.org/stuff/linux/iwlegacy_cleanup_greg.tar.bz2 > > I also decided to play with github a little bit: > git://github.com/dietsche/linux.git and pushed two branches: > 1) wireless-next-iwlegacy-stanislaw - your patch set > 2) wireless-next-iwlegacy-stanislaw-greg - a branch that has my > additional patches. > `git format-patch wireless-next-iwlegacy-stanislaw..wireless-next-iwlegacy-stanislaw-greg` > will generate the patches that are in the link i posted above. Cool! > The first two patches in my series are the ones that I think folks > should take a closer look at. The rest are pretty safe. The second patch is ok. I'm not sure about first one, but we can get rid of "ctx = il_rxon_ctx_from_vif(vif)" at all, because we have only one context. Removing il_rxon_context structure from iwlegacy driver is my long term plan, you can look at that if you wish. Thanks Stanislaw -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, 8 Sep 2011 18:11:30 +0200, Stanislaw Gruszka wrote: <snip> > The second patch is ok. I'm not sure about first one, but we can get > rid of "ctx = il_rxon_ctx_from_vif(vif)" at all, because we have > only one context. Removing il_rxon_context structure from > iwlegacy driver is my long term plan, you can look at that > if you wish. Sounds good. I'll let you know if I start to remove the il_rxon_context structure. It looks right now like I might not have much free time in the near future. Greg -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/net/wireless/iwlegacy/iwl-4965-tx.c b/drivers/net/wireless/iwlegacy/iwl-4965-tx.c index ac4f64d..f8c7eab 100644 --- a/drivers/net/wireless/iwlegacy/iwl-4965-tx.c +++ b/drivers/net/wireless/iwlegacy/iwl-4965-tx.c @@ -877,7 +877,7 @@ int iwl4965_tx_agg_start(struct iwl_priv *priv, struct ieee80211_vif *vif, if (unlikely(tx_fifo < 0)) return tx_fifo; - IWL_WARN(priv, "%s on ra = %pM tid = %d\n", + IWL_DEBUG_HT(priv, "%s on ra = %pM tid = %d\n", __func__, sta->addr, tid); sta_id = iwl_legacy_sta_id(sta);
This message should be a debug message and not a warning. So change it from IWL_WARN to IWL_DEBUG_HT. Signed-off-by: Greg Dietsche <Gregory.Dietsche@cuw.edu> --- drivers/net/wireless/iwlegacy/iwl-4965-tx.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)