Patchwork [U-Boot,v2,01/16] ARM: remove broken "armadillo" board

login
register
mail settings
Submitter Marek Vasut
Date Aug. 26, 2011, 3:41 p.m.
Message ID <201108261741.38560.marek.vasut@gmail.com>
Download mbox | patch
Permalink /patch/111800/
State Not Applicable
Delegated to: Albert ARIBAUD
Headers show

Comments

Marek Vasut - Aug. 26, 2011, 3:41 p.m.
On Friday, August 26, 2011 02:25:33 PM Wolfgang Denk wrote:
> Signed-off-by: Wolfgang Denk <wd@denx.de>
> Cc: Rowel Atienza <rowel@diwalabs.com>
> ---
>  MAINTAINERS                     |    4 -
>  MAKEALL                         |    1 -
>  board/armadillo/Makefile        |   55 -------
>  board/armadillo/armadillo.c     |   72 --------
>  board/armadillo/config.mk       |   29 ----
>  board/armadillo/flash.c         |  340
> --------------------------------------- board/armadillo/lowlevel_init.S | 
>  66 --------
>  boards.cfg                      |    1 -
>  doc/README.scrapyard            |    1 +
>  include/configs/armadillo.h     |  157 ------------------
>  10 files changed, 1 insertions(+), 725 deletions(-)
>  delete mode 100644 board/armadillo/Makefile
>  delete mode 100644 board/armadillo/armadillo.c
>  delete mode 100644 board/armadillo/config.mk
>  delete mode 100644 board/armadillo/flash.c
>  delete mode 100644 board/armadillo/lowlevel_init.S
>  delete mode 100644 include/configs/armadillo.h
> 

This one can be fixed with such a patch, though I dunno if it's worth it.
Wolfgang Denk - Aug. 26, 2011, 7:57 p.m.
Dear Marek Vasut,

In message <201108261741.38560.marek.vasut@gmail.com> you wrote:
>
> This one can be fixed with such a patch, though I dunno if it's worth it.

If you are sure that this is sufficient, then could you please submit
a proper patch with Subject, SoB-Line, etc.?


Rowel, can you please confirm that this patch works for you, too?


Thanks.

Best regards,

Wolfgang Denk
Marek Vasut - Aug. 26, 2011, 8:49 p.m.
On Friday, August 26, 2011 09:57:15 PM Wolfgang Denk wrote:
> Dear Marek Vasut,
> 
> In message <201108261741.38560.marek.vasut@gmail.com> you wrote:
> > This one can be fixed with such a patch, though I dunno if it's worth it.
> 
> If you are sure that this is sufficient, then could you please submit
> a proper patch with Subject, SoB-Line, etc.?
> 
Ok, what I meant by "dunno if it's worth it" is, whether we do or don't want to 
prolong the agony of this board. Noone maintains it anymore, it's basically a 
dead code. Do we want to keep it? Correct me if I'm wrong.

Cheers

> 
> Rowel, can you please confirm that this patch works for you, too?
> 
> 
> Thanks.
> 
> Best regards,
> 
> Wolfgang Denk
Wolfgang Denk - Aug. 26, 2011, 10:29 p.m.
Dear Marek Vasut,

In message <201108262249.13179.marek.vasut@gmail.com> you wrote:
>
> > If you are sure that this is sufficient, then could you please submit
> > a proper patch with Subject, SoB-Line, etc.?
> > 
> Ok, what I meant by "dunno if it's worth it" is, whether we do or don't want to 
> prolong the agony of this board. Noone maintains it anymore, it's basically a 
> dead code. Do we want to keep it? Correct me if I'm wrong.

Well, let's see if Rowel wakes up now.

Best regards,

Wolfgang Denk
Albert ARIBAUD - Aug. 30, 2011, 6:06 a.m.
Hi Marek,

> This one can be fixed with such a patch, though I dunno if it's worth it.
>
> diff --git a/include/configs/armadillo.h b/include/configs/armadillo.h
> [...]

I have seen the rest of the discussion already, and will apply the 
armadillo removal patch. I just want to make a quick note (again) to all:

Please avoid copy-pasting a patch or even part of a patch in your 
replies to an official patch, because patchwork then believes you have 
actually posted a new patch and created a new entry, "hijacking" the 
comments for the original one.

The 'armadillo' patch shows the issue:

<http://patchwork.ozlabs.org/patch/111747/> is the actual patch which 
should have had the comments, but these were 'hijacked' and stored under 
<http://patchwork.ozlabs.org/patch/111800/> which is actually not a 
patch but one of the replies.

Amicalement,
Marek Vasut - Aug. 30, 2011, 7:20 a.m.
On Tuesday, August 30, 2011 08:06:43 AM Albert ARIBAUD wrote:
> Hi Marek,
> 
> > This one can be fixed with such a patch, though I dunno if it's worth it.
> > 
> > diff --git a/include/configs/armadillo.h b/include/configs/armadillo.h
> > [...]
> 
> I have seen the rest of the discussion already, and will apply the
> armadillo removal patch. I just want to make a quick note (again) to all:

Yes, it seems the person maintaining Armadillo doesn't respond. Even worse, that 
mailbox is long abandoned.

> 
> Please avoid copy-pasting a patch or even part of a patch in your
> replies to an official patch, because patchwork then believes you have
> actually posted a new patch and created a new entry, "hijacking" the
> comments for the original one.

Ah damn, ok.

> 
> The 'armadillo' patch shows the issue:
> 
> <http://patchwork.ozlabs.org/patch/111747/> is the actual patch which
> should have had the comments, but these were 'hijacked' and stored under
> <http://patchwork.ozlabs.org/patch/111800/> which is actually not a
> patch but one of the replies.
> 
> Amicalement,

Cheers
Wolfgang Denk - Aug. 30, 2011, 9:32 a.m.
Dear Albert ARIBAUD,

In message <4E5C7DF3.3090506@aribaud.net> you wrote:
> Hi Marek,
> 
> > This one can be fixed with such a patch, though I dunno if it's worth it.
> >
> > diff --git a/include/configs/armadillo.h b/include/configs/armadillo.h
> > [...]
> 
> I have seen the rest of the discussion already, and will apply the 
> armadillo removal patch. I just want to make a quick note (again) to all:

Yes, please remove the board.  All attempts to contect the currently
known maintainer address failed.

Best regards,

Wolfgang Denk

Patch

diff --git a/include/configs/armadillo.h b/include/configs/armadillo.h
index d0d0998..8a2d2b7 100644
--- a/include/configs/armadillo.h
+++ b/include/configs/armadillo.h
@@ -135,6 +135,8 @@ 
 #define PHYS_FLASH_SIZE                0x00400000 /* 4 MB */
 
 #define CONFIG_SYS_FLASH_BASE          PHYS_FLASH_1
+#define        CONFIG_SYS_SDRAM_BASE           PHYS_SDRAM_1
+#define        CONFIG_SYS_INIT_SP_ADDR         (PHYS_SDRAM_1 + CONFIG_STACKSIZE)
 
 /*-----------------------------------------------------------------------
  * FLASH and environment organization