[v2] jffs2: remove C++ style comments from uapi header
diff mbox series

Message ID 20190618030926.30616-1-yamada.masahiro@socionext.com
State New
Headers show
Series
  • [v2] jffs2: remove C++ style comments from uapi header
Related show

Commit Message

Masahiro Yamada June 18, 2019, 3:09 a.m. UTC
Linux kernel tolerates C++ style comments these days. Actually, the
SPDX License tags for .c files start with //.

On the other hand, uapi headers are written in more strict C, where
the C++ comment style is forbidden.

I simply dropped these lines instead of fixing the comment style.

This code has been always commented out since it was added around
Linux 2.4.9 (i.e. commented out for more than 17 years).

'Maybe later...' will never happen.

Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---

Changes in v2:
  - Delete the comments entirely instead of fixing the comment style

 include/uapi/linux/jffs2.h | 5 -----
 1 file changed, 5 deletions(-)

Comments

Richard Weinberger June 18, 2019, 6:19 a.m. UTC | #1
----- Ursprüngliche Mail -----
> Von: "Masahiro Yamada" <yamada.masahiro@socionext.com>
> An: "linux-mtd" <linux-mtd@lists.infradead.org>
> CC: "Boris Brezillon" <bbrezillon@kernel.org>, "Miquel Raynal" <miquel.raynal@bootlin.com>, "Brian Norris"
> <computersforpeace@gmail.com>, "Vignesh Raghavendra" <vigneshr@ti.com>, "Marek Vasut" <marek.vasut@gmail.com>,
> "Masahiro Yamada" <yamada.masahiro@socionext.com>, "richard" <richard@nod.at>, "David Woodhouse" <dwmw2@infradead.org>,
> "linux-kernel" <linux-kernel@vger.kernel.org>
> Gesendet: Dienstag, 18. Juni 2019 05:09:26
> Betreff: [PATCH v2] jffs2: remove C++ style comments from uapi header

> Linux kernel tolerates C++ style comments these days. Actually, the
> SPDX License tags for .c files start with //.
> 
> On the other hand, uapi headers are written in more strict C, where
> the C++ comment style is forbidden.
> 
> I simply dropped these lines instead of fixing the comment style.
> 
> This code has been always commented out since it was added around
> Linux 2.4.9 (i.e. commented out for more than 17 years).
> 
> 'Maybe later...' will never happen.

:-)
 
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>

Acked-by: Richard Weinberger <richard@nod.at>

Thanks,
//richard
Masahiro Yamada June 27, 2019, 7:06 a.m. UTC | #2
On Tue, Jun 18, 2019 at 3:20 PM Richard Weinberger <richard@nod.at> wrote:
>
> ----- Ursprüngliche Mail -----
> > Von: "Masahiro Yamada" <yamada.masahiro@socionext.com>
> > An: "linux-mtd" <linux-mtd@lists.infradead.org>
> > CC: "Boris Brezillon" <bbrezillon@kernel.org>, "Miquel Raynal" <miquel.raynal@bootlin.com>, "Brian Norris"
> > <computersforpeace@gmail.com>, "Vignesh Raghavendra" <vigneshr@ti.com>, "Marek Vasut" <marek.vasut@gmail.com>,
> > "Masahiro Yamada" <yamada.masahiro@socionext.com>, "richard" <richard@nod.at>, "David Woodhouse" <dwmw2@infradead.org>,
> > "linux-kernel" <linux-kernel@vger.kernel.org>
> > Gesendet: Dienstag, 18. Juni 2019 05:09:26
> > Betreff: [PATCH v2] jffs2: remove C++ style comments from uapi header
>
> > Linux kernel tolerates C++ style comments these days. Actually, the
> > SPDX License tags for .c files start with //.
> >
> > On the other hand, uapi headers are written in more strict C, where
> > the C++ comment style is forbidden.
> >
> > I simply dropped these lines instead of fixing the comment style.
> >
> > This code has been always commented out since it was added around
> > Linux 2.4.9 (i.e. commented out for more than 17 years).
> >
> > 'Maybe later...' will never happen.
>
> :-)
>
> > Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
>
> Acked-by: Richard Weinberger <richard@nod.at>
>
> Thanks,
> //richard


Will this be picked up for v5.3-rc1 ?
Richard Weinberger June 27, 2019, 7:39 a.m. UTC | #3
----- Ursprüngliche Mail -----
> Von: "Masahiro Yamada" <yamada.masahiro@socionext.com>
> An: "richard" <richard@nod.at>
> CC: "Vignesh Raghavendra" <vigneshr@ti.com>, "Boris Brezillon" <bbrezillon@kernel.org>, "linux-kernel"
> <linux-kernel@vger.kernel.org>, "Marek Vasut" <marek.vasut@gmail.com>, "linux-mtd" <linux-mtd@lists.infradead.org>,
> "Miquel Raynal" <miquel.raynal@bootlin.com>, "Brian Norris" <computersforpeace@gmail.com>, "David Woodhouse"
> <dwmw2@infradead.org>
> Gesendet: Donnerstag, 27. Juni 2019 09:06:31
> Betreff: Re: [PATCH v2] jffs2: remove C++ style comments from uapi header

> On Tue, Jun 18, 2019 at 3:20 PM Richard Weinberger <richard@nod.at> wrote:
>>
>> ----- Ursprüngliche Mail -----
>> > Von: "Masahiro Yamada" <yamada.masahiro@socionext.com>
>> > An: "linux-mtd" <linux-mtd@lists.infradead.org>
>> > CC: "Boris Brezillon" <bbrezillon@kernel.org>, "Miquel Raynal"
>> > <miquel.raynal@bootlin.com>, "Brian Norris"
>> > <computersforpeace@gmail.com>, "Vignesh Raghavendra" <vigneshr@ti.com>, "Marek
>> > Vasut" <marek.vasut@gmail.com>,
>> > "Masahiro Yamada" <yamada.masahiro@socionext.com>, "richard" <richard@nod.at>,
>> > "David Woodhouse" <dwmw2@infradead.org>,
>> > "linux-kernel" <linux-kernel@vger.kernel.org>
>> > Gesendet: Dienstag, 18. Juni 2019 05:09:26
>> > Betreff: [PATCH v2] jffs2: remove C++ style comments from uapi header
>>
>> > Linux kernel tolerates C++ style comments these days. Actually, the
>> > SPDX License tags for .c files start with //.
>> >
>> > On the other hand, uapi headers are written in more strict C, where
>> > the C++ comment style is forbidden.
>> >
>> > I simply dropped these lines instead of fixing the comment style.
>> >
>> > This code has been always commented out since it was added around
>> > Linux 2.4.9 (i.e. commented out for more than 17 years).
>> >
>> > 'Maybe later...' will never happen.
>>
>> :-)
>>
>> > Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
>>
>> Acked-by: Richard Weinberger <richard@nod.at>
>>
>> Thanks,
>> //richard
> 
> 
> Will this be picked up for v5.3-rc1 ?

Yes.

Thanks,
//richard
Masahiro Yamada July 13, 2019, 11:37 p.m. UTC | #4
On Thu, Jun 27, 2019 at 4:39 PM Richard Weinberger <richard@nod.at> wrote:
>
> ----- Ursprüngliche Mail -----
> > Von: "Masahiro Yamada" <yamada.masahiro@socionext.com>
> > An: "richard" <richard@nod.at>
> > CC: "Vignesh Raghavendra" <vigneshr@ti.com>, "Boris Brezillon" <bbrezillon@kernel.org>, "linux-kernel"
> > <linux-kernel@vger.kernel.org>, "Marek Vasut" <marek.vasut@gmail.com>, "linux-mtd" <linux-mtd@lists.infradead.org>,
> > "Miquel Raynal" <miquel.raynal@bootlin.com>, "Brian Norris" <computersforpeace@gmail.com>, "David Woodhouse"
> > <dwmw2@infradead.org>
> > Gesendet: Donnerstag, 27. Juni 2019 09:06:31
> > Betreff: Re: [PATCH v2] jffs2: remove C++ style comments from uapi header
>
> > On Tue, Jun 18, 2019 at 3:20 PM Richard Weinberger <richard@nod.at> wrote:
> >>
> >> ----- Ursprüngliche Mail -----
> >> > Von: "Masahiro Yamada" <yamada.masahiro@socionext.com>
> >> > An: "linux-mtd" <linux-mtd@lists.infradead.org>
> >> > CC: "Boris Brezillon" <bbrezillon@kernel.org>, "Miquel Raynal"
> >> > <miquel.raynal@bootlin.com>, "Brian Norris"
> >> > <computersforpeace@gmail.com>, "Vignesh Raghavendra" <vigneshr@ti.com>, "Marek
> >> > Vasut" <marek.vasut@gmail.com>,
> >> > "Masahiro Yamada" <yamada.masahiro@socionext.com>, "richard" <richard@nod.at>,
> >> > "David Woodhouse" <dwmw2@infradead.org>,
> >> > "linux-kernel" <linux-kernel@vger.kernel.org>
> >> > Gesendet: Dienstag, 18. Juni 2019 05:09:26
> >> > Betreff: [PATCH v2] jffs2: remove C++ style comments from uapi header
> >>
> >> > Linux kernel tolerates C++ style comments these days. Actually, the
> >> > SPDX License tags for .c files start with //.
> >> >
> >> > On the other hand, uapi headers are written in more strict C, where
> >> > the C++ comment style is forbidden.
> >> >
> >> > I simply dropped these lines instead of fixing the comment style.
> >> >
> >> > This code has been always commented out since it was added around
> >> > Linux 2.4.9 (i.e. commented out for more than 17 years).
> >> >
> >> > 'Maybe later...' will never happen.
> >>
> >> :-)
> >>
> >> > Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> >>
> >> Acked-by: Richard Weinberger <richard@nod.at>
> >>
> >> Thanks,
> >> //richard
> >
> >
> > Will this be picked up for v5.3-rc1 ?
>
> Yes.
>
> Thanks,
> //richard



Looks like this trivial patch missed the pull request.


My motivation is to make sure UAPI headers
are really compilable in user-space,
and now checked by the following commit:

commit d6fc9fcbaa655cff2d2be05e16867d1918f78b85
Author: Masahiro Yamada <yamada.masahiro@socionext.com>
Date:   Mon Jul 1 09:58:40 2019 +0900

    kbuild: compile-test exported headers to ensure they are self-contained



Is there a chance for it being merged,
or must wait until v5.4-rc1 ?
Richard Weinberger July 14, 2019, 8:08 a.m. UTC | #5
----- Ursprüngliche Mail -----
> Looks like this trivial patch missed the pull request.
> 
> 
> My motivation is to make sure UAPI headers
> are really compilable in user-space,
> and now checked by the following commit:
> 
> commit d6fc9fcbaa655cff2d2be05e16867d1918f78b85
> Author: Masahiro Yamada <yamada.masahiro@socionext.com>
> Date:   Mon Jul 1 09:58:40 2019 +0900
> 
>    kbuild: compile-test exported headers to ensure they are self-contained
> 
> 
> 
> Is there a chance for it being merged,

Sure. I think it is okay to send it for -rc2.

Thanks,
//richard

Patch
diff mbox series

diff --git a/include/uapi/linux/jffs2.h b/include/uapi/linux/jffs2.h
index a18b719f49d4..784ba0b9690a 100644
--- a/include/uapi/linux/jffs2.h
+++ b/include/uapi/linux/jffs2.h
@@ -77,11 +77,6 @@ 
 
 #define JFFS2_ACL_VERSION		0x0001
 
-// Maybe later...
-//#define JFFS2_NODETYPE_CHECKPOINT (JFFS2_FEATURE_RWCOMPAT_DELETE | JFFS2_NODE_ACCURATE | 3)
-//#define JFFS2_NODETYPE_OPTIONS (JFFS2_FEATURE_RWCOMPAT_COPY | JFFS2_NODE_ACCURATE | 4)
-
-
 #define JFFS2_INO_FLAG_PREREAD	  1	/* Do read_inode() for this one at
 					   mount time, don't wait for it to
 					   happen later */