| Message ID | 20190618030926.30616-1-yamada.masahiro@socionext.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [v2] jffs2: remove C++ style comments from uapi header | expand |
----- Ursprüngliche Mail ----- > Von: "Masahiro Yamada" <yamada.masahiro@socionext.com> > An: "linux-mtd" <linux-mtd@lists.infradead.org> > CC: "Boris Brezillon" <bbrezillon@kernel.org>, "Miquel Raynal" <miquel.raynal@bootlin.com>, "Brian Norris" > <computersforpeace@gmail.com>, "Vignesh Raghavendra" <vigneshr@ti.com>, "Marek Vasut" <marek.vasut@gmail.com>, > "Masahiro Yamada" <yamada.masahiro@socionext.com>, "richard" <richard@nod.at>, "David Woodhouse" <dwmw2@infradead.org>, > "linux-kernel" <linux-kernel@vger.kernel.org> > Gesendet: Dienstag, 18. Juni 2019 05:09:26 > Betreff: [PATCH v2] jffs2: remove C++ style comments from uapi header > Linux kernel tolerates C++ style comments these days. Actually, the > SPDX License tags for .c files start with //. > > On the other hand, uapi headers are written in more strict C, where > the C++ comment style is forbidden. > > I simply dropped these lines instead of fixing the comment style. > > This code has been always commented out since it was added around > Linux 2.4.9 (i.e. commented out for more than 17 years). > > 'Maybe later...' will never happen. :-) > Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> Acked-by: Richard Weinberger <richard@nod.at> Thanks, //richard
On Tue, Jun 18, 2019 at 3:20 PM Richard Weinberger <richard@nod.at> wrote: > > ----- Ursprüngliche Mail ----- > > Von: "Masahiro Yamada" <yamada.masahiro@socionext.com> > > An: "linux-mtd" <linux-mtd@lists.infradead.org> > > CC: "Boris Brezillon" <bbrezillon@kernel.org>, "Miquel Raynal" <miquel.raynal@bootlin.com>, "Brian Norris" > > <computersforpeace@gmail.com>, "Vignesh Raghavendra" <vigneshr@ti.com>, "Marek Vasut" <marek.vasut@gmail.com>, > > "Masahiro Yamada" <yamada.masahiro@socionext.com>, "richard" <richard@nod.at>, "David Woodhouse" <dwmw2@infradead.org>, > > "linux-kernel" <linux-kernel@vger.kernel.org> > > Gesendet: Dienstag, 18. Juni 2019 05:09:26 > > Betreff: [PATCH v2] jffs2: remove C++ style comments from uapi header > > > Linux kernel tolerates C++ style comments these days. Actually, the > > SPDX License tags for .c files start with //. > > > > On the other hand, uapi headers are written in more strict C, where > > the C++ comment style is forbidden. > > > > I simply dropped these lines instead of fixing the comment style. > > > > This code has been always commented out since it was added around > > Linux 2.4.9 (i.e. commented out for more than 17 years). > > > > 'Maybe later...' will never happen. > > :-) > > > Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> > > Acked-by: Richard Weinberger <richard@nod.at> > > Thanks, > //richard Will this be picked up for v5.3-rc1 ?
----- Ursprüngliche Mail ----- > Von: "Masahiro Yamada" <yamada.masahiro@socionext.com> > An: "richard" <richard@nod.at> > CC: "Vignesh Raghavendra" <vigneshr@ti.com>, "Boris Brezillon" <bbrezillon@kernel.org>, "linux-kernel" > <linux-kernel@vger.kernel.org>, "Marek Vasut" <marek.vasut@gmail.com>, "linux-mtd" <linux-mtd@lists.infradead.org>, > "Miquel Raynal" <miquel.raynal@bootlin.com>, "Brian Norris" <computersforpeace@gmail.com>, "David Woodhouse" > <dwmw2@infradead.org> > Gesendet: Donnerstag, 27. Juni 2019 09:06:31 > Betreff: Re: [PATCH v2] jffs2: remove C++ style comments from uapi header > On Tue, Jun 18, 2019 at 3:20 PM Richard Weinberger <richard@nod.at> wrote: >> >> ----- Ursprüngliche Mail ----- >> > Von: "Masahiro Yamada" <yamada.masahiro@socionext.com> >> > An: "linux-mtd" <linux-mtd@lists.infradead.org> >> > CC: "Boris Brezillon" <bbrezillon@kernel.org>, "Miquel Raynal" >> > <miquel.raynal@bootlin.com>, "Brian Norris" >> > <computersforpeace@gmail.com>, "Vignesh Raghavendra" <vigneshr@ti.com>, "Marek >> > Vasut" <marek.vasut@gmail.com>, >> > "Masahiro Yamada" <yamada.masahiro@socionext.com>, "richard" <richard@nod.at>, >> > "David Woodhouse" <dwmw2@infradead.org>, >> > "linux-kernel" <linux-kernel@vger.kernel.org> >> > Gesendet: Dienstag, 18. Juni 2019 05:09:26 >> > Betreff: [PATCH v2] jffs2: remove C++ style comments from uapi header >> >> > Linux kernel tolerates C++ style comments these days. Actually, the >> > SPDX License tags for .c files start with //. >> > >> > On the other hand, uapi headers are written in more strict C, where >> > the C++ comment style is forbidden. >> > >> > I simply dropped these lines instead of fixing the comment style. >> > >> > This code has been always commented out since it was added around >> > Linux 2.4.9 (i.e. commented out for more than 17 years). >> > >> > 'Maybe later...' will never happen. >> >> :-) >> >> > Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> >> >> Acked-by: Richard Weinberger <richard@nod.at> >> >> Thanks, >> //richard > > > Will this be picked up for v5.3-rc1 ? Yes. Thanks, //richard
On Thu, Jun 27, 2019 at 4:39 PM Richard Weinberger <richard@nod.at> wrote: > > ----- Ursprüngliche Mail ----- > > Von: "Masahiro Yamada" <yamada.masahiro@socionext.com> > > An: "richard" <richard@nod.at> > > CC: "Vignesh Raghavendra" <vigneshr@ti.com>, "Boris Brezillon" <bbrezillon@kernel.org>, "linux-kernel" > > <linux-kernel@vger.kernel.org>, "Marek Vasut" <marek.vasut@gmail.com>, "linux-mtd" <linux-mtd@lists.infradead.org>, > > "Miquel Raynal" <miquel.raynal@bootlin.com>, "Brian Norris" <computersforpeace@gmail.com>, "David Woodhouse" > > <dwmw2@infradead.org> > > Gesendet: Donnerstag, 27. Juni 2019 09:06:31 > > Betreff: Re: [PATCH v2] jffs2: remove C++ style comments from uapi header > > > On Tue, Jun 18, 2019 at 3:20 PM Richard Weinberger <richard@nod.at> wrote: > >> > >> ----- Ursprüngliche Mail ----- > >> > Von: "Masahiro Yamada" <yamada.masahiro@socionext.com> > >> > An: "linux-mtd" <linux-mtd@lists.infradead.org> > >> > CC: "Boris Brezillon" <bbrezillon@kernel.org>, "Miquel Raynal" > >> > <miquel.raynal@bootlin.com>, "Brian Norris" > >> > <computersforpeace@gmail.com>, "Vignesh Raghavendra" <vigneshr@ti.com>, "Marek > >> > Vasut" <marek.vasut@gmail.com>, > >> > "Masahiro Yamada" <yamada.masahiro@socionext.com>, "richard" <richard@nod.at>, > >> > "David Woodhouse" <dwmw2@infradead.org>, > >> > "linux-kernel" <linux-kernel@vger.kernel.org> > >> > Gesendet: Dienstag, 18. Juni 2019 05:09:26 > >> > Betreff: [PATCH v2] jffs2: remove C++ style comments from uapi header > >> > >> > Linux kernel tolerates C++ style comments these days. Actually, the > >> > SPDX License tags for .c files start with //. > >> > > >> > On the other hand, uapi headers are written in more strict C, where > >> > the C++ comment style is forbidden. > >> > > >> > I simply dropped these lines instead of fixing the comment style. > >> > > >> > This code has been always commented out since it was added around > >> > Linux 2.4.9 (i.e. commented out for more than 17 years). > >> > > >> > 'Maybe later...' will never happen. > >> > >> :-) > >> > >> > Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> > >> > >> Acked-by: Richard Weinberger <richard@nod.at> > >> > >> Thanks, > >> //richard > > > > > > Will this be picked up for v5.3-rc1 ? > > Yes. > > Thanks, > //richard Looks like this trivial patch missed the pull request. My motivation is to make sure UAPI headers are really compilable in user-space, and now checked by the following commit: commit d6fc9fcbaa655cff2d2be05e16867d1918f78b85 Author: Masahiro Yamada <yamada.masahiro@socionext.com> Date: Mon Jul 1 09:58:40 2019 +0900 kbuild: compile-test exported headers to ensure they are self-contained Is there a chance for it being merged, or must wait until v5.4-rc1 ?
----- Ursprüngliche Mail ----- > Looks like this trivial patch missed the pull request. > > > My motivation is to make sure UAPI headers > are really compilable in user-space, > and now checked by the following commit: > > commit d6fc9fcbaa655cff2d2be05e16867d1918f78b85 > Author: Masahiro Yamada <yamada.masahiro@socionext.com> > Date: Mon Jul 1 09:58:40 2019 +0900 > > kbuild: compile-test exported headers to ensure they are self-contained > > > > Is there a chance for it being merged, Sure. I think it is okay to send it for -rc2. Thanks, //richard
On Sun, Jul 14, 2019 at 10:08 AM Richard Weinberger <richard@nod.at> wrote: > > ----- Ursprüngliche Mail ----- > > Looks like this trivial patch missed the pull request. > > > > > > My motivation is to make sure UAPI headers > > are really compilable in user-space, > > and now checked by the following commit: > > > > commit d6fc9fcbaa655cff2d2be05e16867d1918f78b85 > > Author: Masahiro Yamada <yamada.masahiro@socionext.com> > > Date: Mon Jul 1 09:58:40 2019 +0900 > > > > kbuild: compile-test exported headers to ensure they are self-contained > > > > > > > > Is there a chance for it being merged, Appled.
On Sun, Jul 14, 2019 at 5:08 PM Richard Weinberger <richard@nod.at> wrote: > > ----- Ursprüngliche Mail ----- > > Looks like this trivial patch missed the pull request. > > > > > > My motivation is to make sure UAPI headers > > are really compilable in user-space, > > and now checked by the following commit: > > > > commit d6fc9fcbaa655cff2d2be05e16867d1918f78b85 > > Author: Masahiro Yamada <yamada.masahiro@socionext.com> > > Date: Mon Jul 1 09:58:40 2019 +0900 > > > > kbuild: compile-test exported headers to ensure they are self-contained > > > > > > > > Is there a chance for it being merged, > > Sure. I think it is okay to send it for -rc2. > > Thanks, > //richard This patch missed the fixes pull requests. Which version is this targeting for? v5.4-rc1 ?
On Mon, Jul 29, 2019 at 4:14 PM Richard Weinberger <richard.weinberger@gmail.com> wrote: > > On Sun, Jul 14, 2019 at 10:08 AM Richard Weinberger <richard@nod.at> wrote: > > > > ----- Ursprüngliche Mail ----- > > > Looks like this trivial patch missed the pull request. > > > > > > > > > My motivation is to make sure UAPI headers > > > are really compilable in user-space, > > > and now checked by the following commit: > > > > > > commit d6fc9fcbaa655cff2d2be05e16867d1918f78b85 > > > Author: Masahiro Yamada <yamada.masahiro@socionext.com> > > > Date: Mon Jul 1 09:58:40 2019 +0900 > > > > > > kbuild: compile-test exported headers to ensure they are self-contained > > > > > > > > > > > > Is there a chance for it being merged, > > Appled. > > -- > Thanks, > //richard I checked next-20190819, but I still do not see this patch. Where has this patch gone?
----- Ursprüngliche Mail ----- > This patch missed the fixes pull requests. > Which version is this targeting for? v5.4-rc1 ? Damn, I forgot about this one. I'll do another fixes PR this week for UBI/UBIFS, so it will be in tree before the next merge window opens. Sorry for the delay! Thanks, //richard
diff --git a/include/uapi/linux/jffs2.h b/include/uapi/linux/jffs2.h index a18b719f49d4..784ba0b9690a 100644 --- a/include/uapi/linux/jffs2.h +++ b/include/uapi/linux/jffs2.h @@ -77,11 +77,6 @@ #define JFFS2_ACL_VERSION 0x0001 -// Maybe later... -//#define JFFS2_NODETYPE_CHECKPOINT (JFFS2_FEATURE_RWCOMPAT_DELETE | JFFS2_NODE_ACCURATE | 3) -//#define JFFS2_NODETYPE_OPTIONS (JFFS2_FEATURE_RWCOMPAT_COPY | JFFS2_NODE_ACCURATE | 4) - - #define JFFS2_INO_FLAG_PREREAD 1 /* Do read_inode() for this one at mount time, don't wait for it to happen later */
Linux kernel tolerates C++ style comments these days. Actually, the SPDX License tags for .c files start with //. On the other hand, uapi headers are written in more strict C, where the C++ comment style is forbidden. I simply dropped these lines instead of fixing the comment style. This code has been always commented out since it was added around Linux 2.4.9 (i.e. commented out for more than 17 years). 'Maybe later...' will never happen. Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> --- Changes in v2: - Delete the comments entirely instead of fixing the comment style include/uapi/linux/jffs2.h | 5 ----- 1 file changed, 5 deletions(-)