| Message ID | 20190617115721.27525-1-kwolf@redhat.com |
|---|---|
| State | New |
| Headers | show |
| Series | block/null: Expose read-zeroes option in QAPI schema | expand |
On 17.06.19 13:57, Kevin Wolf wrote: > Commit cd219eb1e55 added the read-zeroes option for the null-co and > null-aio block driver, but forgot to add them to the QAPI schema. > Therefore, this option wasn't available in -blockdev and blockdev-add > until now. > > Add the missing option in the schema to make it available there, too. > > Signed-off-by: Kevin Wolf <kwolf@redhat.com> > --- > qapi/block-core.json | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) Reviewed-by: Max Reitz <mreitz@redhat.com>
On 17/06/2019 14:57, Kevin Wolf wrote: > Commit cd219eb1e55 added the read-zeroes option for the null-co and > null-aio block driver, but forgot to add them to the QAPI schema. > Therefore, this option wasn't available in -blockdev and blockdev-add > until now. > > Add the missing option in the schema to make it available there, too. > > Signed-off-by: Kevin Wolf <kwolf@redhat.com> > --- > qapi/block-core.json | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/qapi/block-core.json b/qapi/block-core.json > index 61124431d8..0d43d4f37c 100644 > --- a/qapi/block-core.json > +++ b/qapi/block-core.json > @@ -2890,11 +2890,13 @@ > # @latency-ns: emulated latency (in nanoseconds) in processing > # requests. Default to zero which completes requests immediately. > # (Since 2.4) > +# @read-zeroes: if true, reads from the device produce zeroes; if false, the > +# buffer is left unchanged. (default: false; since: 4.1) > # > # Since: 2.9 > ## > { 'struct': 'BlockdevOptionsNull', > - 'data': { '*size': 'int', '*latency-ns': 'uint64' } } > + 'data': { '*size': 'int', '*latency-ns': 'uint64', '*read-zeroes': 'bool' } } > > ## > # @BlockdevOptionsNVMe: > Reviewed-by: Andrey Shinkevich <andrey.shinkevich@virtuozzo.com>
diff --git a/qapi/block-core.json b/qapi/block-core.json index 61124431d8..0d43d4f37c 100644 --- a/qapi/block-core.json +++ b/qapi/block-core.json @@ -2890,11 +2890,13 @@ # @latency-ns: emulated latency (in nanoseconds) in processing # requests. Default to zero which completes requests immediately. # (Since 2.4) +# @read-zeroes: if true, reads from the device produce zeroes; if false, the +# buffer is left unchanged. (default: false; since: 4.1) # # Since: 2.9 ## { 'struct': 'BlockdevOptionsNull', - 'data': { '*size': 'int', '*latency-ns': 'uint64' } } + 'data': { '*size': 'int', '*latency-ns': 'uint64', '*read-zeroes': 'bool' } } ## # @BlockdevOptionsNVMe:
Commit cd219eb1e55 added the read-zeroes option for the null-co and null-aio block driver, but forgot to add them to the QAPI schema. Therefore, this option wasn't available in -blockdev and blockdev-add until now. Add the missing option in the schema to make it available there, too. Signed-off-by: Kevin Wolf <kwolf@redhat.com> --- qapi/block-core.json | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)