Patchwork [06/17] omap_gpmc: GPMC_IRQSTATUS is write-one-to-clear

login
register
mail settings
Submitter Peter Maydell
Date Aug. 25, 2011, 8:05 p.m.
Message ID <1314302711-20498-7-git-send-email-peter.maydell@linaro.org>
Download mbox | patch
Permalink /patch/111672/
State New
Headers show

Comments

Peter Maydell - Aug. 25, 2011, 8:05 p.m.
Fix a bug in the handling of writes to GPMC_IRQSTATUS:
it behaves as "write one to clear, writing zero is ignored".

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
 hw/omap_gpmc.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Patch

diff --git a/hw/omap_gpmc.c b/hw/omap_gpmc.c
index d16b28b..ff4d485 100644
--- a/hw/omap_gpmc.c
+++ b/hw/omap_gpmc.c
@@ -284,7 +284,7 @@  static void omap_gpmc_write(void *opaque, target_phys_addr_t addr,
         break;
 
     case 0x018:	/* GPMC_IRQSTATUS */
-        s->irqen = ~value;
+        s->irqen &= ~value;
         omap_gpmc_int_update(s);
         break;