diff mbox series

[01/27] package/keyutils: re-enable package on microblaze

Message ID 20190614210346.121013-2-giulio.benetti@micronovasrl.com
State Accepted
Headers show
Series [01/27] package/keyutils: re-enable package on microblaze | expand

Commit Message

Giulio Benetti June 14, 2019, 9:03 p.m. UTC
keyutils has a !BR2_microblaze introduced by commit:
https://git.buildroot.net/buildroot/commit/?id=20e0926f4469a3486629cfd6fa7f449f2b659aa8
that points 2 possible build failures:
- "warning: dereferencing type-punned pointer will break strict-aliasing
  rules" treated as an error. But this warning is not treated as an
  error anymore since -Werror flag is not used after last version bumps
- glibc does not export the resolver symbols resulting in linking
  failure. But glibc used was version 2.3.6 that is not used anymore
  since. It's been released in 2005.

So re-enable package for Microblaze by removing 'depends on
!BR2_microblaze' from keyutils Config.in

Signed-off-by: Giulio Benetti <giulio.benetti@micronovasrl.com>
---
 package/keyutils/Config.in | 2 --
 1 file changed, 2 deletions(-)

Comments

Thomas Petazzoni June 19, 2019, 5:24 a.m. UTC | #1
On Fri, 14 Jun 2019 23:03:20 +0200
Giulio Benetti <giulio.benetti@micronovasrl.com> wrote:

> keyutils has a !BR2_microblaze introduced by commit:
> https://git.buildroot.net/buildroot/commit/?id=20e0926f4469a3486629cfd6fa7f449f2b659aa8
> that points 2 possible build failures:
> - "warning: dereferencing type-punned pointer will break strict-aliasing
>   rules" treated as an error. But this warning is not treated as an
>   error anymore since -Werror flag is not used after last version bumps
> - glibc does not export the resolver symbols resulting in linking
>   failure. But glibc used was version 2.3.6 that is not used anymore
>   since. It's been released in 2005.
> 
> So re-enable package for Microblaze by removing 'depends on
> !BR2_microblaze' from keyutils Config.in
> 
> Signed-off-by: Giulio Benetti <giulio.benetti@micronovasrl.com>
> ---
>  package/keyutils/Config.in | 2 --
>  1 file changed, 2 deletions(-)

Applied to master, thanks.

Thomas
diff mbox series

Patch

diff --git a/package/keyutils/Config.in b/package/keyutils/Config.in
index 6f0758f473..7813de3799 100644
--- a/package/keyutils/Config.in
+++ b/package/keyutils/Config.in
@@ -1,6 +1,5 @@ 
 config BR2_PACKAGE_KEYUTILS
 	bool "keyutils"
-	depends on !BR2_microblaze
 	depends on BR2_USE_MMU # fork()
 	depends on !BR2_STATIC_LIBS # dlopen
 	help
@@ -10,6 +9,5 @@  config BR2_PACKAGE_KEYUTILS
 	  http://people.redhat.com/~dhowells/keyutils/
 
 comment "keyutils needs a toolchain w/ dynamic library"
-	depends on !BR2_microblaze
 	depends on BR2_USE_MMU
 	depends on BR2_STATIC_LIBS