Patchwork [1/2] ext4: remove redundant argument in mb_find_extent()

login
register
mail settings
Submitter Robin Dong
Date Aug. 25, 2011, 11:36 a.m.
Message ID <1314272192-7414-1-git-send-email-hao.bigrat@gmail.com>
Download mbox | patch
Permalink /patch/111549/
State Superseded
Headers show

Comments

Robin Dong - Aug. 25, 2011, 11:36 a.m.
From: Ronbin Dong <sanbai@taobao.com>

The argument of "ord" in mb_find_extent is not necessary anymore.

Signed-off-by: Robin Dong <sanbai@taobao.com>
---
 fs/ext4/mballoc.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)
Andreas Dilger - Aug. 25, 2011, 4:28 p.m.
On 2011-08-25, at 5:36 AM, Robin Dong wrote:
> From: Ronbin Dong <sanbai@taobao.com>
> 
> The argument of "ord" in mb_find_extent is not necessary anymore.
> 
> Signed-off-by: Robin Dong <sanbai@taobao.com>
> ---
> fs/ext4/mballoc.c |    3 +--
> 1 files changed, 1 insertions(+), 2 deletions(-)

This patch doesn't remove the declaration "int ord;" at the start of the function.

> diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c
> index 17a5a57..0702627 100644
> --- a/fs/ext4/mballoc.c
> +++ b/fs/ext4/mballoc.c
> @@ -1432,9 +1432,8 @@ static int mb_find_extent(struct ext4_buddy *e4b, int order, int block,
> 		if (mb_test_bit(next, EXT4_MB_BITMAP(e4b)))
> 			break;
> 
> -		ord = mb_find_order_for_block(e4b, next);
> +		order = mb_find_order_for_block(e4b, next);
> 
> -		order = ord;
> 		block = next >> order;
> 		ex->fe_len += 1 << order;
> 	}
> -- 
> 1.7.4.1

Cheers, Andreas





--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c
index 17a5a57..0702627 100644
--- a/fs/ext4/mballoc.c
+++ b/fs/ext4/mballoc.c
@@ -1432,9 +1432,8 @@  static int mb_find_extent(struct ext4_buddy *e4b, int order, int block,
 		if (mb_test_bit(next, EXT4_MB_BITMAP(e4b)))
 			break;
 
-		ord = mb_find_order_for_block(e4b, next);
+		order = mb_find_order_for_block(e4b, next);
 
-		order = ord;
 		block = next >> order;
 		ex->fe_len += 1 << order;
 	}