Patchwork [2/2] disasm: update comment

login
register
mail settings
Submitter Stefan Hajnoczi
Date Aug. 25, 2011, 8:44 a.m.
Message ID <1314261865-11188-3-git-send-email-stefanha@linux.vnet.ibm.com>
Download mbox | patch
Permalink /patch/111522/
State New
Headers show

Comments

Stefan Hajnoczi - Aug. 25, 2011, 8:44 a.m.
From: Frediano Ziglio <freddy77@gmail.com>

Signed-off-by: Frediano Ziglio <freddy77@gmail.com>
Signed-off-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
---
 disas.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Peter Maydell - Aug. 25, 2011, 9:36 a.m.
On 25 August 2011 09:44, Stefan Hajnoczi <stefanha@linux.vnet.ibm.com> wrote:
>  /* Disassemble this for me please... (debugging). 'flags' has the following
>    values:
> -    i386 - nonzero means 16 bit code
> +    i386 - 1 means 16 bit code, 2 means 64 bit code

...presumably 0 means 32 bit code, by elimination ?

-- PMM
Frediano Ziglio - Aug. 25, 2011, 9:42 a.m.
2011/8/25 Peter Maydell <peter.maydell@linaro.org>:
> On 25 August 2011 09:44, Stefan Hajnoczi <stefanha@linux.vnet.ibm.com> wrote:
>>  /* Disassemble this for me please... (debugging). 'flags' has the following
>>    values:
>> -    i386 - nonzero means 16 bit code
>> +    i386 - 1 means 16 bit code, 2 means 64 bit code
>
> ...presumably 0 means 32 bit code, by elimination ?
>
> -- PMM
>

Currently you can pass even 10 :)
Yes, 0 (default) means 32 bit.

Frediano

Patch

diff --git a/disas.c b/disas.c
index 1334b8e..611b30b 100644
--- a/disas.c
+++ b/disas.c
@@ -137,7 +137,7 @@  print_insn_thumb1(bfd_vma pc, disassemble_info *info)
 
 /* Disassemble this for me please... (debugging). 'flags' has the following
    values:
-    i386 - nonzero means 16 bit code
+    i386 - 1 means 16 bit code, 2 means 64 bit code
     arm  - nonzero means thumb code
     ppc  - nonzero means little endian
     other targets - unused