[net-next] net: phy: Add more 1000BaseX support detection
diff mbox series

Message ID 1560290769-11858-1-git-send-email-hancock@sedsystems.ca
State Accepted
Delegated to: David Miller
Headers show
Series
  • [net-next] net: phy: Add more 1000BaseX support detection
Related show

Commit Message

Robert Hancock June 11, 2019, 10:06 p.m. UTC
Commit "net: phy: Add detection of 1000BaseX link mode support" added
support for not filtering out 1000BaseX mode from the PHY's supported
modes in genphy_config_init, but we have to make a similar change in
genphy_read_abilities in order to actually detect it as a supported mode
in the first place. Add this in.

Signed-off-by: Robert Hancock <hancock@sedsystems.ca>
---
 drivers/net/phy/phy_device.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Florian Fainelli June 11, 2019, 10:55 p.m. UTC | #1
On 6/11/19 3:06 PM, Robert Hancock wrote:
> Commit "net: phy: Add detection of 1000BaseX link mode support" added
> support for not filtering out 1000BaseX mode from the PHY's supported
> modes in genphy_config_init, but we have to make a similar change in
> genphy_read_abilities in order to actually detect it as a supported mode
> in the first place. Add this in.
> 
> Signed-off-by: Robert Hancock <hancock@sedsystems.ca>

Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
David Miller June 15, 2019, 1:47 a.m. UTC | #2
From: Robert Hancock <hancock@sedsystems.ca>
Date: Tue, 11 Jun 2019 16:06:09 -0600

> Commit "net: phy: Add detection of 1000BaseX link mode support" added
> support for not filtering out 1000BaseX mode from the PHY's supported
> modes in genphy_config_init, but we have to make a similar change in
> genphy_read_abilities in order to actually detect it as a supported mode
> in the first place. Add this in.
> 
> Signed-off-by: Robert Hancock <hancock@sedsystems.ca>

Applied.

Patch
diff mbox series

diff --git a/drivers/net/phy/phy_device.c b/drivers/net/phy/phy_device.c
index 03c885e..5387890 100644
--- a/drivers/net/phy/phy_device.c
+++ b/drivers/net/phy/phy_device.c
@@ -1984,6 +1984,8 @@  int genphy_read_abilities(struct phy_device *phydev)
 				 phydev->supported, val & ESTATUS_1000_TFULL);
 		linkmode_mod_bit(ETHTOOL_LINK_MODE_1000baseT_Half_BIT,
 				 phydev->supported, val & ESTATUS_1000_THALF);
+		linkmode_mod_bit(ETHTOOL_LINK_MODE_1000baseX_Full_BIT,
+				 phydev->supported, val & ESTATUS_1000_XFULL);
 	}
 
 	return 0;