Patchwork [v2,08/22] sysbus: add sysbus_add_memory_overlap()

login
register
mail settings
Submitter Avi Kivity
Date Aug. 24, 2011, 1:40 p.m.
Message ID <1314193259-27092-9-git-send-email-avi@redhat.com>
Download mbox | patch
Permalink /patch/111353/
State New
Headers show

Comments

Avi Kivity - Aug. 24, 2011, 1:40 p.m.
Signed-off-by: Avi Kivity <avi@redhat.com>
---
 hw/sysbus.c |    6 ++++++
 hw/sysbus.h |    2 ++
 2 files changed, 8 insertions(+), 0 deletions(-)
Richard Henderson - Aug. 24, 2011, 5 p.m.
On 08/24/2011 03:40 AM, Avi Kivity wrote:
> +void sysbus_add_memory_overlap(SysBusDevice *dev, target_phys_addr_t addr,
> +                               MemoryRegion *mem, unsigned priority)
> +{
> +    memory_region_add_subregion(get_system_memory(), addr, mem);
> +}
> +

memory_region_add_subregion_overlap, with "priority" actually used, surely?


r~
Avi Kivity - Aug. 24, 2011, 5:11 p.m.
On 08/24/2011 08:00 PM, Richard Henderson wrote:
> On 08/24/2011 03:40 AM, Avi Kivity wrote:
> >  +void sysbus_add_memory_overlap(SysBusDevice *dev, target_phys_addr_t addr,
> >  +                               MemoryRegion *mem, unsigned priority)
> >  +{
> >  +    memory_region_add_subregion(get_system_memory(), addr, mem);
> >  +}
> >  +
>
> memory_region_add_subregion_overlap, with "priority" actually used, surely?
>
>

Shirley can't write any code.  I'll fix it up.

Patch

diff --git a/hw/sysbus.c b/hw/sysbus.c
index f5f0ed2..4efb91a 100644
--- a/hw/sysbus.c
+++ b/hw/sysbus.c
@@ -263,6 +263,12 @@  void sysbus_add_memory(SysBusDevice *dev, target_phys_addr_t addr,
     memory_region_add_subregion(get_system_memory(), addr, mem);
 }
 
+void sysbus_add_memory_overlap(SysBusDevice *dev, target_phys_addr_t addr,
+                               MemoryRegion *mem, unsigned priority)
+{
+    memory_region_add_subregion(get_system_memory(), addr, mem);
+}
+
 void sysbus_del_memory(SysBusDevice *dev, MemoryRegion *mem)
 {
     memory_region_del_subregion(get_system_memory(), mem);
diff --git a/hw/sysbus.h b/hw/sysbus.h
index e4d56cf..b3e1f99 100644
--- a/hw/sysbus.h
+++ b/hw/sysbus.h
@@ -59,6 +59,8 @@  void sysbus_connect_irq(SysBusDevice *dev, int n, qemu_irq irq);
 void sysbus_mmio_map(SysBusDevice *dev, int n, target_phys_addr_t addr);
 void sysbus_add_memory(SysBusDevice *dev, target_phys_addr_t addr,
                        MemoryRegion *mem);
+void sysbus_add_memory_overlap(SysBusDevice *dev, target_phys_addr_t addr,
+                               MemoryRegion *mem, unsigned priority);
 void sysbus_del_memory(SysBusDevice *dev, MemoryRegion *mem);
 void sysbus_add_io(SysBusDevice *dev, target_phys_addr_t addr,
                    MemoryRegion *mem);