Patchwork [google] Remove timestamped line from gengtype state file comment headers

login
register
mail settings
Submitter Simon Baldwin
Date Aug. 23, 2011, 12:36 p.m.
Message ID <20110823123633.DEAAF1DA1D3@topo.tor.corp.google.com>
Download mbox | patch
Permalink /patch/111083/
State New
Headers show

Comments

Simon Baldwin - Aug. 23, 2011, 12:36 p.m.
Remove the timestamped line from gengtype state file comment headers.

Gcc builds after r177358 include a file .../plugin/gtype.state as part of
their binary installation.  The file contains a comment line that includes
the current date and time.  Variations in the file contents due to only
changes in the timestamp can be an issue for build and packaging systems
that prefer or insist on binary compatibility.

This patch removes the comment line, to provide binary reproducibility for
any generated gtype.state files.

Tested for x86 and PowerPC, no bootstrap in both cases.

OK for google/integration?  Also, OK for trunk?

libstdc++-v3/ChangeLog:
2011-05-20  Simon Baldwin  <simonb@google.com>

	* scripts/extract_symvers.in: Handle processor/OS specific or
	unknown symbol binding strings from readelf.
Richard Guenther - Aug. 23, 2011, 12:37 p.m.
On Tue, Aug 23, 2011 at 2:36 PM, Simon Baldwin <simonb@google.com> wrote:
> Remove the timestamped line from gengtype state file comment headers.
>
> Gcc builds after r177358 include a file .../plugin/gtype.state as part of
> their binary installation.  The file contains a comment line that includes
> the current date and time.  Variations in the file contents due to only
> changes in the timestamp can be an issue for build and packaging systems
> that prefer or insist on binary compatibility.
>
> This patch removes the comment line, to provide binary reproducibility for
> any generated gtype.state files.
>
> Tested for x86 and PowerPC, no bootstrap in both cases.
>
> OK for google/integration?  Also, OK for trunk?

Ok for trunk.

Richard.

> libstdc++-v3/ChangeLog:
> 2011-05-20  Simon Baldwin  <simonb@google.com>
>
>        * scripts/extract_symvers.in: Handle processor/OS specific or
>        unknown symbol binding strings from readelf.
>
>
> Index: gcc/gengtype-state.c
> ===================================================================
> --- gcc/gengtype-state.c        (revision 177984)
> +++ gcc/gengtype-state.c        (working copy)
> @@ -1194,8 +1194,6 @@ write_state (const char *state_path)
>   fprintf (state_file,
>           ";;; This file should be parsed by the same %s which wrote it.\n",
>           progname);
> -  fprintf (state_file, ";;; file %s generated on %s\n", state_path,
> -          ctime (&now));
>   /* The first non-comment significant line gives the version string.  */
>   write_state_version (version_string);
>   write_state_srcdir ();
>
Michael Matz - Aug. 23, 2011, 1:34 p.m.
Hi,

On Tue, 23 Aug 2011, Richard Guenther wrote:

> > This patch removes the comment line, to provide binary reproducibility for
> > any generated gtype.state files.
> >
> > Tested for x86 and PowerPC, no bootstrap in both cases.
> >
> > OK for google/integration?  Also, OK for trunk?
> 
> Ok for trunk.

But perhaps with a different ChangeLog entry :)

> > libstdc++-v3/ChangeLog:
> > 2011-05-20  Simon Baldwin  <simonb@google.com>
> >
> >        * scripts/extract_symvers.in: Handle processor/OS specific or
> >        unknown symbol binding strings from readelf.


Ciao,
Michael.

Patch

Index: gcc/gengtype-state.c
===================================================================
--- gcc/gengtype-state.c	(revision 177984)
+++ gcc/gengtype-state.c	(working copy)
@@ -1194,8 +1194,6 @@  write_state (const char *state_path)
   fprintf (state_file,
 	   ";;; This file should be parsed by the same %s which wrote it.\n",
 	   progname);
-  fprintf (state_file, ";;; file %s generated on %s\n", state_path,
-	   ctime (&now));
   /* The first non-comment significant line gives the version string.  */
   write_state_version (version_string);
   write_state_srcdir ();