From patchwork Wed Jun 5 18:09:14 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alex Hung X-Patchwork-Id: 1110630 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.ubuntu.com (client-ip=91.189.94.19; helo=huckleberry.canonical.com; envelope-from=fwts-devel-bounces@lists.ubuntu.com; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=canonical.com Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 45JxdF2c4jz9s9y; Thu, 6 Jun 2019 04:09:21 +1000 (AEST) Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.86_2) (envelope-from ) id 1hYaLe-0004FG-Nb; Wed, 05 Jun 2019 18:09:18 +0000 Received: from youngberry.canonical.com ([91.189.89.112]) by huckleberry.canonical.com with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.86_2) (envelope-from ) id 1hYaLd-0004FA-N5 for fwts-devel@lists.ubuntu.com; Wed, 05 Jun 2019 18:09:17 +0000 Received: from 1.general.alexhung.us.vpn ([10.172.65.254] helo=canonical.com) by youngberry.canonical.com with esmtpsa (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.76) (envelope-from ) id 1hYaLc-0003oD-Vy; Wed, 05 Jun 2019 18:09:17 +0000 From: Alex Hung To: fwts-devel@lists.ubuntu.com Subject: [PATCH] apic: apicedge: remove irq < 16 is edge only Date: Wed, 5 Jun 2019 11:09:14 -0700 Message-Id: <20190605180914.9296-1-alex.hung@canonical.com> X-Mailer: git-send-email 2.17.1 X-BeenThere: fwts-devel@lists.ubuntu.com X-Mailman-Version: 2.1.20 Precedence: list List-Id: Firmware Test Suite Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: fwts-devel-bounces@lists.ubuntu.com Sender: "fwts-devel" The original legacy PIC 8259 supports edge-trigger only but later 8259A supports both edge- and level-trigger. This limitation, of course, no longer exists today. Buglink: https://bugs.launchpad.net/bugs/1831035 Signed-off-by: Alex Hung Acked-by: Colin Ian King Acked-by: Ivan Hu --- src/apic/apicedge/apicedge.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/src/apic/apicedge/apicedge.c b/src/apic/apicedge/apicedge.c index 9f90fc5c..4abf011b 100644 --- a/src/apic/apicedge/apicedge.c +++ b/src/apic/apicedge/apicedge.c @@ -37,7 +37,7 @@ /* * This test sanity checks apic irq information * rule of thumb: - * interrupts <16 should be EDGE + * interrupts <16 should be EDGE or LEVEL * interrupts >16 should be LEVEL * acpi interrupt should be LEVEL */ @@ -86,10 +86,7 @@ static int apicedge_test1(fwts_framework *fw) "ACPI Interrupt is incorrectly edge triggered."); continue; } - if ((irq < 15) && (edge == NOT_EDGE)) - fwts_failed(fw, LOG_LEVEL_MEDIUM, - "LegacyIRQLevelTrig", - "Legacy interrupt %i is incorrectly level triggered.", irq); + if ((irq < 15) && (edge == UNDEFINED)) fwts_failed(fw, LOG_LEVEL_MEDIUM, "NonLegacyIRQLevelTrig",