Patchwork [i386] : Use AVX FP instructions in libgcc soft-fp exception handler

login
register
mail settings
Submitter Uros Bizjak
Date Aug. 22, 2011, 11:13 p.m.
Message ID <CAFULd4awQyCMDOGSyQL0rtqx9uqPhd2MUCOT+ECi9AjoKbAqiw@mail.gmail.com>
Download mbox | patch
Permalink /patch/111023/
State New
Headers show

Comments

Uros Bizjak - Aug. 22, 2011, 11:13 p.m.
Hello!

2011-08-23  Uros Bizjak  <ubizjak@gmail.com>

	* config/i386/64/sfp-machine.h (ASM_INVALID): New define.
	(ASM_DIVZERO): Ditto.
	(FP_HANLDE_EXCEPTIONS): Use ASM_INVALID and ASM_DIVZERO.

Tested on x86_64-pc-linux-gnu {,-m32}. Committed to mainline SVN, will
be backported to release branches.

Uros.
Joseph S. Myers - Aug. 24, 2011, 10:54 a.m.
On Tue, 23 Aug 2011, Uros Bizjak wrote:

> Hello!
> 
> 2011-08-23  Uros Bizjak  <ubizjak@gmail.com>
> 
> 	* config/i386/64/sfp-machine.h (ASM_INVALID): New define.
> 	(ASM_DIVZERO): Ditto.
> 	(FP_HANLDE_EXCEPTIONS): Use ASM_INVALID and ASM_DIVZERO.
> 
> Tested on x86_64-pc-linux-gnu {,-m32}. Committed to mainline SVN, will
> be backported to release branches.

The 4.5 and 4.4 commits (r178009 and r178010) appear to include spurious 
changes to libgcc/config.host.
Uros Bizjak - Aug. 24, 2011, 6:06 p.m.
On Wed, Aug 24, 2011 at 12:54 PM, Joseph S. Myers
<joseph@codesourcery.com> wrote:
> On Tue, 23 Aug 2011, Uros Bizjak wrote:

>> 2011-08-23  Uros Bizjak  <ubizjak@gmail.com>
>>
>>       * config/i386/64/sfp-machine.h (ASM_INVALID): New define.
>>       (ASM_DIVZERO): Ditto.
>>       (FP_HANLDE_EXCEPTIONS): Use ASM_INVALID and ASM_DIVZERO.
>>
>> Tested on x86_64-pc-linux-gnu {,-m32}. Committed to mainline SVN, will
>> be backported to release branches.
>
> The 4.5 and 4.4 commits (r178009 and r178010) appear to include spurious
> changes to libgcc/config.host.

Thanks for noticing! Unwanted changes have been removed from both branches.

Uros.

Patch

Index: config/i386/64/sfp-machine.h
===================================================================
--- config/i386/64/sfp-machine.h	(revision 177972)
+++ config/i386/64/sfp-machine.h	(working copy)
@@ -73,17 +73,25 @@ 
   unsigned short int __unused5;
 };
 
+#ifdef __AVX__
+ #define ASM_INVALID "vdivss %0, %0, %0"
+ #define ASM_DIVZERO "vdivss %1, %0, %0"
+#else
+ #define ASM_INVALID "divss %0, %0"
+ #define ASM_DIVZERO "divss %1, %0"
+#endif
+
 #define FP_HANDLE_EXCEPTIONS						\
   do {									\
     if (_fex & FP_EX_INVALID)						\
       {									\
 	float f = 0.0;							\
-	__asm__ __volatile__ ("divss %0, %0 " : : "x" (f));		\
+	__asm__ __volatile__ (ASM_INVALID : : "x" (f));			\
       }									\
     if (_fex & FP_EX_DIVZERO)						\
       {									\
 	float f = 1.0, g = 0.0;						\
-	__asm__ __volatile__ ("divss %1, %0" : : "x" (f), "x" (g));	\
+	__asm__ __volatile__ (ASM_DIVZERO : : "x" (f), "x" (g));	\
       }									\
     if (_fex & FP_EX_OVERFLOW)						\
       {									\