From patchwork Tue Jun 4 15:09:13 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: 'Darko Komljenovic' via swupdate X-Patchwork-Id: 1109967 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=googlegroups.com (client-ip=2a00:1450:4864:20::537; helo=mail-ed1-x537.google.com; envelope-from=swupdate+bncbc6ynavgsakrbnmt3ltqkgqefvcv36y@googlegroups.com; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=googlegroups.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=googlegroups.com header.i=@googlegroups.com header.b="cNFSuGul"; dkim-atps=neutral Received: from mail-ed1-x537.google.com (mail-ed1-x537.google.com [IPv6:2a00:1450:4864:20::537]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 45JFhV6zVBz9s3l for ; Wed, 5 Jun 2019 01:09:45 +1000 (AEST) Received: by mail-ed1-x537.google.com with SMTP id e21sf805529edr.18 for ; Tue, 04 Jun 2019 08:09:45 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1559660981; cv=pass; d=google.com; s=arc-20160816; b=GFMg1Bsqwu96Rwe6Jd5ADHVvu4ElUVBTQ3EqOx2tkMFlvyc1nPHzD6BkIEOteCE98F KaZ8wq2JB/KZ8IA0sfyS32n+/7ZNoX5X4XRWTVdRPkvS6R8VG+fH49LDzE+Mww54yfea i6xDmFUIUeUsEU6Cgy/9k6RYUf2okMPSR/F1era9XVbqRyDETGCrorxXoDAOiQSGGtkx Fvqp2PRf4npv8BT8PjxQlF3BTw8H7AKa/0a3sMnaN5v0RN06rXmwV+8CVkUIrjcEu2mh lDeu1Wj1CPj9mIGFVwpY36Z1ZpFcFZyxlGU0JWoQ/TtI9c90OnRHeVYYu2iFwSfdSC9Q 6VOg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:reply-to:mime-version:message-id :date:subject:cc:to:from:dkim-signature; bh=2VsiLw0ROpspZ7CQCkJLtr3oND8XxLje9QT81jFn/K0=; b=FK9acBmnmSJN1KsnEfFyaeTS0ytCY4rPCGdSyraHT3n+Qj92Bx92OpOQ7edreCa603 SuMdUfm3lPzn4wPYXM+pHrOKpzu8JexkOb4PxicwPFmOtusAgJ3seyGv5MdXLQD3dyMi EzZDMn62XOtF8McwVXT6ROON81x+/mVTHt+loDojcpR8pEfDtJKBu0Jps/mfBiIC32U0 pPhDhQONp5Ak4sZ8eScxaM98R8SlQHjUFBT6UUuUQgwx8Xlsz3zUotMuKRgu7jw9SqY+ spDOjIWg1IovA/ppQPh880e88lFFDwrYXrJkguqSfGjr/1DJFkFwWoARl5VCeVt+T1/D 7Pgw== ARC-Authentication-Results: i=2; gmr-mx.google.com; dkim=pass header.i=@de.bosch.com header.s=2015-01-21 header.b=USlj5eK9; spf=pass (google.com: domain of mark.jonas@de.bosch.com designates 139.15.230.186 as permitted sender) smtp.mailfrom=Mark.Jonas@de.bosch.com; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=de.bosch.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version:x-original-sender :x-original-authentication-results:reply-to:precedence:mailing-list :list-id:list-post:list-help:list-archive:list-subscribe :list-unsubscribe; bh=2VsiLw0ROpspZ7CQCkJLtr3oND8XxLje9QT81jFn/K0=; b=cNFSuGulhFbh9EiVZ+Ex9mI9yhrUQ0vqpVFwaJx+8jjVoaqedMrHqRW0sHyaZ7o6B3 KF0mApyPgMP49G/6jjFQy001B3nLZpbB3DYt6WCrwNgoxMy3VGcdpV4qhWn+jtcPp8aP /IOYQAph+RNtni1KwyMKcF2mUeekzLj2SITDpUubLkr/HArNKEjFl11g2hmr/EjpaxWA 7SberCLVfPdkfziEZ4XajJl+mULukoFzu6IdhYlCPjev/JzYXZnG9VlMZKx7G9JbM8dD gp/TDFM3A/BYOBnJsX7zAmmU2pBEw/qXd0t8DCHADgZfQ/b0wXPzwnEa+YfCnrOTeJkU ApiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :x-original-sender:x-original-authentication-results:reply-to :precedence:mailing-list:list-id:x-spam-checked-in-group:list-post :list-help:list-archive:list-subscribe:list-unsubscribe; bh=2VsiLw0ROpspZ7CQCkJLtr3oND8XxLje9QT81jFn/K0=; b=VbjFlQG2f0X03dH0+hd00yYKkSw4o2bftwhu4s4Ic0SxaFu615wIRlPTl/4YUiSPYY CZqq2mDxSqXcV4B6NrmWbHCfOrcIsZ/oj6gG/j9evl/IBp5g4T2x8cO86SttU7wWJpdJ S556ef7zMFFN+9fk2T4zsXHfhPjTMC/0wR4UEsP+2q1NP7jUKwFwfGSNe9FGnqddFHFQ QTrN8XRLmdLfAMgiHmDun0o2XYh3Hhx4VIvlYzYleSI5mNmXZ/SODfm5cwuETYyiWpAF iKAA9kIJkSdHJEW1KcYHQ2skhkI3LpECPo8yrO/M5Swxn/bSy7sgqJcW+KAojIkhp1Kh bMag== X-Gm-Message-State: APjAAAWvp80DEZWLWCDwOAT2iNy8br1ixhZizXk6HxZr2nQLKtcy8ilB WI+DK1egXmbt0gLRW9oNVzI= X-Google-Smtp-Source: APXvYqxOlvrrle7DPps4MNOwQJtE5HsElFOvjsJWM13rDpS4sRStNbzG7FmFcVuOhOBtNJCkQEsQBw== X-Received: by 2002:a17:906:3e92:: with SMTP id a18mr13459765ejj.170.1559660981504; Tue, 04 Jun 2019 08:09:41 -0700 (PDT) X-BeenThere: swupdate@googlegroups.com Received: by 2002:a50:cac7:: with SMTP id f7ls2692813edi.4.gmail; Tue, 04 Jun 2019 08:09:41 -0700 (PDT) X-Received: by 2002:a50:b3a4:: with SMTP id s33mr36411285edd.112.1559660980995; Tue, 04 Jun 2019 08:09:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1559660980; cv=none; d=google.com; s=arc-20160816; b=qW/KlfuQAZWeyrmi+3s5tmzLASww+DqG3HwPVOBCZ2/a23434rE9i9Fs6FF4wK9RrV 8NownLd52Lro/Pzrnh7AVSPfsI3PJe3Toz9KmJ2QunTY/LKI9vsH8S+mHYDn/Ee3ncIR mHacy4Y3n7RvPqHiJ3rRVRCgMw28pxjMu6ufLO7WOjR3tr04oK2DPGytkgsf7ERHhVlY LAmHxgB/UW1cSmRwArGrk61f2vveKw2zZ/16NPsuMUF+N8H2z6D8jUdsg/hcxEyJADrC UdELlZnK2Eceqm5/75oYz6CH6r//8D0sZ1+WSBd8AIrHG96VdwYSl5kFOz5xh64znHVM RHcg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:message-id:date:subject:cc:to:from:dkim-signature; bh=ualKywvfALDF6UNgElXdterYhJXrJtArS7Jcm5O5naw=; b=tWsIwfiCpPjBG6Z68/wOzukfUGBnbiX3ifP/Uf2g0y6G1HeQ6bSiOzInoY2NRncUJt dp7blHTTJSvMR4ehiKPOyshDgZxa+DN7a+452u83YJgvvLs6OoezNg+g70ehSsiK5tvN Ltx+lbGDgvD/gUjJ6QPHxztOlssFcJHODQZ9olWTFN6gnjIYgc8Tx1TFHxSqo6Ah621P 6uW0m0piz7qhXSYWDRMY+lqkD06Toq8WiW/fPK7Xr73DzfatPan7qbUTfJ6dcNMyA6x6 FANv5jcAPCTP+7NXan9kuaDDHD2F3AvDOdt9UY/1s8dnntsZStN6Nn+Mfu1eZglTOr7N VpiQ== ARC-Authentication-Results: i=1; gmr-mx.google.com; dkim=pass header.i=@de.bosch.com header.s=2015-01-21 header.b=USlj5eK9; spf=pass (google.com: domain of mark.jonas@de.bosch.com designates 139.15.230.186 as permitted sender) smtp.mailfrom=Mark.Jonas@de.bosch.com; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=de.bosch.com Received: from de-out1.bosch-org.com (de-out1.bosch-org.com. [139.15.230.186]) by gmr-mx.google.com with ESMTPS id t36si542833edb.0.2019.06.04.08.09.40 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 04 Jun 2019 08:09:40 -0700 (PDT) Received-SPF: pass (google.com: domain of mark.jonas@de.bosch.com designates 139.15.230.186 as permitted sender) client-ip=139.15.230.186; Received: from fe0vm1649.rbesz01.com (unknown [139.15.230.188]) by si0vms0217.rbdmz01.com (Postfix) with ESMTPS id 45JFhN4Gckz4f3kZf; Tue, 4 Jun 2019 17:09:40 +0200 (CEST) Received: from si0vm02576.rbesz01.com (unknown [10.58.172.176]) by fe0vm1649.rbesz01.com (Postfix) with ESMTPS id 45JFhN3Nkwz2J; Tue, 4 Jun 2019 17:09:40 +0200 (CEST) X-AuditID: 0a3aad0d-173ff700000036fe-15-5cf689b4fc0d Received: from si0vm1950.rbesz01.com ( [10.58.173.29]) (using TLS with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by si0vm02576.rbesz01.com (SMG Outbound) with SMTP id 85.30.14078.4B986FC5; Tue, 4 Jun 2019 17:09:40 +0200 (CEST) Received: from FE-HUB2000.de.bosch.com (fe-hub2000.de.bosch.com [10.4.103.109]) by si0vm1950.rbesz01.com (Postfix) with ESMTPS id 45JFhN1sG2z5fX; Tue, 4 Jun 2019 17:09:40 +0200 (CEST) Received: from luchador.grb-fir.grb.de.bosch.com (10.19.187.97) by FE-HUB2000.de.bosch.com (10.4.103.109) with Microsoft SMTP Server id 15.1.1713.5; Tue, 4 Jun 2019 17:09:40 +0200 X-Patchwork-Original-From: "'Mark Jonas' via swupdate" From: 'Darko Komljenovic' via swupdate To: CC: , , Mark Jonas Subject: [swupdate] [PATCH] Fix deserialization of bool with libconfig Date: Tue, 4 Jun 2019 17:09:13 +0200 Message-ID: <1559660953-17552-1-git-send-email-mark.jonas@de.bosch.com> X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 X-Brightmail-Tracker: H4sIAAAAAAAAA21Sa0wTWRjltlOYNlwdhqKfFQ2ZGI0SsaAsAusTH8SYYIwJrlsjg4xts7Ql M6UK8QdiIhRFQUWBXVCQRKGKQtxQlF26lRhQFrtZJBIlRjQLwfjGqvjamRRsf/jvfOfc8517 Ty4pp4tDNKTRbOV4M5vNBKsIVdKlOYuv2r067bP2iOVFtzYvP93+XrFallpb3U2kdpT3BG+R 7VD9mMVlG20cv2RlhsrgutkXktOi3Heg4gUqQAfJEkSSQC2D40O5JUhF0lSVDEp/HwnxDR0I bngPyUqQUhzaEPz7Si3hYGoRDHY75RJWU2roHR4IkbCc4qBu4olCwuFUMlx8+SxYwgQ1Dx5/ 7CQkjKmNcOxzP5IwUHNhsM8u9/Fh0FP1hPDtAfhrdFRehnB1gFQdIJ1FsiY0QzBqbSZtXHzC DzF8Jifka2NjdltMrcjXDXaiPu8eN6JIxITik2JPtIK1CXkmN4onZUwEXl8oUtMyLVl5BlYw 7OJzszmB0eBIzyYdHf6NFnIzTUZBMFrMbgSknFFj9v64jsZZbF4+x1t8NjeaTRLMTKwn03Q0 pWet3C8cl8PxU2oySTKAM4rEwDCe03P79hizrVMyMwejoKAgekagEhgrI5VutJQMFbNPSSuw kMOaBKN+0j7LZ6enWL/1Fkoh6x/+VyOnCbPFzGlm4sOSn5JOGnLN326gicTX6t7o6IgAwb9l DN1DYofhuLNYNIeKX9CfDXi2VFfYJOk3xTWIHqpRAa9dPIxX3EBQ63yLoLX8CgHlHo8CGs4c U0H9yAsMJ8ov0tB8vAygv/TPufDb0IkoaLE7oqC+6egCqK0eXgjdL98thHtVw9HwoOf5Yui9 0quFgfPFS+H6+c4EeHNuKBEK3/+xDuxddWnQ33gzDVoab2+DT+8qf4bbEx06ONx5fSc0/P1o J3z4p3kXfPEWGGCgqM0wJvYqE3tNu/9a6tXKWr/T6yTrf5ymAPEOx97C9jG1xubaO9hVNnTN nhqZcZVetx/xFzakT1C/ZsQZHLGJu5OOtNtG7zgSv2jb6sa1j0diSgfyI6klP61VP01Ov+vU l4QlpNTc3Z7TdHlNtHNHSk2Qy23pmnWO/Vjx9Y73c3TcilrgXZWeqE9bzfNX2ZKsntTpyvje ViVDCAY2dpGcF9j/AV30E8gbBAAA X-Original-Sender: mark.jonas@de.bosch.com X-Original-Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@de.bosch.com header.s=2015-01-21 header.b=USlj5eK9; spf=pass (google.com: domain of mark.jonas@de.bosch.com designates 139.15.230.186 as permitted sender) smtp.mailfrom=Mark.Jonas@de.bosch.com; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=de.bosch.com X-Original-From: Mark Jonas Reply-To: Mark Jonas Precedence: list Mailing-list: list swupdate@googlegroups.com; contact swupdate+owners@googlegroups.com List-ID: X-Spam-Checked-In-Group: swupdate@googlegroups.com X-Google-Group-Id: 605343134186 List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , bootloader_transaction_marker in struct swupdate_cfg (include/swupdate.h) is a bool. But the deserialization writes an int. This will taint the following structure element software_set[] if sizeof(int) > sizeof(bool). The problem was detected when adding bootloader_transaction_marker=false to a sw-description file on a NXP i.MX6 containing software collections. On a NXP i.MX6 sizeof(bool)==1 and sizeof(int)==4. Signed-off-by: Mark Jonas Tested-by: Leo Ruan --- corelib/parsing_library_libconfig.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/corelib/parsing_library_libconfig.c b/corelib/parsing_library_libconfig.c index 4cd3da2..42685c1 100644 --- a/corelib/parsing_library_libconfig.c +++ b/corelib/parsing_library_libconfig.c @@ -34,7 +34,7 @@ void get_value_libconfig(const config_setting_t *e, void *dest) dest = (void *)config_setting_get_string(e); break; case CONFIG_TYPE_BOOL: - *(int *)dest = config_setting_get_bool(e); + *(bool *)dest = config_setting_get_bool(e); break; case CONFIG_TYPE_FLOAT: *(double *)dest = config_setting_get_float(e);