| Message ID | 5c754d95-cd82-0399-1ae6-d35bc8c5be49@arm.com |
|---|---|
| State | New |
| Headers | show |
| Series | aarch64: fix asm visibility for extern symbols | expand |
On Tue, Jun 04, 2019 at 03:58:07PM +0100, Szabolcs Nagy wrote: > Commit r271869 broke visibility declarations in asm for extern symbols, because > the new ASM_OUTPUT_EXTERNAL hook failed to call the default hook for elf. OK. In future, you can consider a patch like this to fall under the "obvious" rule and commit it without review. Thanks, James > gcc/ChangeLog: > > 2019-06-04 Szabolcs Nagy <szabolcs.nagy@arm.com> > > * config/aarch64/aarch64-protos.h (aarch64_asm_output_external): Remove > const. > * config/aarch64/aarch64.c (aarch64_asm_output_external): Call > default_elf_asm_output_external. > diff --git a/gcc/config/aarch64/aarch64-protos.h b/gcc/config/aarch64/aarch64-protos.h > index 6dccabc8cf7..1e3b1c91db1 100644 > --- a/gcc/config/aarch64/aarch64-protos.h > +++ b/gcc/config/aarch64/aarch64-protos.h > @@ -437,7 +437,7 @@ bool aarch64_is_noplt_call_p (rtx); > bool aarch64_label_mentioned_p (rtx); > void aarch64_declare_function_name (FILE *, const char*, tree); > void aarch64_asm_output_alias (FILE *, const tree, const tree); > -void aarch64_asm_output_external (FILE *, const tree, const char*); > +void aarch64_asm_output_external (FILE *, tree, const char*); > bool aarch64_legitimate_pic_operand_p (rtx); > bool aarch64_mask_and_shift_for_ubfiz_p (scalar_int_mode, rtx, rtx); > bool aarch64_masks_and_shift_for_bfi_p (scalar_int_mode, unsigned HOST_WIDE_INT, > diff --git a/gcc/config/aarch64/aarch64.c b/gcc/config/aarch64/aarch64.c > index 263ed21442c..7acc3227a78 100644 > --- a/gcc/config/aarch64/aarch64.c > +++ b/gcc/config/aarch64/aarch64.c > @@ -15650,8 +15650,9 @@ aarch64_asm_output_alias (FILE *stream, const tree decl, const tree target) > function symbol references. */ > > void > -aarch64_asm_output_external (FILE *stream, const tree decl, const char* name) > +aarch64_asm_output_external (FILE *stream, tree decl, const char* name) > { > + default_elf_asm_output_external (stream, decl, name); > aarch64_asm_output_variant_pcs (stream, decl, name); > } >
diff --git a/gcc/config/aarch64/aarch64-protos.h b/gcc/config/aarch64/aarch64-protos.h index 6dccabc8cf7..1e3b1c91db1 100644 --- a/gcc/config/aarch64/aarch64-protos.h +++ b/gcc/config/aarch64/aarch64-protos.h @@ -437,7 +437,7 @@ bool aarch64_is_noplt_call_p (rtx); bool aarch64_label_mentioned_p (rtx); void aarch64_declare_function_name (FILE *, const char*, tree); void aarch64_asm_output_alias (FILE *, const tree, const tree); -void aarch64_asm_output_external (FILE *, const tree, const char*); +void aarch64_asm_output_external (FILE *, tree, const char*); bool aarch64_legitimate_pic_operand_p (rtx); bool aarch64_mask_and_shift_for_ubfiz_p (scalar_int_mode, rtx, rtx); bool aarch64_masks_and_shift_for_bfi_p (scalar_int_mode, unsigned HOST_WIDE_INT, diff --git a/gcc/config/aarch64/aarch64.c b/gcc/config/aarch64/aarch64.c index 263ed21442c..7acc3227a78 100644 --- a/gcc/config/aarch64/aarch64.c +++ b/gcc/config/aarch64/aarch64.c @@ -15650,8 +15650,9 @@ aarch64_asm_output_alias (FILE *stream, const tree decl, const tree target) function symbol references. */ void -aarch64_asm_output_external (FILE *stream, const tree decl, const char* name) +aarch64_asm_output_external (FILE *stream, tree decl, const char* name) { + default_elf_asm_output_external (stream, decl, name); aarch64_asm_output_variant_pcs (stream, decl, name); }