| Message ID | 20190603043251.226549-6-cychiang@chromium.org |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | Add HDMI audio support on RK3288 veyron board | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success |
On Mon, Jun 03, 2019 at 12:32:49PM +0800, Cheng-Yi Chiang wrote: > Let user specify HDMI node so machine driver can use it to let codec > driver register callback on correct hdmi-notifier. > > Signed-off-by: Cheng-Yi Chiang <cychiang@chromium.org> > --- > Documentation/devicetree/bindings/sound/rockchip-max98090.txt | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/sound/rockchip-max98090.txt b/Documentation/devicetree/bindings/sound/rockchip-max98090.txt > index a805aa99ad75..dae57c14864e 100644 > --- a/Documentation/devicetree/bindings/sound/rockchip-max98090.txt > +++ b/Documentation/devicetree/bindings/sound/rockchip-max98090.txt > @@ -7,6 +7,7 @@ Required properties: > connected to the CODEC > - rockchip,audio-codec: The phandle of the MAX98090 audio codec > - rockchip,headset-codec: The phandle of Ext chip for jack detection > +- rockchip,hdmi: The phandle of HDMI node for HDMI jack detection > > Example: > > @@ -16,4 +17,5 @@ sound { > rockchip,i2s-controller = <&i2s>; > rockchip,audio-codec = <&max98090>; > rockchip,headset-codec = <&headsetcodec>; > + rockchip,hdmi= <&hdmi>; space ^ With that, Acked-by: Rob Herring <robh@kernel.org> > }; > -- > 2.22.0.rc1.257.g3120a18244-goog >
On Wed, Jul 10, 2019 at 4:01 AM Rob Herring <robh@kernel.org> wrote: > > On Mon, Jun 03, 2019 at 12:32:49PM +0800, Cheng-Yi Chiang wrote: > > Let user specify HDMI node so machine driver can use it to let codec > > driver register callback on correct hdmi-notifier. > > > > Signed-off-by: Cheng-Yi Chiang <cychiang@chromium.org> > > --- > > Documentation/devicetree/bindings/sound/rockchip-max98090.txt | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/sound/rockchip-max98090.txt b/Documentation/devicetree/bindings/sound/rockchip-max98090.txt > > index a805aa99ad75..dae57c14864e 100644 > > --- a/Documentation/devicetree/bindings/sound/rockchip-max98090.txt > > +++ b/Documentation/devicetree/bindings/sound/rockchip-max98090.txt > > @@ -7,6 +7,7 @@ Required properties: > > connected to the CODEC > > - rockchip,audio-codec: The phandle of the MAX98090 audio codec > > - rockchip,headset-codec: The phandle of Ext chip for jack detection > > +- rockchip,hdmi: The phandle of HDMI node for HDMI jack detection > > > > Example: > > > > @@ -16,4 +17,5 @@ sound { > > rockchip,i2s-controller = <&i2s>; > > rockchip,audio-codec = <&max98090>; > > rockchip,headset-codec = <&headsetcodec>; > > + rockchip,hdmi= <&hdmi>; > > space ^ > > With that, > > Acked-by: Rob Herring <robh@kernel.org> > Hi Rob, Thank you for the review. But I have changed the approach in v2 so there is no need for machine driver to expose this property. Thanks! > > }; > > -- > > 2.22.0.rc1.257.g3120a18244-goog > >
diff --git a/Documentation/devicetree/bindings/sound/rockchip-max98090.txt b/Documentation/devicetree/bindings/sound/rockchip-max98090.txt index a805aa99ad75..dae57c14864e 100644 --- a/Documentation/devicetree/bindings/sound/rockchip-max98090.txt +++ b/Documentation/devicetree/bindings/sound/rockchip-max98090.txt @@ -7,6 +7,7 @@ Required properties: connected to the CODEC - rockchip,audio-codec: The phandle of the MAX98090 audio codec - rockchip,headset-codec: The phandle of Ext chip for jack detection +- rockchip,hdmi: The phandle of HDMI node for HDMI jack detection Example: @@ -16,4 +17,5 @@ sound { rockchip,i2s-controller = <&i2s>; rockchip,audio-codec = <&max98090>; rockchip,headset-codec = <&headsetcodec>; + rockchip,hdmi= <&hdmi>; };
Let user specify HDMI node so machine driver can use it to let codec driver register callback on correct hdmi-notifier. Signed-off-by: Cheng-Yi Chiang <cychiang@chromium.org> --- Documentation/devicetree/bindings/sound/rockchip-max98090.txt | 2 ++ 1 file changed, 2 insertions(+)