From patchwork Sat Jun 1 10:20:32 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fabrice Fontaine X-Patchwork-Id: 1108741 Return-Path: X-Original-To: incoming-buildroot@patchwork.ozlabs.org Delivered-To: patchwork-incoming-buildroot@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=busybox.net (client-ip=140.211.166.136; helo=silver.osuosl.org; envelope-from=buildroot-bounces@busybox.net; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="sOE+/fZB"; dkim-atps=neutral Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 45GHQQ67NDz9sNR for ; Sat, 1 Jun 2019 20:20:46 +1000 (AEST) Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id 0D77620033; Sat, 1 Jun 2019 10:20:44 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id GAvw8FZzsR8Y; Sat, 1 Jun 2019 10:20:42 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by silver.osuosl.org (Postfix) with ESMTP id A1BFE2047E; Sat, 1 Jun 2019 10:20:42 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by ash.osuosl.org (Postfix) with ESMTP id F3C171BF857 for ; Sat, 1 Jun 2019 10:20:40 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id EF5442047E for ; Sat, 1 Jun 2019 10:20:40 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id d1iQ+W0rRbno for ; Sat, 1 Jun 2019 10:20:39 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-wm1-f66.google.com (mail-wm1-f66.google.com [209.85.128.66]) by silver.osuosl.org (Postfix) with ESMTPS id 3E54020033 for ; Sat, 1 Jun 2019 10:20:39 +0000 (UTC) Received: by mail-wm1-f66.google.com with SMTP id w9so1013553wmd.1 for ; Sat, 01 Jun 2019 03:20:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=ock+oLcZF7h8+TJd8sVyDGGc/4KDvQTVXO433lacNOQ=; b=sOE+/fZBVHnoljEOT+pdAuTipJR/wixW+o+sSENG8YP/Zz0XvRMah25v6rWBDUWfKn c+H7rzz52QWGzUlf3ZwwlyHAIXgkHd4WWQfQ7kU05dTNcYK1DRmwqGiCd/6p62MA2okc 8taf1W7wYCq6gXXTr21aVa8KZuACLWerdJfmiijyyp2t38uik9i/ZWyq1QrpM1wNWIlt EQoSOUk3i37HYH3lwEhqyXu+QmfDkkYqydMkTtwVdaClEdQZWC9eBacqZvhQa4dRYC6m VwtQ7h4BufFd+PJoWW8SQ3iJvufyeiWH5ma+BBxPx2ZPdT1O/DukaZ0yE17dqqD5PHbO 91Wg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=ock+oLcZF7h8+TJd8sVyDGGc/4KDvQTVXO433lacNOQ=; b=drc7shTvoUhwoLj77Gf/kVzMdcLxJpVsSegTe/DbvgKFlidMVAUYbxSxsRguj0S98+ /VpzsA5/ADIa8xD6/Aj+ssbcAWT9RePBVlqKzYdcu1joNb4PxtpSAZYi2D5w9U10hKup q+aN6WmaGGxqHEMBsC87xq3f4NODj7DFMQ0yaXwG6BUGaXFoXH9AeLCppxHbigcu1Aig a8/hKi0+ieAwZUnhmwmVXmOiG49jC4DLI1kUBPgvp5F2FkRVBfMpKw+XbBVkzIqLfGmV Z7DHl4rTd3eQoZedobhYPIHzqs6WNmqIzWHZfHl23wXUwdJzZ1M8TKYPzxj9xZuMPLHl k0mQ== X-Gm-Message-State: APjAAAVSz4bIpKBD8njfMf/P9Gvs4DG4VwGj05AZMLt+nwAbFh3c27FJ FF1IW9qHOeC6BIzzNHS6pg4csEypJqc= X-Google-Smtp-Source: APXvYqzjM2aPk4zAi/v0MqLoTuWVrj2uqsYzKwNzDVw1Bz5jgUL5KLm3ES6cwq44t4qhH3RY3oV/1w== X-Received: by 2002:a1c:e718:: with SMTP id e24mr8529083wmh.104.1559384437399; Sat, 01 Jun 2019 03:20:37 -0700 (PDT) Received: from kali.home (lfbn-ren-1-314-196.w2-10.abo.wanadoo.fr. [2.10.15.196]) by smtp.gmail.com with ESMTPSA id j7sm18778801wrt.31.2019.06.01.03.20.35 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Sat, 01 Jun 2019 03:20:36 -0700 (PDT) From: Fabrice Fontaine To: buildroot@buildroot.org Date: Sat, 1 Jun 2019 12:20:32 +0200 Message-Id: <20190601102032.28968-1-fontaine.fabrice@gmail.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Subject: [Buildroot] [PATCH 1/1] package/opencv: fix build due to gcc bug 68485 X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Fabrice Fontaine Errors-To: buildroot-bounces@busybox.net Sender: "buildroot" With Microblaze Gcc version <= 9.x the build fails due to gcc bug 68485: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=68485. The bug show up when building opencv with optimization but not when building with -O0. To work around this, if BR2_TOOLCHAIN_HAS_GCC_BUG_68458=y, we force using -O0. Fixes: - http://autobuild.buildroot.org/results/17fff0f312ebd520ba3341976ba56fd8c85ee376 Signed-off-by: Fabrice Fontaine Reviewed-by: Giulio Benetti --- package/opencv/opencv.mk | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/package/opencv/opencv.mk b/package/opencv/opencv.mk index ccc2d820da..4c15075fe0 100644 --- a/package/opencv/opencv.mk +++ b/package/opencv/opencv.mk @@ -10,6 +10,7 @@ OPENCV_INSTALL_STAGING = YES OPENCV_LICENSE = BSD-3-Clause OPENCV_LICENSE_FILES = LICENSE OPENCV_SUPPORTS_IN_SOURCE_BUILD = NO +OPENCV_CXXFLAGS = $(TARGET_CXXFLAGS) # OpenCV component options OPENCV_CONF_OPTS += \ @@ -166,6 +167,10 @@ OPENCV_CONF_OPTS += \ OPENCV_DEPENDENCIES += zlib +ifeq ($(BR2_TOOLCHAIN_HAS_GCC_BUG_68485),y) +OPENCV_CXXFLAGS += -O0 +endif + ifeq ($(BR2_PACKAGE_OPENCV_WITH_FFMPEG),y) OPENCV_CONF_OPTS += -DWITH_FFMPEG=ON OPENCV_DEPENDENCIES += ffmpeg bzip2 @@ -195,8 +200,8 @@ OPENCV_CONF_OPTS += -DWITH_GTK=OFF endif ifeq ($(BR2_PACKAGE_OPENCV_WITH_JASPER),y) -OPENCV_CONF_OPTS += -DWITH_JASPER=ON \ - -DCMAKE_CXX_FLAGS="$(TARGET_CXXFLAGS) -D__STDC_LIMIT_MACROS" +OPENCV_CONF_OPTS += -DWITH_JASPER=ON +OPENCV_CXXFLAGS += -D__STDC_LIMIT_MACROS OPENCV_DEPENDENCIES += jasper else OPENCV_CONF_OPTS += -DWITH_JASPER=OFF @@ -232,6 +237,8 @@ else OPENCV_CONF_OPTS += -DWITH_V4L=OFF -DWITH_LIBV4L=OFF endif +OPENCV_CONF_OPTS += -DCMAKE_CXX_FLAGS="$(OPENCV_CXXFLAGS)" + # Installation hooks: define OPENCV_CLEAN_INSTALL_DOC $(RM) -fr $(TARGET_DIR)/usr/share/OpenCV/doc