diff mbox

[U-Boot] kw_gpio: fix error in kw_gpio_direction_input

Message ID 1314004866-11454-1-git-send-email-holger.brunck@keymile.com
State Accepted
Commit e5afdf584c1e217b19579ba88e415ff8eb657fd8
Headers show

Commit Message

Holger Brunck Aug. 22, 2011, 9:21 a.m. UTC 
The function kw_gpio_is_valid returns zero on success, so
adapt the error check accordingly.

Signed-off-by: Holger Brunck <holger.brunck@keymile.com>
cc: Prafulla Wadaskar <prafulla@marvell.com>
cc: Dieter Kiermaier <dk-arm-linux@gmx.de>
---
 drivers/gpio/kw_gpio.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Comments

Wolfgang Denk Oct. 17, 2011, 7:57 p.m. UTC | #1 
Dear Holger Brunck,

In message <1314004866-11454-1-git-send-email-holger.brunck@keymile.com> you wrote:
> The function kw_gpio_is_valid returns zero on success, so
> adapt the error check accordingly.
> 
> Signed-off-by: Holger Brunck <holger.brunck@keymile.com>
> cc: Prafulla Wadaskar <prafulla@marvell.com>
> cc: Dieter Kiermaier <dk-arm-linux@gmx.de>
> ---
>  drivers/gpio/kw_gpio.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)

Applied, thanks.

Best regards,

Wolfgang Denk
diff mbox

Patch

diff --git a/drivers/gpio/kw_gpio.c b/drivers/gpio/kw_gpio.c
index 56383c2..2de179e 100644
--- a/drivers/gpio/kw_gpio.c
+++ b/drivers/gpio/kw_gpio.c
@@ -109,7 +109,7 @@  void kw_gpio_set_valid(unsigned pin, int mode)
  */
 int kw_gpio_direction_input(unsigned pin)
 {
-	if (!kw_gpio_is_valid(pin, GPIO_INPUT_OK))
+	if (kw_gpio_is_valid(pin, GPIO_INPUT_OK) != 0)
 		return 1;
 
 	/* Configure GPIO direction. */