Patchwork [U-Boot] omap4: fix build warning due to signed unsigned comparison

login
register
mail settings
Submitter Aneesh V
Date Aug. 21, 2011, 7:40 a.m.
Message ID <1313912426-26026-1-git-send-email-aneesh@ti.com>
Download mbox | patch
Permalink /patch/110811/
State Accepted
Commit 34455b04fc35ff9d1e5bcac7bec91e7a32b44d7a
Delegated to: Albert ARIBAUD
Headers show

Comments

Aneesh V - Aug. 21, 2011, 7:40 a.m.
Signed-off-by: Aneesh V <aneesh@ti.com>
---
 arch/arm/include/asm/arch-omap4/clocks.h |   12 ++++++------
 1 files changed, 6 insertions(+), 6 deletions(-)
Albert ARIBAUD - Aug. 21, 2011, 8:17 a.m.
Hi Aneesh,

Le 21/08/2011 09:40, Aneesh V a écrit :
> Signed-off-by: Aneesh V<aneesh@ti.com>
> ---
>   arch/arm/include/asm/arch-omap4/clocks.h |   12 ++++++------
>   1 files changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/arch/arm/include/asm/arch-omap4/clocks.h b/arch/arm/include/asm/arch-omap4/clocks.h
> index 374e064..45c947d 100644
> --- a/arch/arm/include/asm/arch-omap4/clocks.h
> +++ b/arch/arm/include/asm/arch-omap4/clocks.h
> @@ -679,12 +679,12 @@ struct dpll_regs {
>   struct dpll_params {
>   	u32 m;
>   	u32 n;
> -	u8 m2;
> -	u8 m3;
> -	u8 m4;
> -	u8 m5;
> -	u8 m6;
> -	u8 m7;
> +	s8 m2;
> +	s8 m3;
> +	s8 m4;
> +	s8 m5;
> +	s8 m6;
> +	s8 m7;
>   };
>
>   #endif /* _CLOCKS_OMAP4_H_ */

Considering that is trivial, that it fixes the warnings on two ARM 
boards, that Sandeep allowed me to pull in some OMAP patches directly in 
u-boot-arm, and that will make 
<http://patchwork.ozlabs.org/patch/108865/> build omap4 boards cleanly,

Applied to u-boot-arm/master, thanks!

Amicalement,

Patch

diff --git a/arch/arm/include/asm/arch-omap4/clocks.h b/arch/arm/include/asm/arch-omap4/clocks.h
index 374e064..45c947d 100644
--- a/arch/arm/include/asm/arch-omap4/clocks.h
+++ b/arch/arm/include/asm/arch-omap4/clocks.h
@@ -679,12 +679,12 @@  struct dpll_regs {
 struct dpll_params {
 	u32 m;
 	u32 n;
-	u8 m2;
-	u8 m3;
-	u8 m4;
-	u8 m5;
-	u8 m6;
-	u8 m7;
+	s8 m2;
+	s8 m3;
+	s8 m4;
+	s8 m5;
+	s8 m6;
+	s8 m7;
 };
 
 #endif /* _CLOCKS_OMAP4_H_ */