diff mbox series

ext2: add missing brelse() in ext2_new_inode()

Message ID 20190530101042.32197-1-cgxu519@zoho.com.cn
State Not Applicable
Headers show
Series ext2: add missing brelse() in ext2_new_inode() | expand

Commit Message

Chengguang Xu May 30, 2019, 10:10 a.m. UTC
There is a missing brelse of bitmap_bh in an error
path of ext2_new_inode().

Signed-off-by: Chengguang Xu <cgxu519@zoho.com.cn>
---
 fs/ext2/ialloc.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Jan Kara May 30, 2019, 11:35 a.m. UTC | #1
On Thu 30-05-19 18:10:42, Chengguang Xu wrote:
> There is a missing brelse of bitmap_bh in an error
> path of ext2_new_inode().
> 
> Signed-off-by: Chengguang Xu <cgxu519@zoho.com.cn>

Thanks for the fix! Applied.

								Honza
> ---
>  fs/ext2/ialloc.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/fs/ext2/ialloc.c b/fs/ext2/ialloc.c
> index 334dea4e499d..fda7d3f5b4be 100644
> --- a/fs/ext2/ialloc.c
> +++ b/fs/ext2/ialloc.c
> @@ -509,6 +509,7 @@ struct inode *ext2_new_inode(struct inode *dir, umode_t mode,
>  	/*
>  	 * Scanned all blockgroups.
>  	 */
> +	brelse(bitmap_bh);
>  	err = -ENOSPC;
>  	goto fail;
>  got:
> -- 
> 2.20.1
> 
> 
> 
>
diff mbox series

Patch

diff --git a/fs/ext2/ialloc.c b/fs/ext2/ialloc.c
index 334dea4e499d..fda7d3f5b4be 100644
--- a/fs/ext2/ialloc.c
+++ b/fs/ext2/ialloc.c
@@ -509,6 +509,7 @@  struct inode *ext2_new_inode(struct inode *dir, umode_t mode,
 	/*
 	 * Scanned all blockgroups.
 	 */
+	brelse(bitmap_bh);
 	err = -ENOSPC;
 	goto fail;
 got: