Patchwork [U-Boot] Fix compilation for OMAP3 EVM

login
register
mail settings
Submitter Vincent
Date Aug. 19, 2011, 10:37 p.m.
Message ID <1313793472-8785-1-git-send-email-vincent.stehle@laposte.net>
Download mbox | patch
Permalink /patch/110744/
State Not Applicable
Headers show

Comments

Vincent - Aug. 19, 2011, 10:37 p.m.
Signed-off-by: Vincent Stehlé <vincent.stehle@laposte.net>
---
 board/ti/evm/evm.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
Dirk Behme - Aug. 20, 2011, 5:07 a.m.
On 20.08.2011 00:37, Vincent wrote:
> Signed-off-by: Vincent Stehlé<vincent.stehle@laposte.net>
> ---
>   board/ti/evm/evm.c |    1 -
>   1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/board/ti/evm/evm.c b/board/ti/evm/evm.c
> index 30c1c57..d0604e9 100644
> --- a/board/ti/evm/evm.c
> +++ b/board/ti/evm/evm.c
> @@ -33,7 +33,6 @@
>   #include<asm/arch/mem.h>
>   #include<asm/arch/mux.h>
>   #include<asm/arch/sys_proto.h>
> -#include<asm/arch/gpio.h>
>   #include<i2c.h>
>   #include<asm/mach-types.h>
>   #include "evm.h"

On which branch do you see this issue? u-boot master? Which error do 
you see? Does

http://patchwork.ozlabs.org/patch/107678/

fix the issue you see, too?

Thanks

Dirk
Vincent - Aug. 20, 2011, 11:24 a.m.
> On which branch do you see this issue? u-boot master?

Yes, on 'master'. I used commit fa82f871c8dbc9a15e8dc274b3f99dd5fa0da458.

> Which error do you see?

evm.c:36:27: error: asm/arch/gpio.h: No such file or directory

Here is the end of the build log:

...
make[1]: Entering directory
`/home/vincent/divers/ubuntu/natty-omap3evm/u-boot/board/ti/evm'
ccache arm-linux-gnueabi-gcc  -g  -Os   -fno-common -ffixed-r8
-msoft-float   -D__KERNEL__ -DCONFIG_SYS_TEXT_BASE=0x80008000
-I/home/vincent/divers/ubuntu/natty-omap3evm/u-boot/include -fno-builtin
-ffreestanding -nostdinc -isystem
/usr/lib/gcc/arm-linux-gnueabi/4.4.5/include -pipe  -DCONFIG_ARM
-D__ARM__ -marm  -mabi=aapcs-linux -mno-thumb-interwork -march=armv5
-Wall -Wstrict-prototypes -fno-stack-protector -Wno-format-nonliteral
-Wno-format-security   -o evm.o evm.c -c
evm.c:36:27: error: asm/arch/gpio.h: No such file or directory
evm.c: In function ‘reset_net_chip’:
evm.c:198: warning: implicit declaration of function ‘omap_request_gpio’
evm.c:205: warning: implicit declaration of function
‘omap_set_gpio_direction’
evm.c:208: warning: implicit declaration of function ‘omap_set_gpio_dataout’
make[1]: *** [evm.o] Error 1
make[1]: Leaving directory
`/home/vincent/divers/ubuntu/natty-omap3evm/u-boot/board/ti/evm'
make: *** [board/ti/evm/libevm.o] Error 2

> Does
> http://patchwork.ozlabs.org/patch/107678/
> fix the issue you see, too?

Hmm. The error is different but 'master' won't build either with this
patch applied.

Build log:

ccache arm-linux-gnueabi-gcc  -g  -Os   -fno-common -ffixed-r8
-msoft-float   -D__KERNEL__ -DCONFIG_SYS_TEXT_BASE=0x80008000
-I/home/vincent/divers/ubuntu/natty-omap3evm/u-boot/include -fno-builtin
-ffreestanding -nostdinc -isystem
/usr/lib/gcc/arm-linux-gnueabi/4.4.5/include -pipe  -DCONFIG_ARM
-D__ARM__ -marm  -mabi=aapcs-linux -mno-thumb-interwork -march=armv5
-Wall -Wstrict-prototypes -fno-stack-protector -Wno-format-nonliteral
-Wno-format-security   -o gpio.o gpio.c -c
gpio.c:39:27: error: asm/arch/gpio.h: No such file or directory
gpio.c: In function ‘get_gpio_bank’:
gpio.c:45: error: ‘omap_gpio_bank’ undeclared (first use in this function)
gpio.c:45: error: (Each undeclared identifier is reported only once
gpio.c:45: error: for each function it appears in.)
gpio.c: In function ‘_set_gpio_direction’:
gpio.c:74: error: dereferencing pointer to incomplete type
gpio.c:77: error: dereferencing pointer to incomplete type
gpio.c:78: error: ‘METHOD_GPIO_24XX’ undeclared (first use in this function)
gpio.c: In function ‘_set_gpio_dataout’:
gpio.c:105: error: dereferencing pointer to incomplete type
gpio.c:108: error: dereferencing pointer to incomplete type
gpio.c:109: error: ‘METHOD_GPIO_24XX’ undeclared (first use in this
function)
gpio.c: In function ‘omap_get_gpio_datain’:
gpio.c:142: error: dereferencing pointer to incomplete type
gpio.c:143: error: dereferencing pointer to incomplete type
gpio.c:144: error: ‘METHOD_GPIO_24XX’ undeclared (first use in this
function)
make[1]: *** [gpio.o] Error 1
make[1]: Leaving directory
`/home/vincent/divers/ubuntu/natty-omap3evm/u-boot/arch/arm/cpu/armv7/omap-common'
make: *** [arch/arm/cpu/armv7/omap-common/libomap-common.o] Error 2

Best regards,

Patch

diff --git a/board/ti/evm/evm.c b/board/ti/evm/evm.c
index 30c1c57..d0604e9 100644
--- a/board/ti/evm/evm.c
+++ b/board/ti/evm/evm.c
@@ -33,7 +33,6 @@ 
 #include <asm/arch/mem.h>
 #include <asm/arch/mux.h>
 #include <asm/arch/sys_proto.h>
-#include <asm/arch/gpio.h>
 #include <i2c.h>
 #include <asm/mach-types.h>
 #include "evm.h"