Message ID | 20190528093914.4672-4-uboot@andestech.com |
---|---|
State | Superseded |
Delegated to: | Andes |
Headers | show |
Series | Support Andes RISC-V l2cache on AE350 platform | expand |
Hi Rick, On Tue, May 28, 2019 at 5:44 PM Andes <uboot@andestech.com> wrote: > > From: Rick Chen <rick@andestech.com> > > Select the v5l2 UCLASS_CACHE driver for AE350. > > Signed-off-by: Rick Chen <rick@andestech.com> > Cc: Greentime Hu <greentime@andestech.com> > --- > board/AndesTech/ax25-ae350/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/board/AndesTech/ax25-ae350/Kconfig b/board/AndesTech/ax25-ae350/Kconfig > index 5e682b6..dd299d9 100644 > --- a/board/AndesTech/ax25-ae350/Kconfig > +++ b/board/AndesTech/ax25-ae350/Kconfig > @@ -25,5 +25,6 @@ config BOARD_SPECIFIC_OPTIONS # dummy > def_bool y > select RISCV_NDS > imply SMP > + imply V5L2_CACHE I believe L2 cache is a CPU specific feature, hence this should be implied from arch/riscv/cpu/ax25/Kconfig Regards, Bin
Hi Bin > > Hi Rick, > > On Tue, May 28, 2019 at 5:44 PM Andes <uboot@andestech.com> wrote: > > > > From: Rick Chen <rick@andestech.com> > > > > Select the v5l2 UCLASS_CACHE driver for AE350. > > > > Signed-off-by: Rick Chen <rick@andestech.com> > > Cc: Greentime Hu <greentime@andestech.com> > > --- > > board/AndesTech/ax25-ae350/Kconfig | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/board/AndesTech/ax25-ae350/Kconfig b/board/AndesTech/ax25-ae350/Kconfig > > index 5e682b6..dd299d9 100644 > > --- a/board/AndesTech/ax25-ae350/Kconfig > > +++ b/board/AndesTech/ax25-ae350/Kconfig > > @@ -25,5 +25,6 @@ config BOARD_SPECIFIC_OPTIONS # dummy > > def_bool y > > select RISCV_NDS > > imply SMP > > + imply V5L2_CACHE > > I believe L2 cache is a CPU specific feature, hence this should be > implied from arch/riscv/cpu/ax25/Kconfig OK I will move it to arch/riscv/cpu/ax25/Kconfig Thanks Rick > > Regards, > Bin
diff --git a/board/AndesTech/ax25-ae350/Kconfig b/board/AndesTech/ax25-ae350/Kconfig index 5e682b6..dd299d9 100644 --- a/board/AndesTech/ax25-ae350/Kconfig +++ b/board/AndesTech/ax25-ae350/Kconfig @@ -25,5 +25,6 @@ config BOARD_SPECIFIC_OPTIONS # dummy def_bool y select RISCV_NDS imply SMP + imply V5L2_CACHE endif