| Message ID | 20190527124051.7615-2-geert+renesas@glider.be |
|---|---|
| State | New |
| Headers | show |
| Series | gpio: em: Miscellaneous probe cleanups | expand |
On Mon, May 27, 2019 at 2:40 PM Geert Uytterhoeven <geert+renesas@glider.be> wrote: > There is no need to print error messages when memory allocations or > related operations fail, as the core will take care of that. > > Change the returned error codes to -ENOMEM to match the failure cause > while at it. > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> Patch applied. Yours, Linus Walleij
diff --git a/drivers/gpio/gpio-em.c b/drivers/gpio/gpio-em.c index 982e699a5b816582..18937a9b1a14a72c 100644 --- a/drivers/gpio/gpio-em.c +++ b/drivers/gpio/gpio-em.c @@ -305,16 +305,14 @@ static int em_gio_probe(struct platform_device *pdev) p->base0 = devm_ioremap_nocache(&pdev->dev, io[0]->start, resource_size(io[0])); if (!p->base0) { - dev_err(&pdev->dev, "failed to remap low I/O memory\n"); - ret = -ENXIO; + ret = -ENOMEM; goto err0; } p->base1 = devm_ioremap_nocache(&pdev->dev, io[1]->start, resource_size(io[1])); if (!p->base1) { - dev_err(&pdev->dev, "failed to remap high I/O memory\n"); - ret = -ENXIO; + ret = -ENOMEM; goto err0; }
There is no need to print error messages when memory allocations or related operations fail, as the core will take care of that. Change the returned error codes to -ENOMEM to match the failure cause while at it. Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> --- drivers/gpio/gpio-em.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)