From patchwork Thu Aug 18 08:20:19 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: MyungJoo Ham X-Patchwork-Id: 110503 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from mail-gy0-f184.google.com (mail-gy0-f184.google.com [209.85.160.184]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority" (verified OK)) by ozlabs.org (Postfix) with ESMTPS id 6AD20B6FD7 for ; Thu, 18 Aug 2011 18:20:27 +1000 (EST) Received: by gyg4 with SMTP id 4sf2674173gyg.11 for ; Thu, 18 Aug 2011 01:20:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=beta; h=mime-version:x-beenthere:received-spf:x-auditid:date:from:subject :in-reply-to:to:cc:message-id:x-mailer:references :x-originalarrivaltime:x-brightmail-tracker:x-original-sender :x-original-authentication-results:reply-to:precedence:mailing-list :list-id:x-google-group-id:list-post:list-help:list-archive:sender :list-subscribe:list-unsubscribe:content-type; bh=FwzFq3KUGITYUnyTne3qVjsU6L8CcLx/2FVvC//0tXw=; b=TTPJgIoPRn39avyrZJb8r5Nzj5X1kBMjFxQWn9Wu9ERue6IuS8zZebfXj3eV1/t+tY 91gcezknBte4Rz6zJIk23coZV2eX88anvVO720Ug+w2V5SnuCahjRZ6nRH2UvbxQcsGg c3fTM0gQMEC/hgbr77IZQKapdmdzrkh8ktmUE= Received: by 10.146.93.37 with SMTP id q37mr49489yab.7.1313655624199; Thu, 18 Aug 2011 01:20:24 -0700 (PDT) MIME-Version: 1.0 X-BeenThere: rtc-linux@googlegroups.com Received: by 10.101.204.19 with SMTP id g19ls6537809anq.5.gmail; Thu, 18 Aug 2011 01:20:23 -0700 (PDT) Received: by 10.101.137.32 with SMTP id p32mr535501ann.4.1313655623134; Thu, 18 Aug 2011 01:20:23 -0700 (PDT) Received: by 10.101.137.32 with SMTP id p32mr535500ann.4.1313655623106; Thu, 18 Aug 2011 01:20:23 -0700 (PDT) Received: from mailout1.samsung.com (mailout1.samsung.com [203.254.224.24]) by gmr-mx.google.com with ESMTP id kr11si3664876pbb.1.2011.08.18.01.20.22; Thu, 18 Aug 2011 01:20:23 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of myungjoo.ham@samsung.com designates 203.254.224.24 as permitted sender) client-ip=203.254.224.24; Received: from epcpsbgm2.samsung.com (mailout1.samsung.com [203.254.224.24]) by mailout1.samsung.com (Oracle Communications Messaging Exchange Server 7u4-19.01 64bit (built Sep 7 2010)) with ESMTP id <0LQ400CXA75FCJ30@mailout1.samsung.com> for rtc-linux@googlegroups.com; Thu, 18 Aug 2011 17:20:21 +0900 (KST) X-AuditID: cbfee61b-b7b7fae000005864-e5-4e4ccb45c462 Received: from epmmp1 ( [203.254.227.16]) by epcpsbgm2.samsung.com (MMPCPMTA) with SMTP id FA.0D.22628.54BCC4E4; Thu, 18 Aug 2011 17:20:21 +0900 (KST) Received: from TNRNDGASPAPP1.tn.corp.samsungelectronics.net ([165.213.149.150]) by mmp1.samsung.com (iPlanet Messaging Server 5.2 Patch 2 (built Jul 14 2004)) with ESMTPA id <0LQ4007KP75XUH@mmp1.samsung.com> for rtc-linux@googlegroups.com; Thu, 18 Aug 2011 17:20:21 +0900 (KST) Received: from localhost.localdomain ([165.213.219.116]) by TNRNDGASPAPP1.tn.corp.samsungelectronics.net with Microsoft SMTPSVC(6.0.3790.4675); Thu, 18 Aug 2011 17:21:04 +0900 Date: Thu, 18 Aug 2011 17:20:19 +0900 From: MyungJoo Ham Subject: [rtc-linux] [PATCH v2 1/2] rtc: rtc-s3c: Correct debug messages. In-reply-to: <1313655620-1046-1-git-send-email-myungjoo.ham@samsung.com> To: linux-kernel@vger.kernel.org Cc: rtc-linux@googlegroups.com, Alessandro Zummo , kyungmin.park@samsung.com, myungjoo.ham@gmail.com, Changhwan Youn , Kukjin Kim Message-id: <1313655620-1046-2-git-send-email-myungjoo.ham@samsung.com> X-Mailer: git-send-email 1.7.4.1 References: <1313655620-1046-1-git-send-email-myungjoo.ham@samsung.com> X-OriginalArrivalTime: 18 Aug 2011 08:21:04.0485 (UTC) FILETIME=[C5A1D950:01CC5D7F] X-Brightmail-Tracker: AAAAAA== X-Original-Sender: myungjoo.ham@samsung.com X-Original-Authentication-Results: gmr-mx.google.com; spf=pass (google.com: best guess record for domain of myungjoo.ham@samsung.com designates 203.254.224.24 as permitted sender) smtp.mail=myungjoo.ham@samsung.com Reply-To: rtc-linux@googlegroups.com Precedence: list Mailing-list: list rtc-linux@googlegroups.com; contact rtc-linux+owners@googlegroups.com List-ID: X-Google-Group-Id: 712029733259 List-Post: , List-Help: , List-Archive: Sender: rtc-linux@googlegroups.com List-Subscribe: , List-Unsubscribe: , RTC-S3C used to print out debug messages incorrectly. This patch corrects incorrect outputs. (undecoded bcd numbers, incorrectly decoded register values) This patch affects the pr-debug messages only. Signed-off-by: MyungJoo Ham Signed-off-by: Kyungmin Park --- Changes from v1 - Removed unnecessary line. --- drivers/rtc/rtc-s3c.c | 12 ++++++------ 1 files changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/rtc/rtc-s3c.c b/drivers/rtc/rtc-s3c.c index 9329dbb..067207a 100644 --- a/drivers/rtc/rtc-s3c.c +++ b/drivers/rtc/rtc-s3c.c @@ -152,10 +152,6 @@ static int s3c_rtc_gettime(struct device *dev, struct rtc_time *rtc_tm) goto retry_get_time; } - pr_debug("read time %04d.%02d.%02d %02d:%02d:%02d\n", - 1900 + rtc_tm->tm_year, rtc_tm->tm_mon, rtc_tm->tm_mday, - rtc_tm->tm_hour, rtc_tm->tm_min, rtc_tm->tm_sec); - rtc_tm->tm_sec = bcd2bin(rtc_tm->tm_sec); rtc_tm->tm_min = bcd2bin(rtc_tm->tm_min); rtc_tm->tm_hour = bcd2bin(rtc_tm->tm_hour); @@ -164,6 +160,11 @@ static int s3c_rtc_gettime(struct device *dev, struct rtc_time *rtc_tm) rtc_tm->tm_year = bcd2bin(rtc_tm->tm_year); rtc_tm->tm_year += 100; + + pr_debug("read time %04d.%02d.%02d %02d:%02d:%02d\n", + 1900 + rtc_tm->tm_year, rtc_tm->tm_mon, rtc_tm->tm_mday, + rtc_tm->tm_hour, rtc_tm->tm_min, rtc_tm->tm_sec); + rtc_tm->tm_mon -= 1; clk_disable(rtc_clk); @@ -269,10 +270,9 @@ static int s3c_rtc_setalarm(struct device *dev, struct rtc_wkalrm *alrm) clk_enable(rtc_clk); pr_debug("s3c_rtc_setalarm: %d, %04d.%02d.%02d %02d:%02d:%02d\n", alrm->enabled, - 1900 + tm->tm_year, tm->tm_mon, tm->tm_mday, + 1900 + tm->tm_year, tm->tm_mon + 1, tm->tm_mday, tm->tm_hour, tm->tm_min, tm->tm_sec); - alrm_en = readb(base + S3C2410_RTCALM) & S3C2410_RTCALM_ALMEN; writeb(0x00, base + S3C2410_RTCALM);