Patchwork [v2,4/6] vmware-vga: Eliminate vga_dirty_log_restart

login
register
mail settings
Submitter Jan Kiszka
Date Aug. 17, 2011, 10:41 p.m.
Message ID <00da5c78b143e9f1543a64ad0dd88c5dd47ca223.1313620857.git.jan.kiszka@web.de>
Download mbox | patch
Permalink /patch/110415/
State New
Headers show

Comments

Jan Kiszka - Aug. 17, 2011, 10:41 p.m.
From: Jan Kiszka <jan.kiszka@siemens.com>

After the conversion to the new Memory API, vga_dirty_log_restart became
seriously pointless. Remove it from vmware-vga and and then finally drop
the service.

CC: Andrzej Zaborowski <balrogg@gmail.com>
CC: Avi Kivity <avi@redhat.com>
Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---
 hw/vga.c        |    6 ------
 hw/vga_int.h    |    1 -
 hw/vmware_vga.c |    2 --
 3 files changed, 0 insertions(+), 9 deletions(-)

Patch

diff --git a/hw/vga.c b/hw/vga.c
index 33dc478..fe481dd 100644
--- a/hw/vga.c
+++ b/hw/vga.c
@@ -1533,12 +1533,6 @@  void vga_dirty_log_stop(VGACommonState *s)
     memory_region_set_log(&s->vram, false, DIRTY_MEMORY_VGA);
 }
 
-void vga_dirty_log_restart(VGACommonState *s)
-{
-    vga_dirty_log_stop(s);
-    vga_dirty_log_start(s);
-}
-
 /*
  * graphic modes
  */
diff --git a/hw/vga_int.h b/hw/vga_int.h
index 100d98c..6fc23a6 100644
--- a/hw/vga_int.h
+++ b/hw/vga_int.h
@@ -193,7 +193,6 @@  void vga_common_reset(VGACommonState *s);
 
 void vga_dirty_log_start(VGACommonState *s);
 void vga_dirty_log_stop(VGACommonState *s);
-void vga_dirty_log_restart(VGACommonState *s);
 
 extern const VMStateDescription vmstate_vga_common;
 uint32_t vga_ioport_read(void *opaque, uint32_t addr);
diff --git a/hw/vmware_vga.c b/hw/vmware_vga.c
index 0c94ef1..475829e 100644
--- a/hw/vmware_vga.c
+++ b/hw/vmware_vga.c
@@ -1173,8 +1173,6 @@  static int pci_vmsvga_initfn(PCIDevice *dev)
 
     iomem = &s->chip.vga.vram;
 
-    vga_dirty_log_restart(&s->chip.vga);
-
     s->card.config[PCI_CACHE_LINE_SIZE]	= 0x08;		/* Cache line size */
     s->card.config[PCI_LATENCY_TIMER] = 0x40;		/* Latency timer */
     s->card.config[PCI_INTERRUPT_LINE] = 0xff;		/* End */