From patchwork Wed May 22 18:55:47 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alex Hung X-Patchwork-Id: 1103532 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.ubuntu.com (client-ip=91.189.94.19; helo=huckleberry.canonical.com; envelope-from=fwts-devel-bounces@lists.ubuntu.com; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=canonical.com Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 458MKW0jwXz9s9T; Thu, 23 May 2019 04:55:56 +1000 (AEST) Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.86_2) (envelope-from ) id 1hTWP2-0003lr-6W; Wed, 22 May 2019 18:55:52 +0000 Received: from youngberry.canonical.com ([91.189.89.112]) by huckleberry.canonical.com with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.86_2) (envelope-from ) id 1hTWP0-0003ll-OV for fwts-devel@lists.ubuntu.com; Wed, 22 May 2019 18:55:50 +0000 Received: from 1.general.alexhung.us.vpn ([10.172.65.254] helo=canonical.com) by youngberry.canonical.com with esmtpsa (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.76) (envelope-from ) id 1hTWP0-0001A2-7x; Wed, 22 May 2019 18:55:50 +0000 From: Alex Hung To: fwts-devel@lists.ubuntu.com Subject: [PATCH] mtrr: set severity to critical for incorrect attributes Date: Wed, 22 May 2019 11:55:47 -0700 Message-Id: <20190522185547.26577-1-alex.hung@canonical.com> X-Mailer: git-send-email 2.17.1 X-BeenThere: fwts-devel@lists.ubuntu.com X-Mailman-Version: 2.1.20 Precedence: list List-Id: Firmware Test Suite Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: fwts-devel-bounces@lists.ubuntu.com Sender: "fwts-devel" The lpss device driver crashes OS when its PCI BAR ranges are set to write-combining in MTRR. The errors was caught as below, but they were medium failures and ignored. Therefore, change it to critical. Medium failures: 3 mtrr: Memory range 0x4010000000 to 0x4010000fff (0000:00:15.0) has incorrect attribute Write-Combining. mtrr: Memory range 0x4010001000 to 0x4010001fff (0000:00:15.1) has incorrect attribute Write-Combining. mtrr: Memory range 0x4010002000 to 0x4010002fff (0000:00:1e.0) has incorrect attribute Write-Combining. Signed-off-by: Alex Hung Acked-by: Ivan Hu Acked-by: Colin Ian King --- src/bios/mtrr/mtrr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/bios/mtrr/mtrr.c b/src/bios/mtrr/mtrr.c index 54b0d852..6aa11a24 100644 --- a/src/bios/mtrr/mtrr.c +++ b/src/bios/mtrr/mtrr.c @@ -495,7 +495,7 @@ static int validate_iomem(fwts_framework *fw) if ((type & type_mustnot) != 0) { failed++; - fwts_failed(fw, LOG_LEVEL_MEDIUM, + fwts_failed(fw, LOG_LEVEL_CRITICAL, "MTRRIncorrectAttr", "Memory range 0x%" PRIx64 " to 0x%" PRIx64 " (%s) " "has incorrect attribute%s.",