Message ID | 20190522090317.28716-3-jack@suse.cz |
---|---|
State | Accepted, archived |
Headers | show |
Series | ext4: Fix issues in ext4 truncate handling | expand |
On Wed, May 22, 2019 at 11:03:16AM +0200, Jan Kara wrote: > It is possible that unlinked inode enters ext4_setattr() (e.g. if > somebody calls ftruncate(2) on unlinked but still open file). In such > case we should not delete the inode from the orphan list if truncate > fails. Note that this is mostly a theoretical concern as filesystem is > corrupted if we reach this path anyway but let's be consistent in our > orphan handling. > > Reviewed-by: Ira Weiny <ira.weiny@intel.com> > Signed-off-by: Jan Kara <jack@suse.cz> Thanks, applied (and I added a cc:stable@kernel.org). - Ted
diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c index 9bcb7f2b86dd..c7f77c643008 100644 --- a/fs/ext4/inode.c +++ b/fs/ext4/inode.c @@ -5625,7 +5625,7 @@ int ext4_setattr(struct dentry *dentry, struct iattr *attr) up_write(&EXT4_I(inode)->i_data_sem); ext4_journal_stop(handle); if (error) { - if (orphan) + if (orphan && inode->i_nlink) ext4_orphan_del(NULL, inode); goto err_out; }