diff mbox series

[Darwin,testsuite] Fix PR 63891.

Message ID ABB0D534-9674-4909-B724-1C3EA20C1183@sandoe.co.uk
State New
Headers show
Series [Darwin,testsuite] Fix PR 63891. | expand

Commit Message

Iain Sandoe May 21, 2019, 4:38 p.m. UTC 
This is a testcase failing because one part of the codegen is (correctly)
generating the scan-asm-not signature.

Fixed by altering the build options. 

tested on x86_64-darwin16, applied to mainline,
Iain

gcc/testsuite/

2019-05-21  Iain Sandoe  <iain@sandoe.co.uk>

       PR target/63891
       * gcc.dg/darwin-weakimport-3.c: Adjust options and explain
       the reasons.

 2019-05-21  Uroš Bizjak  <ubizjak@gmail.com>
 
        * gcc.target/i386/vect-signbitf.c: New test.
diff mbox series

Patch

diff --git a/gcc/testsuite/gcc.dg/darwin-weakimport-3.c b/gcc/testsuite/gcc.dg/darwin-weakimport-3.c
index 77ab980..a15b5b0 100644
--- a/gcc/testsuite/gcc.dg/darwin-weakimport-3.c
+++ b/gcc/testsuite/gcc.dg/darwin-weakimport-3.c
@@ -1,5 +1,20 @@ 
 /* { dg-do compile { target *-*-darwin* } } */
-/* { dg-options "-fno-asynchronous-unwind-tables" } */
+
+/* Here we want to test if "foo" gets placed into a coalesced
+   section (it should not).
+
+   However, for i386, and PIC code we have a "get_pc thunk" that
+   is (correctly) placed in a coalesced section when using an older
+   linker - also unwind tables are emitted into coalesced.
+
+   With modern linkers this is moot, since even weak symbols
+   are emitted into the regular sections.
+
+   To avoid the unwind tables -fno-asynchronous-unwind-tables.
+   To ensure that we emit code for an older linker -mtarget-linker
+   To avoid the get_pc thunk optimise at least O1.  */
+
+/* { dg-options "-fno-asynchronous-unwind-tables -O1 -mtarget-linker 85.2" } */
 /* { dg-require-weak "" } */
 
 /* { dg-final { scan-assembler-not "coalesced" } } */