[ethtool] ethtool.spec: Use standard file location macros
diff mbox series

Message ID 1558339780-8314-1-git-send-email-tariqt@mellanox.com
State Accepted
Delegated to: John Linville
Headers show
Series
  • [ethtool] ethtool.spec: Use standard file location macros
Related show

Commit Message

Tariq Toukan May 20, 2019, 8:09 a.m. UTC
From: Mikhael Goikhman <migo@mellanox.com>

Use _prefix and _sbindir macros to allow building the package under a
different prefix.

Signed-off-by: Mikhael Goikhman <migo@mellanox.com>
Signed-off-by: Tzafrir Cohen <tzafrirc@mellanox.com>
Signed-off-by: Tariq Toukan <tariqt@mellanox.com>
---
 ethtool.spec.in | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

John W. Linville June 14, 2019, 6:39 p.m. UTC | #1
On Mon, May 20, 2019 at 11:09:40AM +0300, Tariq Toukan wrote:
> From: Mikhael Goikhman <migo@mellanox.com>
> 
> Use _prefix and _sbindir macros to allow building the package under a
> different prefix.
> 
> Signed-off-by: Mikhael Goikhman <migo@mellanox.com>
> Signed-off-by: Tzafrir Cohen <tzafrirc@mellanox.com>
> Signed-off-by: Tariq Toukan <tariqt@mellanox.com>
> ---
>  ethtool.spec.in | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Thanks for the patch! Queued for next release...

John

Patch
diff mbox series

diff --git a/ethtool.spec.in b/ethtool.spec.in
index 6e9e1f591240..9c01b07abf2b 100644
--- a/ethtool.spec.in
+++ b/ethtool.spec.in
@@ -22,7 +22,7 @@  network devices, especially Ethernet devices.
 
 
 %build
-CFLAGS="${RPM_OPT_FLAGS}" ./configure --prefix=/usr --mandir=%{_mandir}
+CFLAGS="${RPM_OPT_FLAGS}" ./configure --prefix=%{_prefix} --mandir=%{_mandir}
 make
 
 
@@ -32,7 +32,7 @@  make install DESTDIR=${RPM_BUILD_ROOT}
 
 %files
 %defattr(-,root,root)
-/usr/sbin/ethtool
+%{_sbindir}/ethtool
 %{_mandir}/man8/ethtool.8*
 %doc AUTHORS COPYING NEWS README