| Message ID | CAKdteOY+scwNRJXumU5NTnz-002QALQBnru6-aZdod3_9Ayobg@mail.gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | [testsuite] aarch64,arm Add missing quotes to expected error message | expand |
On Mon, May 20, 2019 at 7:57 AM Christophe Lyon <christophe.lyon@linaro.org> wrote: > > Hi, > > After Martin's commit r271338, we now emit quotes around reserved > names, and some tests started to fail on aarch64 and arm. > > This should fix them, OK? Looks obvious to me. R > > Christophe
On 5/20/19 12:56 AM, Christophe Lyon wrote: > Hi, > > After Martin's commit r271338, we now emit quotes around reserved > names, and some tests started to fail on aarch64 and arm. > > This should fix them, OK? Thanks! There will probably be a few more like this on other targets. Jeff has been running a comprehensive build & test over the weekend so we should be able to clean them up this week. Martin
On 5/20/19 8:50 AM, Martin Sebor wrote: > On 5/20/19 12:56 AM, Christophe Lyon wrote: >> Hi, >> >> After Martin's commit r271338, we now emit quotes around reserved >> names, and some tests started to fail on aarch64 and arm. >> >> This should fix them, OK? > > Thanks! There will probably be a few more like this on other > targets. Jeff has been running a comprehensive build & test > over the weekend so we should be able to clean them up this > week. Yea. It looks like there's fallout on the 16 bit targets where the diagnostics need minor updating. That's first on the list. But overall the fallout looks minor. jeff
On 5/20/19 8:50 AM, Martin Sebor wrote: > On 5/20/19 12:56 AM, Christophe Lyon wrote: >> Hi, >> >> After Martin's commit r271338, we now emit quotes around reserved >> names, and some tests started to fail on aarch64 and arm. >> >> This should fix them, OK? > > Thanks! There will probably be a few more like this on other > targets. Jeff has been running a comprehensive build & test > over the weekend so we should be able to clean them up this > week. I've committed the fix for the 16 bit integer targets. There's a couple other failures I'm looking at now to see if they're related to the diagnostic cleanup or something different. jeff
diff --git a/gcc/testsuite/gcc.target/aarch64/target_attr_10.c b/gcc/testsuite/gcc.target/aarch64/target_attr_10.c index 1849904..d96a873 100644 --- a/gcc/testsuite/gcc.target/aarch64/target_attr_10.c +++ b/gcc/testsuite/gcc.target/aarch64/target_attr_10.c @@ -13,4 +13,4 @@ foo (uint8x16_t a, uint8x16_t b, uint8x16_t c) return vbslq_u8 (a, b, c); /* { dg-message "called from here" } */ } -/* { dg-error "inlining failed in call to always_inline" "" { target *-*-* } 0 } */ +/* { dg-error "inlining failed in call to 'always_inline'" "" { target *-*-* } 0 } */ diff --git a/gcc/testsuite/gcc.target/arm/attr-neon-builtin-fail.c b/gcc/testsuite/gcc.target/arm/attr-neon-builtin-fail.c index 05dc579..fb6e0b9 100644 --- a/gcc/testsuite/gcc.target/arm/attr-neon-builtin-fail.c +++ b/gcc/testsuite/gcc.target/arm/attr-neon-builtin-fail.c @@ -14,5 +14,5 @@ foo (uint8x16_t *p) *p = vmovq_n_u8 (3); /* { dg-message "called from here" } */ } -/* { dg-error "inlining failed in call to always_inline" "" { target *-*-* } 0 } */ +/* { dg-error "inlining failed in call to 'always_inline'" "" { target *-*-* } 0 } */