Patchwork mtd/nand: Don't add disabled nand flash devices

login
register
mail settings
Submitter Chunhe Lan
Date Aug. 16, 2011, 9:27 a.m.
Message ID <1313486855-15233-1-git-send-email-Chunhe.Lan@freescale.com>
Download mbox | patch
Permalink /patch/110165/
State New
Headers show

Comments

Chunhe Lan - Aug. 16, 2011, 9:27 a.m.
Nand flash nodes with the property status="disabled" are not
usable and so avoid adding "disabled" nand flash devices with
the system.

Signed-off-by: Chunhe Lan <Chunhe.Lan@freescale.com>
---
 drivers/mtd/nand/fsl_elbc_nand.c |    5 ++++-
 1 files changed, 4 insertions(+), 1 deletions(-)
Scott Wood - Aug. 16, 2011, 9:46 p.m.
On 08/16/2011 04:27 AM, Chunhe Lan wrote:
> Nand flash nodes with the property status="disabled" are not
> usable and so avoid adding "disabled" nand flash devices with
> the system.
> 
> Signed-off-by: Chunhe Lan <Chunhe.Lan@freescale.com>
> ---
>  drivers/mtd/nand/fsl_elbc_nand.c |    5 ++++-
>  1 files changed, 4 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/mtd/nand/fsl_elbc_nand.c b/drivers/mtd/nand/fsl_elbc_nand.c
> index 33d8aad..8212c12 100644
> --- a/drivers/mtd/nand/fsl_elbc_nand.c
> +++ b/drivers/mtd/nand/fsl_elbc_nand.c
> @@ -1,6 +1,6 @@
>  /* Freescale Enhanced Local Bus Controller NAND driver
>   *
> - * Copyright © 2006-2007, 2010 Freescale Semiconductor
> + * Copyright © 2006-2007, 2010-2011 Freescale Semiconductor
>   *
>   * Authors: Nick Spence <nick.spence@freescale.com>,
>   *          Scott Wood <scottwood@freescale.com>
> @@ -849,6 +849,9 @@ static int __devinit fsl_elbc_nand_probe(struct platform_device *pdev)
>  	struct device *dev;
>  	struct device_node *node = pdev->dev.of_node;
>  
> +	if (!of_device_is_available(node))
> +		return -ENODEV;
> +
>  	if (!fsl_lbc_ctrl_dev || !fsl_lbc_ctrl_dev->regs)
>  		return -ENODEV;
>  	lbc = fsl_lbc_ctrl_dev->regs;

Same comment as the other patch -- unavailable devices should already
not be getting probed.  Also, this subject line makes it sound like this
is a NAND subsystem change rather than a change in one specific driver.

-Scott
Lan Chunhe-B25806 - Aug. 22, 2011, 10:04 a.m.
On Wed, 17 Aug 2011 05:46:29 +0800, Scott Wood <scottwood@freescale.com>  
wrote:

> On 08/16/2011 04:27 AM, Chunhe Lan wrote:
>> Nand flash nodes with the property status="disabled" are not
>> usable and so avoid adding "disabled" nand flash devices with
>> the system.
>>
>> Signed-off-by: Chunhe Lan <Chunhe.Lan@freescale.com>
>> ---
>>  drivers/mtd/nand/fsl_elbc_nand.c |    5 ++++-
>>  1 files changed, 4 insertions(+), 1 deletions(-)
>>
>> diff --git a/drivers/mtd/nand/fsl_elbc_nand.c  
>> b/drivers/mtd/nand/fsl_elbc_nand.c
>> index 33d8aad..8212c12 100644
>> --- a/drivers/mtd/nand/fsl_elbc_nand.c
>> +++ b/drivers/mtd/nand/fsl_elbc_nand.c
>> @@ -1,6 +1,6 @@
>>  /* Freescale Enhanced Local Bus Controller NAND driver
>>   *
>> - * Copyright © 2006-2007, 2010 Freescale Semiconductor
>> + * Copyright © 2006-2007, 2010-2011 Freescale Semiconductor
>>   *
>>   * Authors: Nick Spence <nick.spence@freescale.com>,
>>   *          Scott Wood <scottwood@freescale.com>
>> @@ -849,6 +849,9 @@ static int __devinit fsl_elbc_nand_probe(struct  
>> platform_device *pdev)
>>  	struct device *dev;
>>  	struct device_node *node = pdev->dev.of_node;
>>
>> +	if (!of_device_is_available(node))
>> +		return -ENODEV;
>> +
>>  	if (!fsl_lbc_ctrl_dev || !fsl_lbc_ctrl_dev->regs)
>>  		return -ENODEV;
>>  	lbc = fsl_lbc_ctrl_dev->regs;
>
> Same comment as the other patch -- unavailable devices should already
> not be getting probed.  Also, this subject line makes it sound like this
> is a NAND subsystem change rather than a change in one specific driver.

    You are right.
    The upper layers have prevented unavailable devices.
    So, this patch is no need.

    Thanks.

    -Jack Lan

> -Scott

Patch

diff --git a/drivers/mtd/nand/fsl_elbc_nand.c b/drivers/mtd/nand/fsl_elbc_nand.c
index 33d8aad..8212c12 100644
--- a/drivers/mtd/nand/fsl_elbc_nand.c
+++ b/drivers/mtd/nand/fsl_elbc_nand.c
@@ -1,6 +1,6 @@ 
 /* Freescale Enhanced Local Bus Controller NAND driver
  *
- * Copyright © 2006-2007, 2010 Freescale Semiconductor
+ * Copyright © 2006-2007, 2010-2011 Freescale Semiconductor
  *
  * Authors: Nick Spence <nick.spence@freescale.com>,
  *          Scott Wood <scottwood@freescale.com>
@@ -849,6 +849,9 @@  static int __devinit fsl_elbc_nand_probe(struct platform_device *pdev)
 	struct device *dev;
 	struct device_node *node = pdev->dev.of_node;
 
+	if (!of_device_is_available(node))
+		return -ENODEV;
+
 	if (!fsl_lbc_ctrl_dev || !fsl_lbc_ctrl_dev->regs)
 		return -ENODEV;
 	lbc = fsl_lbc_ctrl_dev->regs;