Patchwork [U-Boot,4/7] led: correct off/on locations in structure

login
register
mail settings
Submitter Joel Fernandes
Date Aug. 16, 2011, 2:42 a.m.
Message ID <1313462527-3876-4-git-send-email-agnel.joel@gmail.com>
Download mbox | patch
Permalink /patch/110128/
State Accepted
Commit 4086b51cb7eac451f96130affbc17094a9e7b75a
Delegated to: Sandeep Paulraj
Headers show

Comments

Joel Fernandes - Aug. 16, 2011, 2:42 a.m.
From: Jason Kridner <jkridner@beagleboard.org>

Although the initialization should probably be done with names, the
existing implementation has these structures filled in the opposite
order.

Signed-off-by: Jason Kridner <jkridner@beagleboard.org>
Signed-off-by: Koen Kooi <koen@dominion.thruhere.net>
Signed-off-by: Joel A Fernandes <agnel.joel@gmail.com>
---
 common/cmd_led.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

Patch

diff --git a/common/cmd_led.c b/common/cmd_led.c
index 8b46848..d14dd5a 100644
--- a/common/cmd_led.c
+++ b/common/cmd_led.c
@@ -34,8 +34,8 @@ 
 struct led_tbl_s {
 	char		*string;	/* String for use in the command */
 	led_id_t	mask;		/* Mask used for calling __led_set() */
-	void		(*on)(void);	/* Optional fucntion for turning LED on */
-	void		(*off)(void);	/* Optional fucntion for turning LED on */
+	void		(*off)(void);	/* Optional function for turning LED off */
+	void		(*on)(void);	/* Optional function for turning LED on */
 };
 
 typedef struct led_tbl_s led_tbl_t;