| Message ID | 20190517095628.10119-2-mreitz@redhat.com |
|---|---|
| State | New |
| Headers | show |
| Series | iotests: Selfish patches | expand |
On 17/05/2019 11.56, Max Reitz wrote: > Without this argument, qemu will print an angry message about not being > able to connect to a display server if $DISPLAY is not set. For me, > that breaks iotests.supported_formats() because it thus only sees > ["Could", "not", "connect"] as the supported formats. > > Signed-off-by: Max Reitz <mreitz@redhat.com> > --- > tests/qemu-iotests/check | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/qemu-iotests/check b/tests/qemu-iotests/check > index f9c24b6753..d6fec4bf3c 100755 > --- a/tests/qemu-iotests/check > +++ b/tests/qemu-iotests/check > @@ -130,7 +130,7 @@ export CACHEMODE="writeback" > export QEMU_IO_OPTIONS="" > export QEMU_IO_OPTIONS_NO_FMT="" > export CACHEMODE_IS_DEFAULT=true > -export QEMU_OPTIONS="-nodefaults -machine accel=qtest" > +export QEMU_OPTIONS="-nodefaults -machine accel=qtest -display none" > export VALGRIND_QEMU= > export IMGKEYSECRET= > export IMGOPTSSYNTAX=false > Reviewed-by: Thomas Huth <thuth@redhat.com>
Max Reitz <mreitz@redhat.com> writes: > Without this argument, qemu will print an angry message about not being > able to connect to a display server if $DISPLAY is not set. For me, > that breaks iotests.supported_formats() because it thus only sees > ["Could", "not", "connect"] as the supported formats. > > Signed-off-by: Max Reitz <mreitz@redhat.com> Reviewed-by: Alex Bennée <alex.bennee@linaro.org> > --- > tests/qemu-iotests/check | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/qemu-iotests/check b/tests/qemu-iotests/check > index f9c24b6753..d6fec4bf3c 100755 > --- a/tests/qemu-iotests/check > +++ b/tests/qemu-iotests/check > @@ -130,7 +130,7 @@ export CACHEMODE="writeback" > export QEMU_IO_OPTIONS="" > export QEMU_IO_OPTIONS_NO_FMT="" > export CACHEMODE_IS_DEFAULT=true > -export QEMU_OPTIONS="-nodefaults -machine accel=qtest" > +export QEMU_OPTIONS="-nodefaults -machine accel=qtest -display none" > export VALGRIND_QEMU= > export IMGKEYSECRET= > export IMGOPTSSYNTAX=false -- Alex Bennée
diff --git a/tests/qemu-iotests/check b/tests/qemu-iotests/check index f9c24b6753..d6fec4bf3c 100755 --- a/tests/qemu-iotests/check +++ b/tests/qemu-iotests/check @@ -130,7 +130,7 @@ export CACHEMODE="writeback" export QEMU_IO_OPTIONS="" export QEMU_IO_OPTIONS_NO_FMT="" export CACHEMODE_IS_DEFAULT=true -export QEMU_OPTIONS="-nodefaults -machine accel=qtest" +export QEMU_OPTIONS="-nodefaults -machine accel=qtest -display none" export VALGRIND_QEMU= export IMGKEYSECRET= export IMGOPTSSYNTAX=false
Without this argument, qemu will print an angry message about not being able to connect to a display server if $DISPLAY is not set. For me, that breaks iotests.supported_formats() because it thus only sees ["Could", "not", "connect"] as the supported formats. Signed-off-by: Max Reitz <mreitz@redhat.com> --- tests/qemu-iotests/check | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)