diff mbox series

[OpenWrt-Devel] interface-ip: fix find locally addressabletarget for p2p

Message ID AM6PR03MB4821E7027EF336E03B57C642B50A0@AM6PR03MB4821.eurprd03.prod.outlook.com
State Superseded
Headers show
Series [OpenWrt-Devel] interface-ip: fix find locally addressabletarget for p2p | expand

Commit Message

Tan Xiaofan May 16, 2019, 2 p.m. UTC 
From d0e1cb81b45ec825199d499cda9c8daef94e13a5 Mon Sep 17 00:00:00 2001
From: xiaofan <xfan1024@live.com>
Date: Thu, 16 May 2019 21:12:47 +0800
Subject: [PATCH] interface-ip: fix find locally addressable target for p2p

Signed-off-by: xiaofan <xfan1024@live.com>
---
 interface-ip.c | 4 ++++
 1 file changed, 4 insertions(+)

--
2.17.1

Comments

Hans Dedecker May 16, 2019, 2:27 p.m. UTC | #1 
Hi,

On Thu, May 16, 2019 at 4:01 PM Tan Xiaofan <xfan1024@live.com> wrote:
>
> From d0e1cb81b45ec825199d499cda9c8daef94e13a5 Mon Sep 17 00:00:00 2001
> From: xiaofan <xfan1024@live.com>
> Date: Thu, 16 May 2019 21:12:47 +0800
> Subject: [PATCH] interface-ip: fix find locally addressable target for p2p
The patch fails to explain why this change is required and what
usecase/problem it fixes.

Hans
>
> Signed-off-by: xiaofan <xfan1024@live.com>
> ---
>  interface-ip.c | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/interface-ip.c b/interface-ip.c
> index 6900cd7..7ab8643 100644
> --- a/interface-ip.c
> +++ b/interface-ip.c
> @@ -196,6 +196,10 @@ __find_ip_addr_target(struct interface_ip_settings *ip, union if_addr *a, bool v
>    if (v6 != ((addr->flags & DEVADDR_FAMILY) == DEVADDR_INET6))
>     continue;
>
> +  if (!v6 && addr->point_to_point && a->in.s_addr == addr->point_to_point) {
> +   return true;
> +  }
> +
>    /* Handle offlink addresses correctly */
>    unsigned int mask = addr->mask;
>    if ((addr->flags & DEVADDR_FAMILY) == DEVADDR_INET6 &&
> --
> 2.17.1
>
>
> _______________________________________________
> openwrt-devel mailing list
> openwrt-devel@lists.openwrt.org
> https://lists.openwrt.org/mailman/listinfo/openwrt-devel
diff mbox series

Patch

diff --git a/interface-ip.c b/interface-ip.c
index 6900cd7..7ab8643 100644
--- a/interface-ip.c
+++ b/interface-ip.c
@@ -196,6 +196,10 @@  __find_ip_addr_target(struct interface_ip_settings *ip, union if_addr *a, bool v
   if (v6 != ((addr->flags & DEVADDR_FAMILY) == DEVADDR_INET6))
    continue;

+  if (!v6 && addr->point_to_point && a->in.s_addr == addr->point_to_point) {
+   return true;
+  }
+
   /* Handle offlink addresses correctly */
   unsigned int mask = addr->mask;
   if ((addr->flags & DEVADDR_FAMILY) == DEVADDR_INET6 &&