| Message ID | 1557988772-15406-9-git-send-email-nkristam@nvidia.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | Tegra XUSB gadget driver support | expand |
On Thu, May 16, 2019 at 12:09:32PM +0530, Nagarjuna Kristam wrote: > Enable support for Nvidia XUSB device mode controller driver. > > Signed-off-by: Nagarjuna Kristam <nkristam@nvidia.com> > --- > arch/arm64/configs/defconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig > index b605b7f..bf1437c 100644 > --- a/arch/arm64/configs/defconfig > +++ b/arch/arm64/configs/defconfig > @@ -575,6 +575,7 @@ CONFIG_USB_ULPI=y > CONFIG_USB_GADGET=y > CONFIG_USB_RENESAS_USBHS_UDC=m > CONFIG_USB_RENESAS_USB3=m > +CONFIG_USB_TEGRA_XUDC=y This driver is fairly large, do we really want to make it built-in by default? Are there any downsides to making this a loadable module? Thierry
On 23-05-2019 16:00, Thierry Reding wrote: > On Thu, May 16, 2019 at 12:09:32PM +0530, Nagarjuna Kristam wrote: >> Enable support for Nvidia XUSB device mode controller driver. >> >> Signed-off-by: Nagarjuna Kristam <nkristam@nvidia.com> >> --- >> arch/arm64/configs/defconfig | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig >> index b605b7f..bf1437c 100644 >> --- a/arch/arm64/configs/defconfig >> +++ b/arch/arm64/configs/defconfig >> @@ -575,6 +575,7 @@ CONFIG_USB_ULPI=y >> CONFIG_USB_GADGET=y >> CONFIG_USB_RENESAS_USBHS_UDC=m >> CONFIG_USB_RENESAS_USB3=m >> +CONFIG_USB_TEGRA_XUDC=y > > This driver is fairly large, do we really want to make it built-in by > default? Are there any downsides to making this a loadable module? > > Thierry > No downsides to make it as a module, will update change to mark it as module.
diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig index b605b7f..bf1437c 100644 --- a/arch/arm64/configs/defconfig +++ b/arch/arm64/configs/defconfig @@ -575,6 +575,7 @@ CONFIG_USB_ULPI=y CONFIG_USB_GADGET=y CONFIG_USB_RENESAS_USBHS_UDC=m CONFIG_USB_RENESAS_USB3=m +CONFIG_USB_TEGRA_XUDC=y CONFIG_MMC=y CONFIG_MMC_BLOCK_MINORS=32 CONFIG_MMC_ARMMMCI=y
Enable support for Nvidia XUSB device mode controller driver. Signed-off-by: Nagarjuna Kristam <nkristam@nvidia.com> --- arch/arm64/configs/defconfig | 1 + 1 file changed, 1 insertion(+)