ARC: [plat-hsdk] Get rid of inappropriate PHY settings
diff mbox series

Message ID 20190515153340.40074-1-abrodkin@synopsys.com
State New
Headers show
Series
  • ARC: [plat-hsdk] Get rid of inappropriate PHY settings
Related show

Commit Message

Alexey Brodkin May 15, 2019, 3:33 p.m. UTC
Initial bring-up of the platform was done on FPGA prototype
where TI's DP83867 PHY was used. And so some specific PHY
options were added.

Just to confirm this is what we get on FPGA prototype in the bootlog:
| TI DP83867 stmmac-0:00: attached PHY driver [TI DP83867] ...

On real board though we have Micrel KZS9031 PHY and we even have
CONFIG_MICREL_PHY=y set in hsdk_defconfig. That's what we see in the bootlog:
| Micrel KSZ9031 Gigabit PHY stmmac-0:00: ...

So essentially all TI-related bits have to go away.

Signed-off-by: Alexey Brodkin <abrodkin@synopsys.com>
Cc: Trent Piepho <tpiepho@impinj.com>
Cc: Rob Herring <robh+dt@kernel.org>
---
 arch/arc/boot/dts/hsdk.dts | 4 ----
 1 file changed, 4 deletions(-)

Comments

Trent Piepho May 15, 2019, 5:20 p.m. UTC | #1
On Wed, 2019-05-15 at 18:33 +0300, Alexey Brodkin wrote:
> Initial bring-up of the platform was done on FPGA prototype
> where TI's DP83867 PHY was used. And so some specific PHY
> options were added.
> 
> Just to confirm this is what we get on FPGA prototype in the bootlog:
> > TI DP83867 stmmac-0:00: attached PHY driver [TI DP83867] ...
> 
> On real board though we have Micrel KZS9031 PHY and we even have
> CONFIG_MICREL_PHY=y set in hsdk_defconfig. That's what we see in the bootlog:
> > Micrel KSZ9031 Gigabit PHY stmmac-0:00: ...
> 
> So essentially all TI-related bits have to go away.
> 
> Signed-off-by: Alexey Brodkin <abrodkin@synopsys.com>
> Cc: Trent Piepho <tpiepho@impinj.com>
> Cc: Rob Herring <robh+dt@kernel.org>

Acked-by: <tpiepho@impinj.com>

> ---
>  arch/arc/boot/dts/hsdk.dts | 4 ----
>  1 file changed, 4 deletions(-)
> 
> @@ -201,9 +200,6 @@

I think it would be pedantically correct to change the phy-mode to
"rgmii-id", though I see nothing in the micrel phy driver that uses
this, and so doubt it will do anything at all at this point.

The Micrel phy appears to default to putting a clock skew on the RGMII
lines and the driver will use the default if no properties are present.
So I believe what your board is effectively using now is "rgmii-id"
with default skews, unless the phy and your board design has some
resistor pin strapping that has changed this.
Vineet Gupta May 28, 2019, 5:10 p.m. UTC | #2
On 5/15/19 8:33 AM, Alexey Brodkin wrote:
> Initial bring-up of the platform was done on FPGA prototype
> where TI's DP83867 PHY was used. And so some specific PHY
> options were added.
> 
> Just to confirm this is what we get on FPGA prototype in the bootlog:
> | TI DP83867 stmmac-0:00: attached PHY driver [TI DP83867] ...
> 
> On real board though we have Micrel KZS9031 PHY and we even have
> CONFIG_MICREL_PHY=y set in hsdk_defconfig. That's what we see in the bootlog:
> | Micrel KSZ9031 Gigabit PHY stmmac-0:00: ...
> 
> So essentially all TI-related bits have to go away.
> 
> Signed-off-by: Alexey Brodkin <abrodkin@synopsys.com>
> Cc: Trent Piepho <tpiepho@impinj.com>
> Cc: Rob Herring <robh+dt@kernel.org>

Added to for-curr.

Thx,
-Vineet

Patch
diff mbox series

diff --git a/arch/arc/boot/dts/hsdk.dts b/arch/arc/boot/dts/hsdk.dts
index 7425bb0f2d1b..f88a898029ce 100644
--- a/arch/arc/boot/dts/hsdk.dts
+++ b/arch/arc/boot/dts/hsdk.dts
@@ -11,7 +11,6 @@ 
  */
 /dts-v1/;
 
-#include <dt-bindings/net/ti-dp83867.h>
 #include <dt-bindings/reset/snps,hsdk-reset.h>
 
 / {
@@ -201,9 +200,6 @@ 
 				compatible = "snps,dwmac-mdio";
 				phy0: ethernet-phy@0 {
 					reg = <0>;
-					ti,rx-internal-delay = <DP83867_RGMIIDCTL_2_00_NS>;
-					ti,tx-internal-delay = <DP83867_RGMIIDCTL_2_00_NS>;
-					ti,fifo-depth = <DP83867_PHYCR_FIFO_DEPTH_4_B_NIB>;
 				};
 			};
 		};