From patchwork Sat Aug 13 20:10:59 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jason Merrill X-Patchwork-Id: 109944 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id A2A0DB70C0 for ; Sun, 14 Aug 2011 06:11:56 +1000 (EST) Received: (qmail 10806 invoked by alias); 13 Aug 2011 20:11:25 -0000 Received: (qmail 10793 invoked by uid 22791); 13 Aug 2011 20:11:20 -0000 X-SWARE-Spam-Status: No, hits=-6.8 required=5.0 tests=AWL, BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 13 Aug 2011 20:11:03 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p7DKB1iK000952 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Sat, 13 Aug 2011 16:11:01 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p7DKB1rP029815 for ; Sat, 13 Aug 2011 16:11:01 -0400 Received: from [0.0.0.0] (ovpn-113-51.phx2.redhat.com [10.3.113.51]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id p7DKAxr5001744 for ; Sat, 13 Aug 2011 16:11:00 -0400 Message-ID: <4E46DA53.1070007@redhat.com> Date: Sat, 13 Aug 2011 16:10:59 -0400 From: Jason Merrill User-Agent: Mozilla/5.0 (X11; Linux i686; rv:5.0) Gecko/20110719 Thunderbird/5.0 MIME-Version: 1.0 To: gcc-patches List Subject: C++ PATCH for c++/50059 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org We were failing to print MODIFY_EXPR properly. I'm surprised that didn't turn up before now. Tested x86_64-pc-linux-gnu, applied to trunk. commit f8556f7a8d1bbf620edca19bd3d350ad7b82df7c Author: Jason Merrill Date: Sat Aug 13 03:01:09 2011 -0400 PR c++/50059 * error.c (dump_expr): Handle MODIFY_EXPR properly. diff --git a/gcc/cp/error.c b/gcc/cp/error.c index 3374488..48c0593 100644 --- a/gcc/cp/error.c +++ b/gcc/cp/error.c @@ -1868,6 +1868,10 @@ dump_expr (tree t, int flags) case INIT_EXPR: case MODIFY_EXPR: + dump_binary_op (assignment_operator_name_info[(int)NOP_EXPR].name, + t, flags); + break; + case PLUS_EXPR: case MINUS_EXPR: case MULT_EXPR: diff --git a/gcc/testsuite/g++.dg/diagnostic/expr1.C b/gcc/testsuite/g++.dg/diagnostic/expr1.C new file mode 100644 index 0000000..5651030 --- /dev/null +++ b/gcc/testsuite/g++.dg/diagnostic/expr1.C @@ -0,0 +1,9 @@ +// PR c++/50059 + +int i; +struct A { }; +void f(A); +void g() +{ + f(i = 0); // { dg-error "i = 0" } +}